Patch Detail
Show a patch.
GET /api/patches/20691/?format=api
{ "id": 20691, "url": "https://patchwork.libcamera.org/api/patches/20691/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20691/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240717100913.16640-6-jacopo.mondi@ideasonboard.com>", "date": "2024-07-17T10:09:08", "name": "[RFC,5/9] fixups: Make it compile", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c08246eeca4fbae7f65e68e9fc842b18a2b1266f", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20691/mbox/", "series": [ { "id": 4455, "url": "https://patchwork.libcamera.org/api/series/4455/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4455", "date": "2024-07-17T10:09:03", "name": "Handle Converter features differently", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4455/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20691/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20691/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B5B1C3243\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Jul 2024 10:09:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 148E263382;\n\tWed, 17 Jul 2024 12:09:38 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D94976336F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Jul 2024 12:09:28 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E1502ABE;\n\tWed, 17 Jul 2024 12:08:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pnD9N+ci\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721210931;\n\tbh=hQDRXTq2uBYowpiXe2ATjbRCs9EdyvNYwqK56ISW14M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pnD9N+ci3aDAEJCRi+hRYtWbZ9KMKKyiF+eA+1x+HvYidIQnVgTKktPrM3l5fmdzt\n\tdpp2hVoEBpn31FE3JR1A1OhdwFMK17+GzHa1p4RlqWhHG0WP5XgUrIGyXFWkcNQP4H\n\tnlVORblk/adTZw/DYBxIydQ+8MKt8N4UwsuU01cc=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "Umang Jain <umang.jain@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[RFC 5/9] fixups: Make it compile", "Date": "Wed, 17 Jul 2024 12:09:08 +0200", "Message-ID": "<20240717100913.16640-6-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>", "References": "<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/converter.cpp | 4 ++--\n src/libcamera/converter/converter_v4l2_m2m.cpp | 8 ++------\n 2 files changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\nindex 65f4f96bafa5..a959003aaa73 100644\n--- a/src/libcamera/converter.cpp\n+++ b/src/libcamera/converter.cpp\n@@ -177,7 +177,7 @@ Converter::~Converter()\n */\n int Converter::setCrop([[maybe_unused]] const Stream *stream, [[maybe_unused]] Rectangle *rect)\n {\n-\tif (!(getFeatures() & Feature::Crop)) {\n+\tif (!(features() & Feature::Crop)) {\n \t\tLOG(Converter, Error) << \"Converter doesn't support cropping capabilities\";\n \t\treturn -ENOTSUP;\n \t}\n@@ -200,7 +200,7 @@ std::pair<Rectangle, Rectangle> Converter::getCropBounds([[maybe_unused]] const\n \tconst StreamConfiguration &config = stream->configuration();\n \tRectangle rect;\n \n-\tif (!(getFeatures() & Feature::Crop))\n+\tif (!(features() & Feature::Crop))\n \t\tLOG(Converter, Error) << \"Converter doesn't support cropping capabilities\";\n \n \t/*\ndiff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex eaae35288194..e381e474c1c7 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -389,7 +389,7 @@ int V4L2M2MConverter::exportBuffers(const Stream *stream, unsigned int count,\n */\n int V4L2M2MConverter::setCrop(const Stream *stream, Rectangle *rect)\n {\n-\tif (!(getFeatures() & Feature::Crop))\n+\tif (!(features() & Feature::Crop))\n \t\treturn -ENOTSUP;\n \n \tauto iter = streams_.find(stream);\n@@ -414,7 +414,7 @@ V4L2M2MConverter::getCropBounds(const Stream *stream)\n \tmaxCrop.width = UINT_MAX;\n \tmaxCrop.height = UINT_MAX;\n \n-\tif (!(getFeatures() & Feature::Crop)) {\n+\tif (!(features() & Feature::Crop)) {\n \t\tLOG(Converter, Error) << \"Crop functionality is not supported\";\n \t\treturn {};\n \t}\n@@ -532,10 +532,6 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n \treturn 0;\n }\n \n-/*\n- * \\todo: This should be extended to include Feature::Flag to denote\n- * what each converter supports feature-wise.\n- */\n static std::initializer_list<std::string> compatibles = {\n \t\"mtk-mdp\",\n \t\"pxp\",\n", "prefixes": [ "RFC", "5/9" ] }