Patch Detail
Show a patch.
GET /api/patches/20688/?format=api
{ "id": 20688, "url": "https://patchwork.libcamera.org/api/patches/20688/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20688/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240717100913.16640-3-jacopo.mondi@ideasonboard.com>", "date": "2024-07-17T10:09:05", "name": "[RFC,2/9] fixup: Add Features at Converter registration time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d6233e075eab630dd43084e0807995430e2a6e05", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20688/mbox/", "series": [ { "id": 4455, "url": "https://patchwork.libcamera.org/api/series/4455/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4455", "date": "2024-07-17T10:09:03", "name": "Handle Converter features differently", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4455/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20688/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20688/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF96FBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Jul 2024 10:09:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E97D263375;\n\tWed, 17 Jul 2024 12:09:32 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7C5163371\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Jul 2024 12:09:27 +0200 (CEST)", "from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3CF4836;\n\tWed, 17 Jul 2024 12:08:49 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AhPT1u5U\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1721210930;\n\tbh=kcOAEenvH7G/QTCGDRqLsI+p61DJqTiO4QTbx/2+Xbg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AhPT1u5U+lgCRV0cDyWXLdcmWVGvEYO53DicEw8jM5bActGCKyQ8354nq+biXw/ZF\n\tTjDyUxFD+wHqdN43l8ZrAeOTW74NnsbkWSAbEx5Pa98QIm3RgU6PKeybLPnJjqnZcL\n\tfUBTxT4bfVS4UXiy/gUx6q9rSKJK4JkNYy1FIMVI=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "Umang Jain <umang.jain@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[RFC 2/9] fixup: Add Features at Converter registration time", "Date": "Wed, 17 Jul 2024 12:09:05 +0200", "Message-ID": "<20240717100913.16640-3-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>", "References": "<20240717100913.16640-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/internal/converter.h | 23 +++++++++++++----------\n src/libcamera/converter.cpp | 10 ++++++----\n 2 files changed, 19 insertions(+), 14 deletions(-)", "diff": "diff --git a/include/libcamera/internal/converter.h b/include/libcamera/internal/converter.h\nindex 7e4783566a44..ead465170d01 100644\n--- a/include/libcamera/internal/converter.h\n+++ b/include/libcamera/internal/converter.h\n@@ -39,7 +39,7 @@ public:\n \n \tusing Features = Flags<Feature>;\n \n-\tConverter(MediaDevice *media, Features features = Feature::None);\n+\tConverter(MediaDevice *media, Features features);\n \tvirtual ~Converter();\n \n \tvirtual int loadConfiguration(const std::string &filename) = 0;\n@@ -68,21 +68,22 @@ public:\n \n \tconst std::string &deviceNode() const { return deviceNode_; }\n \n-\tFeatures getFeatures() const { return features_; }\n+\tFeatures features() const { return features_; }\n \n private:\n \tstd::string deviceNode_;\n-\n \tFeatures features_;\n };\n \n class ConverterFactoryBase\n {\n public:\n-\tConverterFactoryBase(const std::string name, std::initializer_list<std::string> compatibles);\n+\tConverterFactoryBase(const std::string name, std::initializer_list<std::string> compatibles,\n+\t\t\t Converter::Features feat);\n \tvirtual ~ConverterFactoryBase() = default;\n \n \tconst std::vector<std::string> &compatibles() const { return compatibles_; }\n+\tconst Converter::Features features() const { return features_; }\n \n \tstatic std::unique_ptr<Converter> create(MediaDevice *media);\n \tstatic std::vector<ConverterFactoryBase *> &factories();\n@@ -93,28 +94,30 @@ private:\n \n \tstatic void registerType(ConverterFactoryBase *factory);\n \n-\tvirtual std::unique_ptr<Converter> createInstance(MediaDevice *media) const = 0;\n+\tvirtual std::unique_ptr<Converter> createInstance(MediaDevice *media, Converter::Features feat) const = 0;\n \n \tstd::string name_;\n \tstd::vector<std::string> compatibles_;\n+\tConverter::Features features_;\n };\n \n template<typename _Converter>\n class ConverterFactory : public ConverterFactoryBase\n {\n public:\n-\tConverterFactory(const char *name, std::initializer_list<std::string> compatibles)\n-\t\t: ConverterFactoryBase(name, compatibles)\n+\tConverterFactory(const char *name, std::initializer_list<std::string> compatibles, Converter::Features feat)\n+\t\t: ConverterFactoryBase(name, compatibles, feat)\n \t{\n \t}\n \n-\tstd::unique_ptr<Converter> createInstance(MediaDevice *media) const override\n+\tstd::unique_ptr<Converter> createInstance(MediaDevice *media, Converter::Features feat) const override\n \t{\n-\t\treturn std::make_unique<_Converter>(media);\n+\t\treturn std::make_unique<_Converter>(media, feat);\n \t}\n };\n \n #define REGISTER_CONVERTER(name, converter, compatibles) \\\n-\tstatic ConverterFactory<converter> global_##converter##Factory(name, compatibles);\n+\tstatic ConverterFactory<converter> global_##converter##Factory(name, compatibles, \\\n+\t\t\t\t\t\t\t\t Converter::Feature::None);\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\nindex 2c3da6d4502b..dcbc442ccf68 100644\n--- a/src/libcamera/converter.cpp\n+++ b/src/libcamera/converter.cpp\n@@ -178,7 +178,7 @@ Converter::~Converter()\n */\n \n /**\n- * \\fn Converter::getFeatures()\n+ * \\fn Converter::features()\n * \\brief Gets the supported features by the converter\n * \\return The converter Features flag\n */\n@@ -209,8 +209,10 @@ Converter::~Converter()\n * The factory \\a compatibles holds a list of driver names implementing a generic\n * subsystem without any personalizations.\n */\n-ConverterFactoryBase::ConverterFactoryBase(const std::string name, std::initializer_list<std::string> compatibles)\n-\t: name_(name), compatibles_(compatibles)\n+ConverterFactoryBase::ConverterFactoryBase(const std::string name,\n+\t\t\t\t\t std::initializer_list<std::string> compatibles,\n+\t\t\t\t\t Converter::Features feat)\n+\t: name_(name), compatibles_(compatibles), features_(feat)\n {\n \tregisterType(this);\n }\n@@ -247,7 +249,7 @@ std::unique_ptr<Converter> ConverterFactoryBase::create(MediaDevice *media)\n \t\t\t<< factory->name_ << \" factory with \"\n \t\t\t<< (it == compatibles.end() ? \"no\" : media->driver()) << \" alias.\";\n \n-\t\tstd::unique_ptr<Converter> converter = factory->createInstance(media);\n+\t\tstd::unique_ptr<Converter> converter = factory->createInstance(media, factory->features());\n \t\tif (converter->isValid())\n \t\t\treturn converter;\n \t}\n", "prefixes": [ "RFC", "2/9" ] }