Patch Detail
Show a patch.
GET /api/patches/20670/?format=api
{ "id": 20670, "url": "https://patchwork.libcamera.org/api/patches/20670/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20670/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240717085444.289997-9-mzamazal@redhat.com>", "date": "2024-07-17T08:54:29", "name": "[v3,08/23] libcamera: software_isp: Define skeletons for IPA refactoring", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8f45be84de55cce1a7f59821fdb224227d4033fa", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20670/mbox/", "series": [ { "id": 4454, "url": "https://patchwork.libcamera.org/api/series/4454/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4454", "date": "2024-07-17T08:54:21", "name": "Software ISP refactoring", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4454/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20670/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20670/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45E60C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Jul 2024 08:55:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C620A633AC;\n\tWed, 17 Jul 2024 10:55:27 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0183B6337D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Jul 2024 10:55:12 +0200 (CEST)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-1-bSJ5GmpIOESFkL3zoDqrzw-1;\n\tWed, 17 Jul 2024 04:55:10 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 5C3B21955D4E; Wed, 17 Jul 2024 08:55:09 +0000 (UTC)", "from nuthatch.brq.redhat.com (unknown [10.43.17.37])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 3A1431955F40; Wed, 17 Jul 2024 08:55:08 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Ix8n7IBY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1721206512;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=9XIaMaK/+4p8jvOTLyix4bq/F6dyf+Uu0qLhtnTgzJU=;\n\tb=Ix8n7IBY8Es4bceQ6VHv9C09YO3EOIX64e9d5hkFr1FEY1ONL9IoKbHH3874RxEMbVlFFQ\n\tU4JGBfd+ZsFwCZFFVTW7f933LSPTclxJNgoGX7OcZJWKwnbAMPn+xGCK8q0dTqUwWZAfZj\n\tmTFl/BhGEDxa22dtikIQmTMamjfZE78=", "X-MC-Unique": "bSJ5GmpIOESFkL3zoDqrzw-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v3 08/23] libcamera: software_isp: Define skeletons for IPA\n\trefactoring", "Date": "Wed, 17 Jul 2024 10:54:29 +0200", "Message-ID": "<20240717085444.289997-9-mzamazal@redhat.com>", "In-Reply-To": "<20240717085444.289997-1-mzamazal@redhat.com>", "References": "<20240717085444.289997-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Software ISP image processing algorithms are currently defined in a\nsimplified way, different from other libcamera pipelines. This is not\ngood for several reasons:\n\n- It makes the software ISP code harder to understand due to its\n different structuring.\n- Adding more algorithms may make the code harder to understand\n generally.\n- Mass libcamera code changes may not be easily applicable to software\n ISP.\n- Algorithm sharing with other pipelines is not easily possible.\n\nThis patch introduces basic software ISP IPA skeletons structured\nsimilarly to the other pipelines. The newly added files are currently\nnot used or compiled and the general skeleton structures don't contain\nanything particular. It is just a preparation step for a larger\nrefactoring and the code will be actually used and extended as needed in\nfollowup patches.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/ipa/simple/algorithms/algorithm.h | 22 +++++++++++\n src/ipa/simple/ipa_context.cpp | 53 +++++++++++++++++++++++++++\n src/ipa/simple/ipa_context.h | 34 +++++++++++++++++\n src/ipa/simple/meson.build | 1 +\n src/ipa/simple/module.h | 28 ++++++++++++++\n 5 files changed, 138 insertions(+)\n create mode 100644 src/ipa/simple/algorithms/algorithm.h\n create mode 100644 src/ipa/simple/ipa_context.cpp\n create mode 100644 src/ipa/simple/ipa_context.h\n create mode 100644 src/ipa/simple/module.h", "diff": "diff --git a/src/ipa/simple/algorithms/algorithm.h b/src/ipa/simple/algorithms/algorithm.h\nnew file mode 100644\nindex 00000000..41f63170\n--- /dev/null\n+++ b/src/ipa/simple/algorithms/algorithm.h\n@@ -0,0 +1,22 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024 Red Hat, Inc.\n+ *\n+ * Software ISP control algorithm interface\n+ */\n+\n+#pragma once\n+\n+#include <libipa/algorithm.h>\n+\n+#include \"module.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::soft {\n+\n+using Algorithm = libcamera::ipa::Algorithm<Module>;\n+\n+} /* namespace ipa::soft */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/simple/ipa_context.cpp b/src/ipa/simple/ipa_context.cpp\nnew file mode 100644\nindex 00000000..3c1c7262\n--- /dev/null\n+++ b/src/ipa/simple/ipa_context.cpp\n@@ -0,0 +1,53 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Google Inc.\n+ * Copyright (C) 2024 Red Hat Inc.\n+ *\n+ * Software ISP IPA Context\n+ */\n+\n+#include \"ipa_context.h\"\n+\n+/**\n+ * \\file ipa_context.h\n+ * \\brief Context and state information shared between the algorithms\n+ */\n+\n+namespace libcamera::ipa::soft {\n+\n+/**\n+ * \\struct IPASessionConfiguration\n+ * \\brief Session configuration for the IPA module\n+ *\n+ * The session configuration contains all IPA configuration parameters that\n+ * remain constant during the capture session, from IPA module start to stop.\n+ * It is typically set during the configure() operation of the IPA module, but\n+ * may also be updated in the start() operation.\n+ */\n+\n+/**\n+ * \\struct IPAActiveState\n+ * \\brief The active state of the IPA algorithms\n+ *\n+ * The IPA is fed with the statistics generated from the latest frame processed.\n+ * The statistics are then processed by the IPA algorithms to compute parameters\n+ * required for the next frame capture and processing. The current state of the\n+ * algorithms is reflected through the IPAActiveState to store the values most\n+ * recently computed by the IPA algorithms.\n+ */\n+\n+/**\n+ * \\struct IPAContext\n+ * \\brief Global IPA context data shared between all algorithms\n+ *\n+ * \\var IPAContext::configuration\n+ * \\brief The IPA session configuration, immutable during the session\n+ *\n+ * \\var IPAContext::frameContexts\n+ * \\brief Ring buffer of the IPAFrameContext(s)\n+ *\n+ * \\var IPAContext::activeState\n+ * \\brief The current state of IPA algorithms\n+ */\n+\n+} /* namespace libcamera::ipa::soft */\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nnew file mode 100644\nindex 00000000..bc1235b6\n--- /dev/null\n+++ b/src/ipa/simple/ipa_context.h\n@@ -0,0 +1,34 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024 Red Hat, Inc.\n+ *\n+ * Simple pipeline IPA Context\n+ *\n+ */\n+\n+#pragma once\n+\n+#include <libipa/fc_queue.h>\n+\n+namespace libcamera {\n+\n+namespace ipa::soft {\n+\n+struct IPASessionConfiguration {\n+};\n+\n+struct IPAActiveState {\n+};\n+\n+struct IPAFrameContext : public FrameContext {\n+};\n+\n+struct IPAContext {\n+\tIPASessionConfiguration configuration;\n+\tIPAActiveState activeState;\n+\tFCQueue<IPAFrameContext> frameContexts;\n+};\n+\n+} /* namespace ipa::soft */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\nindex 33d1c96a..363251fb 100644\n--- a/src/ipa/simple/meson.build\n+++ b/src/ipa/simple/meson.build\n@@ -3,6 +3,7 @@\n ipa_name = 'ipa_soft_simple'\n \n soft_simple_sources = files([\n+ 'ipa_context.cpp',\n 'soft_simple.cpp',\n 'black_level.cpp',\n ])\ndiff --git a/src/ipa/simple/module.h b/src/ipa/simple/module.h\nnew file mode 100644\nindex 00000000..33a7d1db\n--- /dev/null\n+++ b/src/ipa/simple/module.h\n@@ -0,0 +1,28 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024 Red Hat, Inc.\n+ *\n+ * Software ISP IPA Module\n+ */\n+\n+#pragma once\n+\n+#include <libcamera/controls.h>\n+\n+#include \"libcamera/internal/software_isp/debayer_params.h\"\n+#include \"libcamera/internal/software_isp/swisp_stats.h\"\n+\n+#include <libipa/module.h>\n+\n+#include \"ipa_context.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::soft {\n+\n+using Module = ipa::Module<IPAContext, IPAFrameContext, ControlInfoMap,\n+\t\t\t DebayerParams, SwIspStats>;\n+\n+} /* namespace ipa::soft */\n+\n+} /* namespace libcamera */\n", "prefixes": [ "v3", "08/23" ] }