Patch Detail
Show a patch.
GET /api/patches/20659/?format=api
{ "id": 20659, "url": "https://patchwork.libcamera.org/api/patches/20659/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20659/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240712143227.3036702-5-stefan.klug@ideasonboard.com>", "date": "2024-07-12T14:32:05", "name": "[v1,4/5] ipa: rkisp1: ccm: Fix ccm metadata output", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cb0f9be60218adc57c0d71581887b8bc02bb84e2", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20659/mbox/", "series": [ { "id": 4452, "url": "https://patchwork.libcamera.org/api/series/4452/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4452", "date": "2024-07-12T14:32:01", "name": "A few fixes for the rkisp1 ipa", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4452/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20659/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20659/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CBB26BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Jul 2024 14:32:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7ABA163373;\n\tFri, 12 Jul 2024 16:32:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1487663372\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Jul 2024 16:32:50 +0200 (CEST)", "from ideasonboard.com (unknown [94.31.101.36])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A3707E3;\n\tFri, 12 Jul 2024 16:32:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jqoQNQge\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720794735;\n\tbh=OEQXcnvfJAWBJFeZ9U8XQW/mbkS+E3NsjUOxJ3so064=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jqoQNQgeJQulGjJ4THplGyYtjXoDWOf4Bjy0Vs7vcCoU4qsB4Oe5LYzYaRLySEINZ\n\tbLQ5HLwFnQHyQqUrmgtZuSI3+rty/TgK5xhq9D8B2Du9kkLGQioW7EKaaNcxxKxqdU\n\tGneZgKbFzVFkTQVY/3xrtkGYF2EDdoNh8uUv6yGA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 4/5] ipa: rkisp1: ccm: Fix ccm metadata output", "Date": "Fri, 12 Jul 2024 16:32:05 +0200", "Message-ID": "<20240712143227.3036702-5-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240712143227.3036702-1-stefan.klug@ideasonboard.com>", "References": "<20240712143227.3036702-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Only the first three entries of the matrix were set. Fix that.\n\nFixes: cbfdfa42cacc (\"ipa: rkisp1: algorithms: Add crosstalk algorithm\")\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/ccm.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\nindex c1f5403a8ab2..4c4e3f5029a4 100644\n--- a/src/ipa/rkisp1/algorithms/ccm.cpp\n+++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n@@ -135,7 +135,7 @@ void Ccm::process([[maybe_unused]] IPAContext &context,\n \tfloat m[9];\n \tfor (unsigned int i = 0; i < 3; i++) {\n \t\tfor (unsigned int j = 0; j < 3; j++)\n-\t\t\tm[i] = frameContext.ccm.ccm[i][j];\n+\t\t\tm[i * 3 + j] = frameContext.ccm.ccm[i][j];\n \t}\n \tmetadata.set(controls::ColourCorrectionMatrix, m);\n }\n", "prefixes": [ "v1", "4/5" ] }