Patch Detail
Show a patch.
GET /api/patches/20657/?format=api
{ "id": 20657, "url": "https://patchwork.libcamera.org/api/patches/20657/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20657/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240712143227.3036702-3-stefan.klug@ideasonboard.com>", "date": "2024-07-12T14:32:03", "name": "[v1,2/5] ipa rkisp1: Remove temperatureK from FrameContext", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d00e50c63e0c21b0a80fc74808e61b85c962f346", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20657/mbox/", "series": [ { "id": 4452, "url": "https://patchwork.libcamera.org/api/series/4452/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4452", "date": "2024-07-12T14:32:01", "name": "A few fixes for the rkisp1 ipa", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4452/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20657/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20657/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B347BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Jul 2024 14:32:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F404D63374;\n\tFri, 12 Jul 2024 16:32:47 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7738563369\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Jul 2024 16:32:44 +0200 (CEST)", "from ideasonboard.com (unknown [94.31.101.36])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 05B69735;\n\tFri, 12 Jul 2024 16:32:09 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fQaZENxM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720794730;\n\tbh=D8QQ2O6bD21mRk+8P5ndPfrEC3oD0xcu/FW4WljJd/Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fQaZENxMSTWdUuNP0H2LDR/FafXOybQiKc4Kfb0QqtXu6xJgPNCNHK//MKu0EIUbI\n\t9Sn9xHjKUcfD9fiWWVNruVAJZxZOOjtdx3TULf5ljFDkxX4A1PWTqGvuFB98xMUqoe\n\tUxexq9thlfUYIsURQ/y2oXNzByKYMFbFtYfdDoc4=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 2/5] ipa rkisp1: Remove temperatureK from FrameContext", "Date": "Fri, 12 Jul 2024 16:32:03 +0200", "Message-ID": "<20240712143227.3036702-3-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240712143227.3036702-1-stefan.klug@ideasonboard.com>", "References": "<20240712143227.3036702-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The frame context is used to store data used for processing that frame.\nIt is later used to either act as input for other algorithms or to fill\nthe metadata. For the colour temperature this is not needed, as the\nmeatadata shall not contain the value that was active when the image was\nprocessed, but the value that was calculated based on the statistics for\nthat image. This is no functional change.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 7 ++-----\n src/ipa/rkisp1/ipa_context.h | 1 -\n 2 files changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 1a5d4776970a..18f750207793 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -277,7 +277,6 @@ void Awb::process(IPAContext &context,\n \t */\n \tif (redMean < kMeanMinThreshold && greenMean < kMeanMinThreshold &&\n \t blueMean < kMeanMinThreshold) {\n-\t\tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n \t\treturn;\n \t}\n \n@@ -309,21 +308,19 @@ void Awb::process(IPAContext &context,\n \tactiveState.awb.gains.automatic.blue = blueGain;\n \tactiveState.awb.gains.automatic.green = 1.0;\n \n-\tframeContext.awb.temperatureK = activeState.awb.temperatureK;\n-\n \tmetadata.set(controls::AwbEnable, frameContext.awb.autoEnabled);\n \tmetadata.set(controls::ColourGains, {\n \t\t\tstatic_cast<float>(frameContext.awb.gains.red),\n \t\t\tstatic_cast<float>(frameContext.awb.gains.blue)\n \t\t});\n-\tmetadata.set(controls::ColourTemperature, frameContext.awb.temperatureK);\n+\tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n \n \tLOG(RkISP1Awb, Debug) << std::showpoint\n \t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n \t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n \t\t<< activeState.awb.gains.automatic.green << \", \"\n \t\t<< activeState.awb.gains.automatic.blue << \"], temp \"\n-\t\t<< frameContext.awb.temperatureK << \"K\";\n+\t\t<< activeState.awb.temperatureK << \"K\";\n }\n \n REGISTER_IPA_ALGORITHM(Awb, \"Awb\")\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 1d0e9030af1c..27a9bf62fc16 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -136,7 +136,6 @@ struct IPAFrameContext : public FrameContext {\n \t\t\tdouble blue;\n \t\t} gains;\n \n-\t\tunsigned int temperatureK;\n \t\tbool autoEnabled;\n \t} awb;\n \n", "prefixes": [ "v1", "2/5" ] }