Patch Detail
Show a patch.
GET /api/patches/20602/?format=api
{ "id": 20602, "url": "https://patchwork.libcamera.org/api/patches/20602/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20602/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240705144209.418906-14-stefan.klug@ideasonboard.com>", "date": "2024-07-05T14:41:49", "name": "[v4,13/23] libtuning: lsc: rkisp1: Clip lsc values to valid range", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0c95a2630be234ac6e2ad1a54de5a9b969a7f776", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20602/mbox/", "series": [ { "id": 4446, "url": "https://patchwork.libcamera.org/api/series/4446/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4446", "date": "2024-07-05T14:41:36", "name": "Add ccm calibration to libtuning", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4446/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20602/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20602/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D1EABD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 5 Jul 2024 14:42:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D1C8E63364;\n\tFri, 5 Jul 2024 16:42:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C99C8619C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Jul 2024 16:42:46 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:60b6:33a3:3a20:6030])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 460B14CC;\n\tFri, 5 Jul 2024 16:42:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GE0Fh8pm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720190537;\n\tbh=Lqps5PNgzZjmssYMSgkwyfCdZM98oQqydc1lEWJH7O8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GE0Fh8pmWyeY5DgrR4cAANJuET3THmccVm+if0tV0CBa9LIEY7AnK+Btvr5FSy4/o\n\tcCf/sRR3dyKZoIzop55UrdfMPa3+tNmUBqmJeacDHTH9NE+NNkvmg/J63CgmRaeZHb\n\tzGDRkLz6ZjVekCwCe6wdldrAjCm5gwCWt7Qs0tq8=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v4 13/23] libtuning: lsc: rkisp1: Clip lsc values to valid\n\trange", "Date": "Fri, 5 Jul 2024 16:41:49 +0200", "Message-ID": "<20240705144209.418906-14-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240705144209.418906-1-stefan.klug@ideasonboard.com>", "References": "<20240705144209.418906-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Based on the input images, the lsc values could exceed the range allowed\nby the rkisp1. As we are now clipping the values, we can simplify the\nvalue mapping.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py\nindex 20406e436a6a..57004104fc7a 100644\n--- a/utils/tuning/libtuning/modules/lsc/rkisp1.py\n+++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py\n@@ -80,7 +80,8 @@ class LSCRkISP1(LSC):\n tables = []\n for lis in [list_cr, list_cgr, list_cgb, list_cb]:\n table = np.mean(lis[indices], axis=0)\n- table = output_map_func((1, 3.999), (1024, 4095), table)\n+ table = output_map_func((1, 4), (1024, 4096), table)\n+ table = np.clip(table, 1024, 4095)\n table = np.round(table).astype('int32').tolist()\n tables.append(table)\n \n", "prefixes": [ "v4", "13/23" ] }