Patch Detail
Show a patch.
GET /api/patches/20555/?format=api
{ "id": 20555, "url": "https://patchwork.libcamera.org/api/patches/20555/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20555/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240703175119.1872585-14-mzamazal@redhat.com>", "date": "2024-07-03T17:51:13", "name": "[v2,13/19] libcamera: software_isp: Call Algorithm::process", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bcbd0718763595f3e2fceb6e7a249c6db13ddd50", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20555/mbox/", "series": [ { "id": 4440, "url": "https://patchwork.libcamera.org/api/series/4440/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4440", "date": "2024-07-03T17:51:00", "name": "Software ISP refactoring", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4440/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20555/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20555/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 023FCBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 Jul 2024 17:52:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47FC963365;\n\tWed, 3 Jul 2024 19:52:10 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2487C6336B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Jul 2024 19:51:56 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-439-NIZAYf5nMGi36S5_rGtjhQ-1;\n\tWed, 03 Jul 2024 13:51:52 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id ABA0E1955BC2; Wed, 3 Jul 2024 17:51:51 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.13])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id F3ECD1954B0D; Wed, 3 Jul 2024 17:51:49 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"egaD99xy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1720029115;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=KmDUksM2FS5LDTE735TKANJ9WsmBJoUm/opuUSeLPhc=;\n\tb=egaD99xykaEGa7VFC6IdfRAMe0ST7KMp/2j/HRFKyaGF3FmnjiYhFRBh3p7Gpp3rd7ad5U\n\tpNaWlIfyWnxGlj7DFyARL+w3xj5SjOVHA/ifY59u7EGj4fddJD70lqPCbsZfFvlVdWnpka\n\tMfDiE070OTIUIPIZPtCyIKnGwNdX/60=", "X-MC-Unique": "NIZAYf5nMGi36S5_rGtjhQ-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v2 13/19] libcamera: software_isp: Call Algorithm::process", "Date": "Wed, 3 Jul 2024 19:51:13 +0200", "Message-ID": "<20240703175119.1872585-14-mzamazal@redhat.com>", "In-Reply-To": "<20240703175119.1872585-1-mzamazal@redhat.com>", "References": "<20240703175119.1872585-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch adds Algorithm::process call for the defined algorithms.\nThis is preparation only since there are currently no Algorithm based\nalgorithms defined.\n\nAs software ISP currently doesn't produce any metadata, a dummy and\nunused metadata instance is created to satisfy Algorithm::process API.\nThis should be changed in future.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/soft_simple.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex f4a6bdf4..a8499f29 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -287,10 +287,21 @@ void IPASoftSimple::prepare(const uint32_t frame)\n }\n \n void IPASoftSimple::processStats(\n-\t[[maybe_unused]] const uint32_t frame,\n+\tconst uint32_t frame,\n \t[[maybe_unused]] const uint32_t bufferId,\n \tconst ControlList &sensorControls)\n {\n+\tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n+\t/*\n+\t * Software ISP currently does not produce any metadata. Use an empty\n+\t * ControlList for now.\n+\t *\n+\t * \\todo Implement proper metadata handling\n+\t */\n+\tControlList metadata(controls::controls);\n+\tfor (auto const &algo : algorithms())\n+\t\talgo->process(context_, frame, frameContext, stats_, metadata);\n+\n \tSwIspStats::Histogram histogram = stats_->yHistogram;\n \tif (ignoreUpdates_ > 0)\n \t\tblackLevel_.update(histogram);\n", "prefixes": [ "v2", "13/19" ] }