Patch Detail
Show a patch.
GET /api/patches/20540/?format=api
{ "id": 20540, "url": "https://patchwork.libcamera.org/api/patches/20540/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20540/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240703173120.9995-1-laurent.pinchart@ideasonboard.com>", "date": "2024-07-03T17:31:20", "name": "ipa: rkisp1: blc: Drop [[maybe_unused]] attribute", "commit_ref": "050e0d33d1f24be7a788cf71cc3cccd1f51b6d4e", "pull_url": null, "state": "accepted", "archived": false, "hash": "318bd0669232b7d0ee2a04889525f122e02db20f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20540/mbox/", "series": [ { "id": 4439, "url": "https://patchwork.libcamera.org/api/series/4439/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4439", "date": "2024-07-03T17:31:20", "name": "ipa: rkisp1: blc: Drop [[maybe_unused]] attribute", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4439/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20540/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20540/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C5CFBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 Jul 2024 17:31:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB88062E25;\n\tWed, 3 Jul 2024 19:31:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5894762C95\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Jul 2024 19:31:42 +0200 (CEST)", "from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 014123E6;\n\tWed, 3 Jul 2024 19:31:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gDDHoTI3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720027874;\n\tbh=nRSc0xcANvdAH4gY+ZIlqWWfHxwSuDMHj1rIZJAn2tw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=gDDHoTI3YYgTACL7Iip3DrxJ6uk2QB/Pk+JmgBza1pRU6mnSuxA56arIIsVVyheF7\n\t4wR3ByUNO1ktjgjDUaSnzdG7sMOKuSS3xqZBLrh9h4z0CMOmIHolNQgXogWZCb//I3\n\tv9Q/oGUValzHNbhJRG2MyZ3AGqpgimObRTg9Qnns=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH] ipa: rkisp1: blc: Drop [[maybe_unused]] attribute", "Date": "Wed, 3 Jul 2024 20:31:20 +0300", "Message-ID": "<20240703173120.9995-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The context parameter of the BlackLevelCorrection::init() function is\nused. Drop the [[maybe_unused]] attribute.\n\nFixes: 50c28e135100 (\"ipa: rkisp1: blc: Query black levels from camera sensor helper\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nI'm starting to wonder if we should omit parameter names for parameters\nthat are never used, and use [[maybe_unused]] for parameters that are\nconditionally unused, as recommended by\nhttps://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-unused.\n---\n src/ipa/rkisp1/algorithms/blc.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\n\nbase-commit: 196abb8d1d6e0fe9d190315e72a85eb12d16a554", "diff": "diff --git a/src/ipa/rkisp1/algorithms/blc.cpp b/src/ipa/rkisp1/algorithms/blc.cpp\nindex 4b00034cc434..464a0e066dd4 100644\n--- a/src/ipa/rkisp1/algorithms/blc.cpp\n+++ b/src/ipa/rkisp1/algorithms/blc.cpp\n@@ -52,8 +52,7 @@ BlackLevelCorrection::BlackLevelCorrection()\n /**\n * \\copydoc libcamera::ipa::Algorithm::init\n */\n-int BlackLevelCorrection::init([[maybe_unused]] IPAContext &context,\n-\t\t\t const YamlObject &tuningData)\n+int BlackLevelCorrection::init(IPAContext &context, const YamlObject &tuningData)\n {\n \tstd::optional<int16_t> levelRed = tuningData[\"R\"].get<int16_t>();\n \tstd::optional<int16_t> levelGreenR = tuningData[\"Gr\"].get<int16_t>();\n", "prefixes": [] }