Patch Detail
Show a patch.
GET /api/patches/20534/?format=api
{ "id": 20534, "url": "https://patchwork.libcamera.org/api/patches/20534/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20534/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240703141726.252368-21-stefan.klug@ideasonboard.com>", "date": "2024-07-03T14:17:09", "name": "[v3,20/23] tuning: rkisp1: Add some static modules", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "73ae75baca05d48871e36cb5f8ffe72b685581a3", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20534/mbox/", "series": [ { "id": 4437, "url": "https://patchwork.libcamera.org/api/series/4437/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4437", "date": "2024-07-03T14:16:49", "name": "Add ccm calibration to libtuning", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4437/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20534/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20534/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CC18BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 Jul 2024 14:18:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C184463370;\n\tWed, 3 Jul 2024 16:18:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB18163377\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Jul 2024 16:18:31 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:9263:c199:9587:576])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9A5F4CA;\n\tWed, 3 Jul 2024 16:18:03 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rXzZTssX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720016283;\n\tbh=99m8MFKipaRARjY+1DjYk51S4MxdGkm5FF0JBXdMeqQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rXzZTssXZazNrgzaAaZifGp0z57m8Zu+cE4B8DWF7LNE3rdhZpwZ8JEGe+yUE+09Y\n\tcA8LziOHuKQ41qvAC+1QRinHABl2LsZImcTA80ES7nF6Qvmjwp7IDIY1Vsc2Ohqz/2\n\t+0d/u0J5Hb1isjyNE8Z0CbfdO8i+hqk9lphAsPTA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v3 20/23] tuning: rkisp1: Add some static modules", "Date": "Wed, 3 Jul 2024 16:17:09 +0200", "Message-ID": "<20240703141726.252368-21-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240703141726.252368-1-stefan.klug@ideasonboard.com>", "References": "<20240703141726.252368-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add awb, blc, cproc, filter, and gamma by default to the tuning file. These\ndon't need any configuration.\n\nWhile at it, sort the modules alphabetically.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/tuning/rkisp1.py | 21 +++++++++++++++++----\n 1 file changed, 17 insertions(+), 4 deletions(-)", "diff": "diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\nindex fae35783c656..0d279a39ab1b 100755\n--- a/utils/tuning/rkisp1.py\n+++ b/utils/tuning/rkisp1.py\n@@ -15,11 +15,24 @@ from libtuning.generators import YamlOutput\n from libtuning.modules.lsc import LSCRkISP1\n from libtuning.modules.agc import AGCRkISP1\n from libtuning.modules.ccm import CCMRkISP1\n-\n+from libtuning.modules.static import StaticModule\n \n coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n \n+awb = StaticModule('Awb')\n+blc = StaticModule('BlackLevelCorrection')\n+color_processing = StaticModule('ColorProcessing')\n+filter = StaticModule('Filter')\n+gamma_out = StaticModule('GammaOutCorrection', {'gamma': 2.2})\n+\n tuner = lt.Tuner('RkISP1')\n+tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n+tuner.add(awb)\n+tuner.add(blc)\n+tuner.add(CCMRkISP1(debug=[lt.Debug.Plot]))\n+tuner.add(color_processing)\n+tuner.add(filter)\n+tuner.add(gamma_out)\n tuner.add(LSCRkISP1(\n debug=[lt.Debug.Plot],\n # This is for the actual LSC tuning, and is part of the base LSC\n@@ -39,11 +52,11 @@ tuner.add(LSCRkISP1(\n # values. This can also be a custom function.\n smoothing_function=lt.smoothing.MedianBlur(3),\n ))\n-tuner.add(AGCRkISP1(debug=[lt.Debug.Plot]))\n-tuner.add(CCMRkISP1(debug=[lt.Debug.Plot]))\n+\n tuner.set_input_parser(YamlParser())\n tuner.set_output_formatter(YamlOutput())\n-tuner.set_output_order([AGCRkISP1, CCMRkISP1, LSCRkISP1])\n+tuner.set_output_order([AGCRkISP1, awb, blc, CCMRkISP1, color_processing,\n+ filter, gamma_out, LSCRkISP1])\n \n if __name__ == '__main__':\n sys.exit(tuner.run(sys.argv))\n", "prefixes": [ "v3", "20/23" ] }