Patch Detail
Show a patch.
GET /api/patches/20512/?format=api
{ "id": 20512, "url": "https://patchwork.libcamera.org/api/patches/20512/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20512/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240703135000.242227-6-stefan.klug@ideasonboard.com>", "date": "2024-07-03T13:49:53", "name": "[v3,5/6] ipa: rkisp1: data: Update tuning files for imx219 and imx258", "commit_ref": "27e4d3fc3a4dc3e6ddaef17d6e7c8f5e56c79507", "pull_url": null, "state": "accepted", "archived": false, "hash": "0d3f800e69af36b80b9503035174e4d592d9b6ea", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20512/mbox/", "series": [ { "id": 4436, "url": "https://patchwork.libcamera.org/api/series/4436/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4436", "date": "2024-07-03T13:49:48", "name": "ipa: Add black level to camera sensor helpers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4436/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20512/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20512/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F158BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 3 Jul 2024 13:50:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E100632EA;\n\tWed, 3 Jul 2024 15:50:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6934562E27\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 3 Jul 2024 15:50:20 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:9263:c199:9587:576])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F5146D6;\n\tWed, 3 Jul 2024 15:49:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wAY5EJCf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720014592;\n\tbh=IQ3s1rqGzGWvS5f5TZ5PlU7yx5z5cuqCRYfPcfMk2Wg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wAY5EJCfZlgefMq0qJrlep5/aPZsXjCvRkA8XT/aVngvWDxhZj9UsW62wk+iCOhS3\n\tsLI4XkQSLajksOCp8Ylk+R1z5Ga/v57/Y8DizlZmx7qdbBEKe6citrd5EOjRNvPy1g\n\tosk/kbxVeNCepd8zkC+TlpozsG7IFq6/f7zmW4SU=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 5/6] ipa: rkisp1: data: Update tuning files for imx219 and\n\timx258", "Date": "Wed, 3 Jul 2024 15:49:53 +0200", "Message-ID": "<20240703135000.242227-6-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240703135000.242227-1-stefan.klug@ideasonboard.com>", "References": "<20240703135000.242227-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The black levels for imx219 and imx258 are now contained in the camera\nsensor helpers. Remove them from the tuning file for the imx219. Add a\nBLC entry to the imx258 tuning file.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/data/imx219.yaml | 4 ----\n src/ipa/rkisp1/data/imx258.yaml | 1 +\n 2 files changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\nindex cbcc43b84ac7..0d99cb529392 100644\n--- a/src/ipa/rkisp1/data/imx219.yaml\n+++ b/src/ipa/rkisp1/data/imx219.yaml\n@@ -6,10 +6,6 @@ algorithms:\n - Agc:\n - Awb:\n - BlackLevelCorrection:\n- R: 256\n- Gr: 256\n- Gb: 256\n- B: 256\n - LensShadingCorrection:\n x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\ndiff --git a/src/ipa/rkisp1/data/imx258.yaml b/src/ipa/rkisp1/data/imx258.yaml\nindex 43dddf20dcd2..202af36afbee 100644\n--- a/src/ipa/rkisp1/data/imx258.yaml\n+++ b/src/ipa/rkisp1/data/imx258.yaml\n@@ -5,6 +5,7 @@ version: 1\n algorithms:\n - Agc:\n - Awb:\n+ - BlackLevelCorrection:\n - LensShadingCorrection:\n x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n", "prefixes": [ "v3", "5/6" ] }