Patch Detail
Show a patch.
GET /api/patches/20498/?format=api
{ "id": 20498, "url": "https://patchwork.libcamera.org/api/patches/20498/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20498/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240701144122.3418955-6-stefan.klug@ideasonboard.com>", "date": "2024-07-01T14:38:28", "name": "[5/5] ipa: rkisp1: data: Update tuning files for imx219 and imx258", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0d3f800e69af36b80b9503035174e4d592d9b6ea", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20498/mbox/", "series": [ { "id": 4433, "url": "https://patchwork.libcamera.org/api/series/4433/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4433", "date": "2024-07-01T14:38:23", "name": "ipa: Add black level to camera sensor helpers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4433/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20498/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20498/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B7A3FBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 1 Jul 2024 14:41:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C3B763331;\n\tMon, 1 Jul 2024 16:41:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D136763331\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 1 Jul 2024 16:41:50 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:89b2:f6c7:b29b:4e5c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E8DA289;\n\tMon, 1 Jul 2024 16:41:24 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pm7Asl7y\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719844884;\n\tbh=tVxWJR2M1MtcigGANG+asBgk/dc7ObEaVvEtWPIvD+Q=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pm7Asl7ytUbyzyWHoWbpFc+5I3ZLanEeOAma3YUOzV4+xboxQslSfVZbcg6CvPJ5e\n\t8uH/JIdUOHKDHJzgFUgp50mlywxXSUxC6aGj1i24P/4VxfW10uVjpYzbF9noPlzsZC\n\tJ1xfLVrjaZevkLZl9KAiqIAsCZcrd5VUnf5+aOOc=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 5/5] ipa: rkisp1: data: Update tuning files for imx219 and\n\timx258", "Date": "Mon, 1 Jul 2024 16:38:28 +0200", "Message-ID": "<20240701144122.3418955-6-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240701144122.3418955-1-stefan.klug@ideasonboard.com>", "References": "<20240701144122.3418955-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For imx219 the black level was incorrectly set to 256. According to the\ndatasheet it is 64d for raw 10. Mapped to 16bit, this becomes 4096.\n\nFor the imx258, BLC was not included at all. As only LSC data with\nrather low maximum values, the image quality is expected to only get\nbetter by adding black level correction.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/data/imx219.yaml | 4 ----\n src/ipa/rkisp1/data/imx258.yaml | 1 +\n 2 files changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\nindex cbcc43b84ac7..0d99cb529392 100644\n--- a/src/ipa/rkisp1/data/imx219.yaml\n+++ b/src/ipa/rkisp1/data/imx219.yaml\n@@ -6,10 +6,6 @@ algorithms:\n - Agc:\n - Awb:\n - BlackLevelCorrection:\n- R: 256\n- Gr: 256\n- Gb: 256\n- B: 256\n - LensShadingCorrection:\n x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\ndiff --git a/src/ipa/rkisp1/data/imx258.yaml b/src/ipa/rkisp1/data/imx258.yaml\nindex 43dddf20dcd2..202af36afbee 100644\n--- a/src/ipa/rkisp1/data/imx258.yaml\n+++ b/src/ipa/rkisp1/data/imx258.yaml\n@@ -5,6 +5,7 @@ version: 1\n algorithms:\n - Agc:\n - Awb:\n+ - BlackLevelCorrection:\n - LensShadingCorrection:\n x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]\n", "prefixes": [ "5/5" ] }