Patch Detail
Show a patch.
GET /api/patches/20484/?format=api
{ "id": 20484, "url": "https://patchwork.libcamera.org/api/patches/20484/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20484/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240628104828.2928109-26-stefan.klug@ideasonboard.com>", "date": "2024-06-28T10:47:18", "name": "[v2,25/25] libtuning: agc: rkisp1: Increase y-target", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "394b0d5b1f8a7c4879e8c6dc4763fa7a6b103dc9", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20484/mbox/", "series": [ { "id": 4430, "url": "https://patchwork.libcamera.org/api/series/4430/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4430", "date": "2024-06-28T10:46:53", "name": "Add ccm calibration to libtuning", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4430/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20484/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20484/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F35DBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jun 2024 10:49:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29F146336E;\n\tFri, 28 Jun 2024 12:49:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 066FE63365\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 12:49:50 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FDC3BEB;\n\tFri, 28 Jun 2024 12:49:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wKAbtHv+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719571765;\n\tbh=/mEhw53xaUZgU5RvglHiiroVfIaTcTkNUVEGPnwrgJ8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wKAbtHv+72PGNfHpJU4qj+918d/XfuhNR74JgWwgcAC9lDsR1cyGZK387DLS/azlB\n\t4GrV+IfSV7t/YEn9i8h8E8hejilxwja95FQ2c4E+K4QeM0X2LqjaiJ7/ul29UPjyRh\n\tuhCZDupC9LMhPgWtLr8y2BKst9dvmVNBHtKroR/o=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 25/25] libtuning: agc: rkisp1: Increase y-target", "Date": "Fri, 28 Jun 2024 12:47:18 +0200", "Message-ID": "<20240628104828.2928109-26-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "References": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the addition of gamma out correction the relative luminance target\nwas set too low. As brightness is a bit subjective it is difficult to\ncome up with the \"correct\" value. With 0.5 the patch 22 on the mac beth\nchart (neutral grey, 18% reflectance) ended up a bit below 50% grey,\nwhich seems reasonable.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/tuning/libtuning/modules/agc/rkisp1.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py\nindex 19a5555b6111..7147028a774a 100644\n--- a/utils/tuning/libtuning/modules/agc/rkisp1.py\n+++ b/utils/tuning/libtuning/modules/agc/rkisp1.py\n@@ -64,7 +64,7 @@ class AGCRkISP1(AGC):\n return {'ConstraintNormal': normal, 'ConstraintHighlight': highlight}\n \n def _generate_y_target(self) -> list:\n- return 0.16\n+ return 0.5\n \n def process(self, config: dict, images: list, outputs: dict) -> dict:\n output = {}\n", "prefixes": [ "v2", "25/25" ] }