Patch Detail
Show a patch.
GET /api/patches/20481/?format=api
{ "id": 20481, "url": "https://patchwork.libcamera.org/api/patches/20481/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20481/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240628104828.2928109-23-stefan.klug@ideasonboard.com>", "date": "2024-06-28T10:47:15", "name": "[v2,22/25] libtuning: lsc: Prevent negative values", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2d7700d08cb11b0b8ebc94cd9cab6892ba32b6f4", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20481/mbox/", "series": [ { "id": 4430, "url": "https://patchwork.libcamera.org/api/series/4430/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4430", "date": "2024-06-28T10:46:53", "name": "Add ccm calibration to libtuning", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4430/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20481/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20481/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BE70BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jun 2024 10:49:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D52F763365;\n\tFri, 28 Jun 2024 12:49:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F78763367\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 12:49:41 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DB514735;\n\tFri, 28 Jun 2024 12:49:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gk7NuZYP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719571757;\n\tbh=Mt+3TIlq0NvUg1O/HnwIWP9cQdymWm142pP9Nl64usU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Gk7NuZYPExqdhCyH3EotF06JlXDvE4jzOsHevgaRxSFvk3hO1ixA63vbKgkhN0Lij\n\t/k4//IosW2EJXFgpTcTtAqp7M196Ct8Ib4PYRuG5KjmUDcycOWA8dYhlEXXGxP/jLP\n\t9wM6Meps+zCLongdSuqyBLLblpa+MnIRvLT3hh/I=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 22/25] libtuning: lsc: Prevent negative values", "Date": "Fri, 28 Jun 2024 12:47:15 +0200", "Message-ID": "<20240628104828.2928109-23-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "References": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In cases where the calibration image contains super dark areas, or when\nan invalid blacklevel was supplied, the grid might get close to zero or\nnegative. This would have bad effects on the 1/grid later. So clamp the\nvalues to a small positive number.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/tuning/libtuning/modules/lsc/lsc.py | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/utils/tuning/libtuning/modules/lsc/lsc.py b/utils/tuning/libtuning/modules/lsc/lsc.py\nindex 344a07a3d443..b6a24cf42874 100644\n--- a/utils/tuning/libtuning/modules/lsc/lsc.py\n+++ b/utils/tuning/libtuning/modules/lsc/lsc.py\n@@ -59,7 +59,8 @@ class LSC(Module):\n def _lsc_single_channel(self, channel: np.array,\n image: lt.Image, green_grid: np.array = None):\n grid = self._get_grid(channel, image.w, image.h)\n- grid -= image.blacklevel_16\n+ grid = np.maximum(grid - image.blacklevel_16, 0.1)\n+\n if green_grid is None:\n table = np.reshape(1 / grid, self.sector_shape[::-1])\n else:\n", "prefixes": [ "v2", "22/25" ] }