Patch Detail
Show a patch.
GET /api/patches/20476/?format=api
{ "id": 20476, "url": "https://patchwork.libcamera.org/api/patches/20476/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20476/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240628104828.2928109-18-stefan.klug@ideasonboard.com>", "date": "2024-06-28T10:47:10", "name": "[v2,17/25] libtuning: Only warn if processing returns None", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "737b06f3ccbce5a6e835d331b7127548c10095ca", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20476/mbox/", "series": [ { "id": 4430, "url": "https://patchwork.libcamera.org/api/series/4430/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4430", "date": "2024-06-28T10:46:53", "name": "Add ccm calibration to libtuning", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4430/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20476/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20476/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4680ABD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jun 2024 10:49:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC92D6335E;\n\tFri, 28 Jun 2024 12:49:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8AD43632EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 12:49:27 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07893BEB;\n\tFri, 28 Jun 2024 12:49:02 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MW5+CzlP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719571743;\n\tbh=6bjG7LEbOOfvAQ0tWSTwPCyaexrI600qYVgZiwLqRbQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MW5+CzlPKW7h0M1c38Xau6evnRV5ScwrKY9CJV6TczsTfqxImu20Q5b8SO8XKkbwc\n\t/Kabgmb1TuAriiYx11m0aiV0xyKQ+NrSslWbpNvgIOM3G9KTSE6BTlRNHIGN1gLnl8\n\tsxgmDLdODEASgp+NBKzMtraoQLVsrdVlG6UN/yJE=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 17/25] libtuning: Only warn if processing returns None", "Date": "Fri, 28 Jun 2024 12:47:10 +0200", "Message-ID": "<20240628104828.2928109-18-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "References": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There are valid cases where a module returns None. E.g no images were\nprovided for lsc calibration. We should however define proper semantics\nthere. Continue with a warning for now.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n utils/tuning/libtuning/generators/yaml_output.py | 3 +++\n utils/tuning/libtuning/libtuning.py | 4 ++--\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/tuning/libtuning/generators/yaml_output.py b/utils/tuning/libtuning/generators/yaml_output.py\nindex 31e265df4ea7..c490081d7de7 100644\n--- a/utils/tuning/libtuning/generators/yaml_output.py\n+++ b/utils/tuning/libtuning/generators/yaml_output.py\n@@ -107,6 +107,9 @@ class YamlOutput(Generator):\n ]\n \n for module in output_order:\n+ if module not in output_dict:\n+ continue\n+\n out_lines.append(f' - {module.out_name}:')\n \n if len(output_dict[module]) == 0:\ndiff --git a/utils/tuning/libtuning/libtuning.py b/utils/tuning/libtuning/libtuning.py\nindex 5342e5d6daaa..e7c63535fefd 100644\n--- a/utils/tuning/libtuning/libtuning.py\n+++ b/utils/tuning/libtuning/libtuning.py\n@@ -200,8 +200,8 @@ class Tuner(object):\n for module in self.modules:\n out = module.process(self.config, images, self.output)\n if out is None:\n- logger.error(f'Module {module.hr_name} failed to process...')\n- break\n+ logger.warning(f'Module {module.hr_name} failed to process...')\n+ continue\n self.output[module] = out\n \n self.generator.write(args.output, self.output, self.output_order)\n", "prefixes": [ "v2", "17/25" ] }