Patch Detail
Show a patch.
GET /api/patches/20467/?format=api
{ "id": 20467, "url": "https://patchwork.libcamera.org/api/patches/20467/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20467/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240628104828.2928109-9-stefan.klug@ideasonboard.com>", "date": "2024-06-28T10:47:01", "name": "[v2,08/25] libtuning: Fix visualize_macbeth_chart()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "276e8cf42f1d75f78b6e3d9ce5a6fc028a02d2ce", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20467/mbox/", "series": [ { "id": 4430, "url": "https://patchwork.libcamera.org/api/series/4430/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4430", "date": "2024-06-28T10:46:53", "name": "Add ccm calibration to libtuning", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4430/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20467/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20467/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04465BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jun 2024 10:49:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0B8462E1F;\n\tFri, 28 Jun 2024 12:49:04 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE72162CA0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 12:49:02 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33619BEB;\n\tFri, 28 Jun 2024 12:48:38 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KScyQF5V\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719571718;\n\tbh=QyPUM1BVkguvQnhuDsl4Z9U69vNSNHJYHqF/8sIxgnY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KScyQF5VMVOLZg/czkrc6DkJub7MGg61aKmYCs7e3v3JXj/W7nZsoqsIu93zGh2zu\n\tpM72E/bYlQme441B79IZYUDO4s5xb/gTKSnJONUt044kl/sgFmOk32/LsoDPNo6FJI\n\t20oiECukEZ/M07QZMwQl1GRaMWU6y00JikJAObFk=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v2 08/25] libtuning: Fix visualize_macbeth_chart()", "Date": "Fri, 28 Jun 2024 12:47:01 +0200", "Message-ID": "<20240628104828.2928109-9-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "References": "<20240628104828.2928109-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The old function uses PIL to save the image, which is not in the\nrequirements file. As we are already requiring opencv, use that to save\nimages instead of an additional dependency\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n utils/tuning/libtuning/utils.py | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/tuning/libtuning/utils.py b/utils/tuning/libtuning/utils.py\nindex 872341407b7b..178c6957c581 100644\n--- a/utils/tuning/libtuning/utils.py\n+++ b/utils/tuning/libtuning/utils.py\n@@ -7,6 +7,7 @@\n \n import decimal\n import math\n+import cv2\n import numpy as np\n import os\n from pathlib import Path\n@@ -162,6 +163,6 @@ def visualise_macbeth_chart(macbeth_rgb, original_rgb, new_rgb, output_filename)\n for g in range(100):\n image[xlocation + i, ylocation + g] = new_rgb[colorindex]\n \n- img = Image.fromarray(image, 'RGB')\n- img.save(str(output_filename) + 'Generated Macbeth Chart.png')\n+ im_bgr = cv2.cvtColor(image, cv2.COLOR_RGB2BGR)\n+ cv2.imwrite(f'{output_filename} Generated Macbeth Chart.png', im_bgr)\n \n", "prefixes": [ "v2", "08/25" ] }