Patch Detail
Show a patch.
GET /api/patches/20458/?format=api
{ "id": 20458, "url": "https://patchwork.libcamera.org/api/patches/20458/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20458/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240628100227.2910842-4-stefan.klug@ideasonboard.com>", "date": "2024-06-28T10:01:45", "name": "[v2,3/3] apps: common: dng_writer: Support RAW10 and RAW12 format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8b7708908be0c6a151c5653cbc134ecd250be089", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20458/mbox/", "series": [ { "id": 4429, "url": "https://patchwork.libcamera.org/api/series/4429/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4429", "date": "2024-06-28T10:01:42", "name": "* dng_writer: Add support for RAW10 and RAW 12", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4429/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20458/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20458/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2EA5C3295\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jun 2024 10:02:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C2F262E18;\n\tFri, 28 Jun 2024 12:02:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8860562C9D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 12:02:55 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D644BEB;\n\tFri, 28 Jun 2024 12:02:31 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mSTq+Mgj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719568951;\n\tbh=g/48aH0ssZ2ycJU5/A8DtSnNFD0NHcdUlGr+VAIII9w=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mSTq+MgjVh3b5bSNtNpe+LBRMLE8TBJeLEIEaGJ/O7y9CXEKLlp9DseUp2+RX4uqM\n\tWw/x5t2tm8rJLbQ8srwgIU8TTiezj8e99Y+ZJmzPeHVbMQ8tQngaF3G37n0fQG+x0I\n\toDxd3cp8vanfGhkDddnGkoXukHMxSdk+/p1xQNLo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 3/3] apps: common: dng_writer: Support RAW10 and RAW12\n\tformat", "Date": "Fri, 28 Jun 2024 12:01:45 +0200", "Message-ID": "<20240628100227.2910842-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240628100227.2910842-1-stefan.klug@ideasonboard.com>", "References": "<20240628100227.2910842-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for RAW10 and RAW12 to the dng_writer. This is needed on\nimx8mp to produce tuning images. Both formats were tested on a debix\nsom with a imx335.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/apps/common/dng_writer.cpp | 76 ++++++++++++++++++++++++++++++++++\n 1 file changed, 76 insertions(+)", "diff": "diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\nindex 474aa72beb92..f61930b68b2b 100644\n--- a/src/apps/common/dng_writer.cpp\n+++ b/src/apps/common/dng_writer.cpp\n@@ -136,6 +136,34 @@ void packScanlineRaw8(void *output, const void *input, unsigned int width)\n \tstd::copy(in, in + width, out);\n }\n \n+void packScanlineRaw10(void *output, const void *input, unsigned int width)\n+{\n+\tconst uint16_t *in = static_cast<const uint16_t *>(input);\n+\tuint8_t *out = static_cast<uint8_t *>(output);\n+\n+\tfor (unsigned int i = 0; i < width; i += 4) {\n+\t\t*out++ = (in[0] & 0x3fc) >> 2;\n+\t\t*out++ = (in[0] & 0x003) << 6 | (in[1] & 0x3f0) >> 4;\n+\t\t*out++ = (in[1] & 0x00f) << 4 | (in[2] & 0x3c0) >> 6;\n+\t\t*out++ = (in[2] & 0x03f) << 2 | (in[3] & 0x300) >> 8;\n+\t\t*out++ = (in[3] & 0x0ff);\n+\t\tin += 4;\n+\t}\n+}\n+\n+void packScanlineRaw12(void *output, const void *input, unsigned int width)\n+{\n+\tconst uint16_t *in = static_cast<const uint16_t *>(input);\n+\tuint8_t *out = static_cast<uint8_t *>(output);\n+\n+\tfor (unsigned int i = 0; i < width; i += 2) {\n+\t\t*out++ = (in[0] & 0xff0) >> 4;\n+\t\t*out++ = (in[0] & 0x00f) << 4 | (in[1] & 0xf00) >> 8;\n+\t\t*out++ = (in[1] & 0x0ff);\n+\t\tin += 2;\n+\t}\n+}\n+\n void packScanlineRaw16(void *output, const void *input, unsigned int width)\n {\n \tconst uint16_t *in = static_cast<const uint16_t *>(input);\n@@ -341,6 +369,54 @@ const std::map<PixelFormat, FormatInfo> formatInfo = {\n \t\t.packScanline = packScanlineRaw8,\n \t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n \t} },\n+\t{ formats::SBGGR10, {\n+\t\t.bitsPerSample = 10,\n+\t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n+\t\t.packScanline = packScanlineRaw10,\n+\t\t.thumbScanline = thumbScanlineRaw,\n+\t} },\n+\t{ formats::SGBRG10, {\n+\t\t.bitsPerSample = 10,\n+\t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n+\t\t.packScanline = packScanlineRaw10,\n+\t\t.thumbScanline = thumbScanlineRaw,\n+\t} },\n+\t{ formats::SGRBG10, {\n+\t\t.bitsPerSample = 10,\n+\t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n+\t\t.packScanline = packScanlineRaw10,\n+\t\t.thumbScanline = thumbScanlineRaw,\n+\t} },\n+\t{ formats::SRGGB10, {\n+\t\t.bitsPerSample = 10,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineRaw10,\n+\t\t.thumbScanline = thumbScanlineRaw,\n+\t} },\n+\t{ formats::SBGGR12, {\n+\t\t.bitsPerSample = 12,\n+\t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n+\t\t.packScanline = packScanlineRaw12,\n+\t\t.thumbScanline = thumbScanlineRaw,\n+\t} },\n+\t{ formats::SGBRG12, {\n+\t\t.bitsPerSample = 12,\n+\t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n+\t\t.packScanline = packScanlineRaw12,\n+\t\t.thumbScanline = thumbScanlineRaw,\n+\t} },\n+\t{ formats::SGRBG12, {\n+\t\t.bitsPerSample = 12,\n+\t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n+\t\t.packScanline = packScanlineRaw12,\n+\t\t.thumbScanline = thumbScanlineRaw,\n+\t} },\n+\t{ formats::SRGGB12, {\n+\t\t.bitsPerSample = 12,\n+\t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n+\t\t.packScanline = packScanlineRaw12,\n+\t\t.thumbScanline = thumbScanlineRaw,\n+\t} },\n \t{ formats::SBGGR16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n", "prefixes": [ "v2", "3/3" ] }