Patch Detail
Show a patch.
GET /api/patches/20457/?format=api
{ "id": 20457, "url": "https://patchwork.libcamera.org/api/patches/20457/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20457/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240628100227.2910842-3-stefan.klug@ideasonboard.com>", "date": "2024-06-28T10:01:44", "name": "[v2,2/3] apps: common: dng_writer: Add thumbnail scanline function for Raw", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b2672dbeef173bd47a5c81f61b9f8657b07b7b70", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20457/mbox/", "series": [ { "id": 4429, "url": "https://patchwork.libcamera.org/api/series/4429/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4429", "date": "2024-06-28T10:01:42", "name": "* dng_writer: Add support for RAW10 and RAW 12", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4429/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20457/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20457/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0126FBDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Jun 2024 10:02:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D0D262CA0;\n\tFri, 28 Jun 2024 12:02:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7A8C62C97\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Jun 2024 12:02:52 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:82ab:924:d918:cd24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4662EBEB;\n\tFri, 28 Jun 2024 12:02:28 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lhlDuviD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719568948;\n\tbh=9Bah49Vnpil/MHwkYdycCNR1dubtSeMMDk7BBftLQP4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lhlDuviDAFDEQshhifwFcEAvLUZHhFQI3NBJ944KZneboSk/i27/XzPFqQxsWxb8n\n\tcHkC/PqBHLmt9jJA2EGmDWbgXv35l/4ZACP1FbPYs7kCo8vZJNCJwimFFigTs/Hu33\n\tYiOsRe5RB6NFcijkPbWCYf4kY1xR7l/0CuhM4KJo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 2/3] apps: common: dng_writer: Add thumbnail scanline\n\tfunction for Raw", "Date": "Fri, 28 Jun 2024 12:01:44 +0200", "Message-ID": "<20240628100227.2910842-3-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240628100227.2910842-1-stefan.klug@ideasonboard.com>", "References": "<20240628100227.2910842-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a thumbnail function for raw formats that are 16bit aligned.\nThis is needed for the upcoming RAW10 and RAW12 implemntation.\n\nUse the new function for RAW16 as the thumbScanlineRaw_CSI2P produces\nincorrect results for that format (it averages over adjacent bytes,\nwhich works for the CSI formats).\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/apps/common/dng_writer.cpp | 32 ++++++++++++++++++++++++++++----\n 1 file changed, 28 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\nindex 3b17dadc427f..474aa72beb92 100644\n--- a/src/apps/common/dng_writer.cpp\n+++ b/src/apps/common/dng_writer.cpp\n@@ -144,6 +144,30 @@ void packScanlineRaw16(void *output, const void *input, unsigned int width)\n \tstd::copy(in, in + width, out);\n }\n \n+/* Thumbnail function for raw data with each pixel aligned to 16bit. */\n+void thumbScanlineRaw(const FormatInfo &info, void *output,\n+\t\t\t const void *input, unsigned int width,\n+\t\t\t unsigned int stride)\n+{\n+\tconst uint16_t *in = static_cast<const uint16_t *>(input);\n+\tconst uint16_t *in2 = static_cast<const uint16_t *>(input) + stride / 2;\n+\tuint8_t *out = static_cast<uint8_t *>(output);\n+\n+\t/* Shift down to 8. */\n+\tunsigned int shift = info.bitsPerSample - 8;\n+\n+\t/* Simple averaging that produces greyscale RGB values. */\n+\tfor (unsigned int x = 0; x < width; x++) {\n+\t\tuint16_t value = (in[0] + in[1] + in2[0] + in2[1]) >> 2;\n+\t\tvalue = value >> shift;\n+\t\t*out++ = value;\n+\t\t*out++ = value;\n+\t\t*out++ = value;\n+\t\tin += 16;\n+\t\tin2 += 16;\n+\t}\n+}\n+\n void packScanlineRaw10_CSI2P(void *output, const void *input, unsigned int width)\n {\n \tconst uint8_t *in = static_cast<const uint8_t *>(input);\n@@ -321,25 +345,25 @@ const std::map<PixelFormat, FormatInfo> formatInfo = {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternBlue, CFAPatternGreen, CFAPatternGreen, CFAPatternRed },\n \t\t.packScanline = packScanlineRaw16,\n-\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRaw,\n \t} },\n \t{ formats::SGBRG16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternGreen, CFAPatternBlue, CFAPatternRed, CFAPatternGreen },\n \t\t.packScanline = packScanlineRaw16,\n-\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRaw,\n \t} },\n \t{ formats::SGRBG16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternGreen, CFAPatternRed, CFAPatternBlue, CFAPatternGreen },\n \t\t.packScanline = packScanlineRaw16,\n-\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRaw,\n \t} },\n \t{ formats::SRGGB16, {\n \t\t.bitsPerSample = 16,\n \t\t.pattern = { CFAPatternRed, CFAPatternGreen, CFAPatternGreen, CFAPatternBlue },\n \t\t.packScanline = packScanlineRaw16,\n-\t\t.thumbScanline = thumbScanlineRaw_CSI2P,\n+\t\t.thumbScanline = thumbScanlineRaw,\n \t} },\n \t{ formats::SBGGR10_CSI2P, {\n \t\t.bitsPerSample = 10,\n", "prefixes": [ "v2", "2/3" ] }