Patch Detail
Show a patch.
GET /api/patches/20453/?format=api
{ "id": 20453, "url": "https://patchwork.libcamera.org/api/patches/20453/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20453/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240627173305.1477718-2-mzamazal@redhat.com>", "date": "2024-06-27T17:33:04", "name": "[1/2] libcamera: ipa_proxy: Report a missing configuration as a warning", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "22e9d41982e20bbe6004d235ed0c18cef901c7d4", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20453/mbox/", "series": [ { "id": 4427, "url": "https://patchwork.libcamera.org/api/series/4427/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4427", "date": "2024-06-27T17:33:03", "name": "Fix misleading error messages", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4427/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20453/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20453/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CD27BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Jun 2024 17:33:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1447762C9B;\n\tThu, 27 Jun 2024 19:33:28 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7F8262C95\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Jun 2024 19:33:25 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-615-Y4E6POwiM6eO0P5wOhx_4Q-1;\n\tThu, 27 Jun 2024 13:33:23 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 0230C1944D25 for <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Jun 2024 17:33:20 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.47])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id C53D51945CB1; Thu, 27 Jun 2024 17:33:18 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"CrZORGGR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719509604;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=PR5aXOyluNNKRkGlrWCtoTIHyuvwMavP2int0KJtLHI=;\n\tb=CrZORGGRmnu3H12o1vyLiOcvpP/4pp88ftLZGi9I97OYrl+5ThyMq8l2s1riLiTFcE79zQ\n\tK+PNlYo0xV5ukQi7EjwMEP94pPwrhtjXKDmzvcZ6hhTI3OxjbWWB8fRMKUy9nhnbVhJlpd\n\tKhZ6NtknJbW22U7tuqiQJ147QBTJaww=", "X-MC-Unique": "Y4E6POwiM6eO0P5wOhx_4Q-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH 1/2] libcamera: ipa_proxy: Report a missing configuration as\n\ta warning", "Date": "Thu, 27 Jun 2024 19:33:04 +0200", "Message-ID": "<20240627173305.1477718-2-mzamazal@redhat.com>", "In-Reply-To": "<20240627173305.1477718-1-mzamazal@redhat.com>", "References": "<20240627173305.1477718-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the configuration file for an IPA module is missing, it is reported\nas an error in the log, for example:\n\n ERROR IPAProxy ipa_proxy.cpp:149 Configuration file 'imx219.yaml' not found for IPA module 'simple'\n\nThis is misleading because several pipelines use uncalibrated.yaml in\nsuch a case and can continue working. And in case of software ISP,\nthere is currently no other configuration file so the error is always\nreported.\n\nLet's change the error to warning to not confuse users.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/ipa_proxy.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex 6c17c456..494ed736 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -146,7 +146,7 @@ std::string IPAProxy::configurationFile(const std::string &name) const\n \t\t}\n \t}\n \n-\tLOG(IPAProxy, Error)\n+\tLOG(IPAProxy, Warning)\n \t\t<< \"Configuration file '\" << name\n \t\t<< \"' not found for IPA module '\" << ipaName << \"'\";\n \n", "prefixes": [ "1/2" ] }