Patch Detail
Show a patch.
GET /api/patches/20452/?format=api
{ "id": 20452, "url": "https://patchwork.libcamera.org/api/patches/20452/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20452/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240627173305.1477718-3-mzamazal@redhat.com>", "date": "2024-06-27T17:33:05", "name": "[2/2] libcamera: simple: Log a missing sensor in a better way", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "73fe9aabcb9c846887344a00bd3f62dc6fbc6bfc", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20452/mbox/", "series": [ { "id": 4427, "url": "https://patchwork.libcamera.org/api/series/4427/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4427", "date": "2024-06-27T17:33:03", "name": "Fix misleading error messages", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4427/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20452/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20452/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9282BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Jun 2024 17:33:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87BE962C9D;\n\tThu, 27 Jun 2024 19:33:27 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D617619E8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Jun 2024 19:33:25 +0200 (CEST)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-49-5qERQqhqNf-8midqZDFMhA-1;\n\tThu, 27 Jun 2024 13:33:22 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid B3B4D195604F for <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Jun 2024 17:33:21 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.47])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 86CA119560A3; Thu, 27 Jun 2024 17:33:20 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"O4XpAaLg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719509604;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=TCMXqivYLSAAPiYqYCUW32AEruykZYvTFFJBuPYVHp4=;\n\tb=O4XpAaLgw9wSnYzw36NHk5jlfyHP5kCLzR1G841YokSp7F3EOQeB/H/aCRb4QAftWdujEE\n\tS1nYJEfDPIG8AryxKX5CWAz9qtRRgLI5jsAgsnKPXPbN07df8Iab1O3qZ2kPegzNgFO0yi\n\t5hgWKpZONbpcD4BGkhUAD88GcjOZ0S0=", "X-MC-Unique": "5qERQqhqNf-8midqZDFMhA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH 2/2] libcamera: simple: Log a missing sensor in a better way", "Date": "Thu, 27 Jun 2024 19:33:05 +0200", "Message-ID": "<20240627173305.1477718-3-mzamazal@redhat.com>", "In-Reply-To": "<20240627173305.1477718-1-mzamazal@redhat.com>", "References": "<20240627173305.1477718-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "SimplePipelineHandler::match may be called several times for different\npipeline configurations. Not all of these calls must succeed. For\nexample, for TI AM69 board with a single camera attached, the following\nerror is reported in the log even when libcamera works fine:\n\n ERROR SimplePipeline simple.cpp:1558 No sensor found\n\nThis is because a sensor is found for /dev/media0 but not for\n/dev/media1. The error is harmless in such a case and only confuses\nusers who may think no camera is detected at all. Let's change the\nerror to info and add the device node to the message to indicate the\nerror is specific to the given media only. It's up to the callers to\nreport a fatal error condition if libcamera cannot work due to no\nmatching pipeline configuration.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex eb36578e..be0bb677 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1548,9 +1548,10 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t/* Locate the sensors. */\n \tstd::vector<MediaEntity *> sensors = locateSensors();\n \tif (sensors.empty()) {\n-\t\tLOG(SimplePipeline, Error) << \"No sensor found\";\n+\t\tLOG(SimplePipeline, Info) << \"No sensor found for \" << media_->deviceNode();\n \t\treturn false;\n \t}\n+\tLOG(SimplePipeline, Debug) << \"Sensor found for \" << media_->deviceNode();\n \n \t/*\n \t * Create one camera data instance for each sensor and gather all\n", "prefixes": [ "2/2" ] }