Patch Detail
Show a patch.
GET /api/patches/20419/?format=api
{ "id": 20419, "url": "https://patchwork.libcamera.org/api/patches/20419/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20419/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240626140309.50052-7-jacopo.mondi@ideasonboard.com>", "date": "2024-06-26T14:03:02", "name": "[v3,6/9] libcamera: mali-c55: Add stride and size to rawConfig", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cf43e8a19d82d68a5505a8d189dd94e114579283", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20419/mbox/", "series": [ { "id": 4420, "url": "https://patchwork.libcamera.org/api/series/4420/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4420", "date": "2024-06-26T14:02:56", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4420/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20419/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20419/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A92ABDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Jun 2024 14:03:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6463C62B78;\n\tWed, 26 Jun 2024 16:03:32 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 898CF62B69\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Jun 2024 16:03:24 +0200 (CEST)", "from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2ABBB73E;\n\tWed, 26 Jun 2024 16:03:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QzmWDrDL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719410581;\n\tbh=z1E2XulombvGJI+OUREU0T1DbmWRf1u8/RA2PznRyyo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QzmWDrDLA6DRwMyV1Xn1xWKMw0Nnqb6Bk/aJnsIfufqqGsXbKgBJSyumJq1OeYp7T\n\tS2irf1OoG82E2Rm5gcoZK/EwydSFRYgZnpelAyCc8r0km4AWkTn9h+fDWxbEsJRG+G\n\tkJbleeRpzaCiprfMlbb51U0kdV8i8HrYLc4x9m2w=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 6/9] libcamera: mali-c55: Add stride and size to rawConfig", "Date": "Wed, 26 Jun 2024 16:03:02 +0200", "Message-ID": "<20240626140309.50052-7-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>", "References": "<20240626140309.50052-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Daniel Scally <dan.scally@ideasonboard.com>\n\nComplete the RAW StreamConfiguration by populating the frame stride and\nthe frame size.\n\nSet the minimum required alignment to 4 bytes as the Mali C55 ISP output\nexpands RAW output to 16 bits and a RAW Bayer macro-pixel requires\ntwo samples to be complete.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 877a156ccb84..28ad0172658c 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -367,6 +367,10 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \n \t\tmaxSize = rawSize;\n \n+\t\tconst PixelFormatInfo &info = PixelFormatInfo::info(rawConfig->pixelFormat);\n+\t\trawConfig->stride = info.stride(rawConfig->size.width, 0, 4);\n+\t\trawConfig->frameSize = info.frameSize(rawConfig->size, 4);\n+\n \t\trawConfig->setStream(const_cast<Stream *>(&data_->frStream_));\n \t\tfrPipeAvailable = false;\n \t}\n", "prefixes": [ "v3", "6/9" ] }