Patch Detail
Show a patch.
GET /api/patches/20400/?format=api
{ "id": 20400, "url": "https://patchwork.libcamera.org/api/patches/20400/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20400/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240626072100.55497-10-mzamazal@redhat.com>", "date": "2024-06-26T07:20:50", "name": "[09/19] libcamera: software_isp: Create algorithms", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "462453e36b62fe810ba40f80e63a71e5785b5260", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20400/mbox/", "series": [ { "id": 4419, "url": "https://patchwork.libcamera.org/api/series/4419/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4419", "date": "2024-06-26T07:20:41", "name": "Software ISP refactoring", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4419/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20400/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20400/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE7D6BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Jun 2024 07:21:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 694C0654B9;\n\tWed, 26 Jun 2024 09:21:39 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E0D1654BA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Jun 2024 09:21:35 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-103-2neEqG59PGKPzM7IPmuqkA-1;\n\tWed, 26 Jun 2024 03:21:32 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid EBCD5195608D for <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Jun 2024 07:21:31 +0000 (UTC)", "from nuthatch.brq.redhat.com (unknown [10.43.17.159])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id F0DDC300021A; Wed, 26 Jun 2024 07:21:30 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"SqhjYefy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719386494;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=CfCIX1MFEeogTDdO/I4EqAyh2EpusuWHO0/GoR+VBvQ=;\n\tb=SqhjYefyO/dYM6xk1nhTKvdugvdj5JqlbrzzbSUbMayMu5a/KB7YoR2u9HswUXjTIR/GBx\n\tZgRyx4v45LhDb/S3jjk0Wc39SEtqc7G/y+oJQ3OlpCMjMTGfa9zzUwGjM/yjw6NNK+MFxX\n\t37nWaI92OF/3lUhI1c7aNIpeewPxODA=", "X-MC-Unique": "2neEqG59PGKPzM7IPmuqkA-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH 09/19] libcamera: software_isp: Create algorithms", "Date": "Wed, 26 Jun 2024 09:20:50 +0200", "Message-ID": "<20240626072100.55497-10-mzamazal@redhat.com>", "In-Reply-To": "<20240626072100.55497-1-mzamazal@redhat.com>", "References": "<20240626072100.55497-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We are ready to introduce algorithms now. First, let's create\nalgorithms. The algorithms are not called yet, calls to them will be\nadded in followup patches.\n\nThe maximum number of contexts is set to the same value as in hardware\npipelines.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/meson.build | 4 ++++\n src/ipa/simple/data/uncalibrated.yaml | 1 +\n src/ipa/simple/meson.build | 7 +++++--\n src/ipa/simple/soft_simple.cpp | 14 ++++++++++++++\n 4 files changed, 24 insertions(+), 2 deletions(-)\n create mode 100644 src/ipa/simple/algorithms/meson.build", "diff": "diff --git a/src/ipa/simple/algorithms/meson.build b/src/ipa/simple/algorithms/meson.build\nnew file mode 100644\nindex 00000000..31d26e43\n--- /dev/null\n+++ b/src/ipa/simple/algorithms/meson.build\n@@ -0,0 +1,4 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+soft_simple_ipa_algorithms = files([\n+])\ndiff --git a/src/ipa/simple/data/uncalibrated.yaml b/src/ipa/simple/data/uncalibrated.yaml\nindex ff981a1a..2cdc39a8 100644\n--- a/src/ipa/simple/data/uncalibrated.yaml\n+++ b/src/ipa/simple/data/uncalibrated.yaml\n@@ -2,4 +2,5 @@\n %YAML 1.1\n ---\n version: 1\n+algorithms:\n ...\ndiff --git a/src/ipa/simple/meson.build b/src/ipa/simple/meson.build\nindex 33d1c96a..08d877bc 100644\n--- a/src/ipa/simple/meson.build\n+++ b/src/ipa/simple/meson.build\n@@ -1,5 +1,8 @@\n # SPDX-License-Identifier: CC0-1.0\n \n+subdir('algorithms')\n+subdir('data')\n+\n ipa_name = 'ipa_soft_simple'\n \n soft_simple_sources = files([\n@@ -7,6 +10,8 @@ soft_simple_sources = files([\n 'black_level.cpp',\n ])\n \n+soft_simple_sources += soft_simple_ipa_algorithms\n+\n mod = shared_module(ipa_name,\n [soft_simple_sources, libcamera_generated_ipa_headers],\n name_prefix : '',\n@@ -24,6 +29,4 @@ if ipa_sign_module\n build_by_default : true)\n endif\n \n-subdir('data')\n-\n ipa_names += ipa_name\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex f2cfb2dc..6ddb4004 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -54,12 +54,15 @@ static constexpr float kExposureOptimal = kExposureBinsCount / 2.0;\n * enough to prevent the exposure from wobbling around the optimal value.\n */\n static constexpr float kExposureSatisfactory = 0.2;\n+/* Maximum number of frame contexts to be held */\n+static constexpr uint32_t kMaxFrameContexts = 16;\n \n class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n {\n public:\n \tIPASoftSimple()\n \t\t: params_(nullptr), stats_(nullptr), blackLevel_(BlackLevel()),\n+\t\t context_({ {}, {}, { kMaxFrameContexts } }),\n \t\t ignoreUpdates_(0)\n \t{\n \t}\n@@ -93,6 +96,8 @@ private:\n \tstatic constexpr unsigned int kGammaLookupSize = 1024;\n \tstd::array<uint8_t, kGammaLookupSize> gammaTable_;\n \tint lastBlackLevel_ = -1;\n+\t/* Local parameter storage */\n+\tstruct IPAContext context_;\n \n \tint32_t exposureMin_, exposureMax_;\n \tint32_t exposure_;\n@@ -139,6 +144,15 @@ int IPASoftSimple::init(const IPASettings &settings,\n \tunsigned int version = (*data)[\"version\"].get<uint32_t>(0);\n \tLOG(IPASoft, Debug) << \"Tuning file version \" << version;\n \n+\tif (!data->contains(\"algorithms\")) {\n+\t\tLOG(IPASoft, Error) << \"Tuning file doesn't contain algorithms\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tint ret = createAlgorithms(context_, (*data)[\"algorithms\"]);\n+\tif (ret)\n+\t\treturn ret;\n+\n \tparams_ = nullptr;\n \tstats_ = nullptr;\n \n", "prefixes": [ "09/19" ] }