Patch Detail
Show a patch.
GET /api/patches/20397/?format=api
{ "id": 20397, "url": "https://patchwork.libcamera.org/api/patches/20397/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20397/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240626072100.55497-5-mzamazal@redhat.com>", "date": "2024-06-26T07:20:45", "name": "[04/19] libcamera: software_isp: Define skeletons for IPA refactoring", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2ec19316488e4a42b6d28165e60446f3ad6ff291", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20397/mbox/", "series": [ { "id": 4419, "url": "https://patchwork.libcamera.org/api/series/4419/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4419", "date": "2024-06-26T07:20:41", "name": "Software ISP refactoring", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4419/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20397/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20397/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFC61BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Jun 2024 07:21:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74913654B5;\n\tWed, 26 Jun 2024 09:21:32 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F547654B0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Jun 2024 09:21:29 +0200 (CEST)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-365-W937HiMRND2tt_0gPgA3KQ-1;\n\tWed, 26 Jun 2024 03:21:26 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 36C5E19560B0 for <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Jun 2024 07:21:25 +0000 (UTC)", "from nuthatch.brq.redhat.com (unknown [10.43.17.159])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 10939300021A; Wed, 26 Jun 2024 07:21:23 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"irdm7sXj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1719386488;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=FY4YGKe2XLjYu51/Fvh118lP9SnKKS9jWt+LEw5TySg=;\n\tb=irdm7sXjKvrYcNNIeoo0EFkB86A5roctGw7CMsc+j8geB8E1/GGty2j+BpW4vF+PxgNe49\n\tuHjlM0573Qr6i4J3eDLKuVMCguXvplpD3udQQpQmtZbloPwB6YUD+i9A9WbAsO6FqWQuqC\n\t2zbNUNubzq9GijbZsyeCO3H/m//PZCw=", "X-MC-Unique": "W937HiMRND2tt_0gPgA3KQ-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH 04/19] libcamera: software_isp: Define skeletons for IPA\n\trefactoring", "Date": "Wed, 26 Jun 2024 09:20:45 +0200", "Message-ID": "<20240626072100.55497-5-mzamazal@redhat.com>", "In-Reply-To": "<20240626072100.55497-1-mzamazal@redhat.com>", "References": "<20240626072100.55497-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Software ISP image processing algorithms are currently defined in a\nsimplified way, different from other libcamera pipelines. This is not\ngood for several reasons:\n\n- It makes the software ISP code harder to understand due to its\n different structuring.\n- Adding more algorithms may make the code harder to understand\n generally.\n- Mass libcamera code changes may not be easily applicable to software\n ISP.\n- Algorithm sharing with other pipelines is not easily possible.\n\nThis patch introduces basic software ISP IPA skeletons structured\nsimilarly to the other pipelines. The newly added files are currently\nnot used or compiled and the general skeleton structures don't contain\nanything particular. It is just a preparation step for a larger\nrefactoring and the code will be actually used and extended as needed in\nfollowup patches.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/algorithm.h | 22 +++++++++++++++++\n src/ipa/simple/ipa_context.h | 34 +++++++++++++++++++++++++++\n src/ipa/simple/module.h | 30 +++++++++++++++++++++++\n 3 files changed, 86 insertions(+)\n create mode 100644 src/ipa/simple/algorithms/algorithm.h\n create mode 100644 src/ipa/simple/ipa_context.h\n create mode 100644 src/ipa/simple/module.h", "diff": "diff --git a/src/ipa/simple/algorithms/algorithm.h b/src/ipa/simple/algorithms/algorithm.h\nnew file mode 100644\nindex 00000000..41f63170\n--- /dev/null\n+++ b/src/ipa/simple/algorithms/algorithm.h\n@@ -0,0 +1,22 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024 Red Hat, Inc.\n+ *\n+ * Software ISP control algorithm interface\n+ */\n+\n+#pragma once\n+\n+#include <libipa/algorithm.h>\n+\n+#include \"module.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::soft {\n+\n+using Algorithm = libcamera::ipa::Algorithm<Module>;\n+\n+} /* namespace ipa::soft */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nnew file mode 100644\nindex 00000000..bc1235b6\n--- /dev/null\n+++ b/src/ipa/simple/ipa_context.h\n@@ -0,0 +1,34 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024 Red Hat, Inc.\n+ *\n+ * Simple pipeline IPA Context\n+ *\n+ */\n+\n+#pragma once\n+\n+#include <libipa/fc_queue.h>\n+\n+namespace libcamera {\n+\n+namespace ipa::soft {\n+\n+struct IPASessionConfiguration {\n+};\n+\n+struct IPAActiveState {\n+};\n+\n+struct IPAFrameContext : public FrameContext {\n+};\n+\n+struct IPAContext {\n+\tIPASessionConfiguration configuration;\n+\tIPAActiveState activeState;\n+\tFCQueue<IPAFrameContext> frameContexts;\n+};\n+\n+} /* namespace ipa::soft */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/simple/module.h b/src/ipa/simple/module.h\nnew file mode 100644\nindex 00000000..21328ecd\n--- /dev/null\n+++ b/src/ipa/simple/module.h\n@@ -0,0 +1,30 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2024 Red Hat, Inc.\n+ *\n+ * Software ISP IPA Module\n+ */\n+\n+#pragma once\n+\n+#include <libcamera/controls.h>\n+\n+#include <libcamera/ipa/core_ipa_interface.h>\n+\n+#include \"libcamera/internal/software_isp/debayer_params.h\"\n+#include \"libcamera/internal/software_isp/swisp_stats.h\"\n+\n+#include <libipa/module.h>\n+\n+#include \"ipa_context.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::soft {\n+\n+using Module = ipa::Module<IPAContext, IPAFrameContext, ControlInfoMap,\n+\t\t\t DebayerParams, SwIspStats>;\n+\n+} /* namespace ipa::soft */\n+\n+} /* namespace libcamera */\n", "prefixes": [ "04/19" ] }