Patch Detail
Show a patch.
GET /api/patches/20391/?format=api
{ "id": 20391, "url": "https://patchwork.libcamera.org/api/patches/20391/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20391/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240625190423.291429-6-jacopo.mondi@ideasonboard.com>", "date": "2024-06-25T19:04:18", "name": "[v2,5/6] libcamera: mali-c55: Remove MaliC55CameraData::mbusCodes()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b278d899c81f640da96623f3c7b95e073feb470d", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20391/mbox/", "series": [ { "id": 4418, "url": "https://patchwork.libcamera.org/api/series/4418/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4418", "date": "2024-06-25T19:04:13", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4418/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20391/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20391/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82B26BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Jun 2024 19:04:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 23710654B7;\n\tTue, 25 Jun 2024 21:04:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29A52654B0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jun 2024 21:04:37 +0200 (CEST)", "from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 16036BEB;\n\tTue, 25 Jun 2024 21:04:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a6aU7Arw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719342255;\n\tbh=wN50r+M/uOzdwSu5F0FIvJe74OsLmZASfJ5scGgYJ/Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=a6aU7ArwwaAOpb7MpvjDChrebKV9rD2cDHonJGT9VoJTz9UXiS0CqaQSAczlEjRWv\n\tB9OnaD7dhc+CXVkBgYZ5D21NoMdysdIMst6xTHJuUAla0EPUXdnSFsJGAI7V7ZnIit\n\t5pv40Xt3NZetAyaovsfy7HZS0wZiBvX72XxKdyjM=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 5/6] libcamera: mali-c55: Remove\n\tMaliC55CameraData::mbusCodes()", "Date": "Tue, 25 Jun 2024 21:04:18 +0200", "Message-ID": "<20240625190423.291429-6-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>", "References": "<20240625190423.291429-1-jacopo.mondi@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Daniel Scally <dan.scally@ideasonboard.com>\n\nThe MaliC55CameraData::mbusCodes() function is unused. Remove it.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 9 ---------\n 1 file changed, 9 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex ee73a092eb5b..f1c057c1aeb4 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -95,7 +95,6 @@ public:\n \tint init();\n \n \t/* Deflect these functionalities to either TPG or CameraSensor. */\n-\tconst std::vector<unsigned int> mbusCodes() const;\n \tconst std::vector<Size> sizes(unsigned int mbusCode) const;\n \tconst Size resolution() const;\n \n@@ -178,14 +177,6 @@ void MaliC55CameraData::initTPGData()\n \ttpgResolution_ = tpgSizes_.back();\n }\n \n-const std::vector<unsigned int> MaliC55CameraData::mbusCodes() const\n-{\n-\tif (sensor_)\n-\t\treturn sensor_->mbusCodes();\n-\n-\treturn tpgCodes_;\n-}\n-\n const std::vector<Size> MaliC55CameraData::sizes(unsigned int mbusCode) const\n {\n \tif (sensor_)\n", "prefixes": [ "v2", "5/6" ] }