Patch Detail
Show a patch.
GET /api/patches/20385/?format=api
{ "id": 20385, "url": "https://patchwork.libcamera.org/api/patches/20385/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20385/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240625090146.1925569-1-stefan.klug@ideasonboard.com>", "date": "2024-06-25T09:01:17", "name": "[v2] apps: common: dng_writer: Workaround for \"Unknown tag 33421\" error", "commit_ref": "36a4f67a755ef54d81944ae6d8b11685e5a41a28", "pull_url": null, "state": "accepted", "archived": false, "hash": "dfa38e88e404eac7929252c5c0db742b63609bbb", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20385/mbox/", "series": [ { "id": 4417, "url": "https://patchwork.libcamera.org/api/series/4417/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4417", "date": "2024-06-25T09:01:17", "name": "[v2] apps: common: dng_writer: Workaround for \"Unknown tag 33421\" error", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4417/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20385/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20385/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69060BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Jun 2024 09:01:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2E5E654A9;\n\tTue, 25 Jun 2024 11:01:52 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 02A14619E8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Jun 2024 11:01:50 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:ac8e:9f5c:939f:7f08])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79731C62;\n\tTue, 25 Jun 2024 11:01:28 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QXiuvWXo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719306088;\n\tbh=bUEs4j78nKrkBbm2mB50FQLsjowQmtf71LarjahiHx4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=QXiuvWXogPW+4w2R2neaBqjJyh32faXo5cuU4PWEUIhyKQn+T6/o2j4LCwMOoeVXi\n\t6HXGGnQQZJl9neWnJj9d6vc7Xwk7twf5VK0VpBoaEsk7DGmnTA/rnjn/5OOt66avcp\n\t2zb18fq1tMEbLUw3QFre2cw4ZTG1Ub6H5kpKOFe8=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2] apps: common: dng_writer: Workaround for \"Unknown tag\n\t33421\" error", "Date": "Tue, 25 Jun 2024 11:01:17 +0200", "Message-ID": "<20240625090146.1925569-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In libtiff version 4.5.1 and later the CFA* tags were missing. This got\nfixed in https://gitlab.com/libtiff/libtiff/-/commit/49856998c3d82e65444b47bb4fb11b7830a0c2be\nUnfortunately the fix is not released yet, but the faulty libtiff is\ncontained in current buildroot. As a local fix is pretty easy and\nwithout side effects, let's workaround that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges in v2:\n- Removed EP prefix from tag names as these weren't available in older\n libtiff versions (the values are the same)\n\n src/apps/common/dng_writer.cpp | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)", "diff": "diff --git a/src/apps/common/dng_writer.cpp b/src/apps/common/dng_writer.cpp\nindex 103e5c828c4d..5a1de8010a47 100644\n--- a/src/apps/common/dng_writer.cpp\n+++ b/src/apps/common/dng_writer.cpp\n@@ -541,6 +541,23 @@ int DNGWriter::write(const char *filename, const Camera *camera,\n \n \tTIFFWriteDirectory(tif);\n \n+\t/*\n+\t * Workaround for a bug introduced in libtiff version 4.5.1 and no fix\n+\t * released. In these versions the CFA* tags were missing in the field\n+\t * info.\n+\t * Introduced by: https://gitlab.com/libtiff/libtiff/-/commit/738e04099b13192bb1f654e74e9b5829313f3161\n+\t * Fixed by: https://gitlab.com/libtiff/libtiff/-/commit/49856998c3d82e65444b47bb4fb11b7830a0c2be\n+\t */\n+\tif (!TIFFFindField(tif, TIFFTAG_CFAREPEATPATTERNDIM, TIFF_ANY)) {\n+\t\tstatic const TIFFFieldInfo infos[] = {\n+\t\t\t{ TIFFTAG_CFAREPEATPATTERNDIM, 2, 2, TIFF_SHORT, FIELD_CUSTOM,\n+\t\t\t 1, 0, const_cast<char *>(\"CFARepeatPatternDim\") },\n+\t\t\t{ TIFFTAG_CFAPATTERN, -1, -1, TIFF_BYTE, FIELD_CUSTOM,\n+\t\t\t 1, 1, const_cast<char *>(\"CFAPattern\") },\n+\t\t};\n+\t\tTIFFMergeFieldInfo(tif, infos, 2);\n+\t}\n+\n \t/* Create a new IFD for the RAW image. */\n \tconst uint16_t cfaRepeatPatternDim[] = { 2, 2 };\n \tconst uint8_t cfaPlaneColor[] = {\n", "prefixes": [ "v2" ] }