Patch Detail
Show a patch.
GET /api/patches/20370/?format=api
{ "id": 20370, "url": "https://patchwork.libcamera.org/api/patches/20370/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20370/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240624192941.22943-4-laurent.pinchart@ideasonboard.com>", "date": "2024-06-24T19:29:34", "name": "[03/10] ipa: rpi: Define local functions in anonymous namespace", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8b919267a3ab827f78ab0cff3c4cb24544e0dea2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20370/mbox/", "series": [ { "id": 4413, "url": "https://patchwork.libcamera.org/api/series/4413/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4413", "date": "2024-06-24T19:29:31", "name": "libcamera: Enable -Wmissing-declarations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4413/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20370/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20370/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC6C4BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Jun 2024 19:30:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 62453654A3;\n\tMon, 24 Jun 2024 21:30:14 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49408654A4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Jun 2024 21:30:08 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B0661920;\n\tMon, 24 Jun 2024 21:29:46 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bblzG9Lm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719257386;\n\tbh=Di1YBA3b4BJ7lfuLwErRfBSyJwCU/ZdoC6j1+QW/VYQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bblzG9Lmc9S5x86I7BEicymegRissuVDfb3FAbtkx3EdhY6TNnByCFoqfAgTOz2fw\n\tcGUX+f3vcct1ufIdum8X9kOeLg5NWVmcTcl8+jUN2Xhi2cz8kPZkpbslJoAOdX/cqu\n\t8sQo/rIhyNDfu3XtunrFfBZNb9zockGeIA/ieIKI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH 03/10] ipa: rpi: Define local functions in anonymous\n\tnamespace", "Date": "Mon, 24 Jun 2024 22:29:34 +0300", "Message-ID": "<20240624192941.22943-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>", "References": "<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Multiple local functions are defined in the global namespace without the\nstatic keyword. This compiles fine for now, but will cause a missing\ndeclaration warning when we enable them. To prepare for that, move the\nfunction declaration to an anonymous namespace.\n\nWhile at it, for consistency, include an existing static function in the\nnamespace and drop the static keyword.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rpi/controller/rpi/ccm.cpp | 6 +++++-\n src/ipa/rpi/controller/rpi/contrast.cpp | 4 ++++\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rpi/controller/rpi/ccm.cpp b/src/ipa/rpi/controller/rpi/ccm.cpp\nindex e673964c1856..aefa580c9a4b 100644\n--- a/src/ipa/rpi/controller/rpi/ccm.cpp\n+++ b/src/ipa/rpi/controller/rpi/ccm.cpp\n@@ -113,8 +113,10 @@ void Ccm::initialise()\n {\n }\n \n+namespace {\n+\n template<typename T>\n-static bool getLocked(Metadata *metadata, std::string const &tag, T &value)\n+bool getLocked(Metadata *metadata, std::string const &tag, T &value)\n {\n \tT *ptr = metadata->getLocked<T>(tag);\n \tif (ptr == nullptr)\n@@ -149,6 +151,8 @@ Matrix applySaturation(Matrix const &ccm, double saturation)\n \treturn Y2RGB * S * RGB2Y * ccm;\n }\n \n+} /* namespace */\n+\n void Ccm::prepare(Metadata *imageMetadata)\n {\n \tbool awbOk = false, luxOk = false;\ndiff --git a/src/ipa/rpi/controller/rpi/contrast.cpp b/src/ipa/rpi/controller/rpi/contrast.cpp\nindex 9b37943ae9c9..fe866a544293 100644\n--- a/src/ipa/rpi/controller/rpi/contrast.cpp\n+++ b/src/ipa/rpi/controller/rpi/contrast.cpp\n@@ -94,6 +94,8 @@ void Contrast::prepare(Metadata *imageMetadata)\n \timageMetadata->set(\"contrast.status\", status_);\n }\n \n+namespace {\n+\n ipa::Pwl computeStretchCurve(Histogram const &histogram,\n \t\t\tContrastConfig const &config)\n {\n@@ -153,6 +155,8 @@ ipa::Pwl applyManualContrast(ipa::Pwl const &gammaCurve, double brightness,\n \treturn newGammaCurve;\n }\n \n+} /* namespace */\n+\n void Contrast::process(StatisticsPtr &stats,\n \t\t [[maybe_unused]] Metadata *imageMetadata)\n {\n", "prefixes": [ "03/10" ] }