Patch Detail
Show a patch.
GET /api/patches/20334/?format=api
{ "id": 20334, "url": "https://patchwork.libcamera.org/api/patches/20334/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20334/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240616163910.5506-7-laurent.pinchart@ideasonboard.com>", "date": "2024-06-16T16:39:04", "name": "[06/12] ipa: rkisp1: agc: Make size argument to computeHistogramPredivider const", "commit_ref": "de4ed4e966b476dbcfa63bc61028b0fc16ee4a78", "pull_url": null, "state": "accepted", "archived": false, "hash": "c879d310535d65e591bbcd1129d3f186e8a92ed2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20334/mbox/", "series": [ { "id": 4400, "url": "https://patchwork.libcamera.org/api/series/4400/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4400", "date": "2024-06-16T16:38:58", "name": "ipa: rkisp1: Miscellaneous AGC fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4400/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20334/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20334/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F7F1C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 16 Jun 2024 16:39:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E31546549C;\n\tSun, 16 Jun 2024 18:39:52 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4DE465490\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 16 Jun 2024 18:39:39 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 608B9669\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 16 Jun 2024 18:39:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l1/WFQ48\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718555963;\n\tbh=Cux+EXVIIdq/5V99cPg+41qLkr+U9xjwm5zElv5DWsY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=l1/WFQ48Tm93p4v2qCVPw94Fc8cY2YeVRFkBAXXhIS18mj/WwgOpgtPhlHghc8y49\n\t35OHbi/bPRcXyDUaJMeqjY4mYOYJ3smW8UlM7KT5zGeydOZ7lwGu0Tr3Li12XxqVRY\n\tBZTmhWoax6U2zShtDcUgFZ2oojugvP9GkX8o2U84=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 06/12] ipa: rkisp1: agc: Make size argument to\n\tcomputeHistogramPredivider const", "Date": "Sun, 16 Jun 2024 19:39:04 +0300", "Message-ID": "<20240616163910.5506-7-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "In-Reply-To": "<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>", "References": "<20240616163910.5506-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Agc::computeHistogramPredivider() function doesn't need to modify\nits size parameter. Make it const.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 3 ++-\n src/ipa/rkisp1/algorithms/agc.h | 2 +-\n 2 files changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 0f60d08fd41c..9dac60bdb24e 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -84,7 +84,8 @@ int Agc::parseMeteringModes(IPAContext &context, const YamlObject &tuningData)\n \treturn 0;\n }\n \n-uint8_t Agc::computeHistogramPredivider(Size &size, enum rkisp1_cif_isp_histogram_mode mode)\n+uint8_t Agc::computeHistogramPredivider(const Size &size,\n+\t\t\t\t\tenum rkisp1_cif_isp_histogram_mode mode)\n {\n \t/*\n \t * The maximum number of pixels that could potentially be in one bin is\ndiff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\nindex 996fea71755c..9ceaa82b099e 100644\n--- a/src/ipa/rkisp1/algorithms/agc.h\n+++ b/src/ipa/rkisp1/algorithms/agc.h\n@@ -45,7 +45,7 @@ public:\n \n private:\n \tint parseMeteringModes(IPAContext &context, const YamlObject &tuningData);\n-\tuint8_t computeHistogramPredivider(Size &size,\n+\tuint8_t computeHistogramPredivider(const Size &size,\n \t\t\t\t\t enum rkisp1_cif_isp_histogram_mode mode);\n \n \tvoid fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n", "prefixes": [ "06/12" ] }