Patch Detail
Show a patch.
GET /api/patches/20306/?format=api
{ "id": 20306, "url": "https://patchwork.libcamera.org/api/patches/20306/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20306/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240613155949.1041061-6-dan.scally@ideasonboard.com>", "date": "2024-06-13T15:59:47", "name": "[5/7] libcamera: mali-c55: Simplify bufferReady()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9c8ac22179241956c6f87fbeeef692ede126f6b6", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20306/mbox/", "series": [ { "id": 4391, "url": "https://patchwork.libcamera.org/api/series/4391/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4391", "date": "2024-06-13T15:59:42", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4391/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20306/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20306/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4D13C32CF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Jun 2024 16:00:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5624C654A3;\n\tThu, 13 Jun 2024 18:00:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F3E265491\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Jun 2024 17:59:59 +0200 (CEST)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A6994CF;\n\tThu, 13 Jun 2024 17:59:45 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nC7HL7Aj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718294385;\n\tbh=Xq9FkgMknYrUyeQ3aoOoCUw/JHrYAGO86uOhnTdYSBA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nC7HL7Aj6cdJAzFrWqq7VwxA3L/QOPkb7EeC72sFoUSGveAbzwubrC8Ivwyg+HsvI\n\tb90LPLm/eO/34LuISLHt1VgfOdVU6Cq86JndDNYhKIoEAP9vHoay2S3TMDC8uJWsCY\n\tBwMQfaz9aaNJpcz0WtThe9MLvByTyUsBjziHfOgY=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH 5/7] libcamera: mali-c55: Simplify bufferReady()", "Date": "Thu, 13 Jun 2024 16:59:47 +0100", "Message-Id": "<20240613155949.1041061-6-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240613155949.1041061-1-dan.scally@ideasonboard.com>", "References": "<20240613155949.1041061-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "bufferReady() is needlessly complicated; simplify it.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 2b1d766a..910eac5e 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1028,12 +1028,8 @@ void PipelineHandlerMaliC55::bufferReady(FrameBuffer *buffer)\n {\n \tRequest *request = buffer->request();\n \n-\tcompleteBuffer(request, buffer);\n-\n-\tif (request->hasPendingBuffers())\n-\t\treturn;\n-\n-\tcompleteRequest(request);\n+\tif (completeBuffer(request, buffer))\n+\t\tcompleteRequest(request);\n }\n \n void PipelineHandlerMaliC55::registerMaliCamera(std::unique_ptr<MaliC55CameraData> data,\n", "prefixes": [ "5/7" ] }