Patch Detail
Show a patch.
GET /api/patches/20305/?format=api
{ "id": 20305, "url": "https://patchwork.libcamera.org/api/patches/20305/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20305/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240613155949.1041061-5-dan.scally@ideasonboard.com>", "date": "2024-06-13T15:59:46", "name": "[4/7] libcamera: mali-c55: Init camera properties", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bbd22714996c72f028577b2702bd939bfe6a7a87", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20305/mbox/", "series": [ { "id": 4391, "url": "https://patchwork.libcamera.org/api/series/4391/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4391", "date": "2024-06-13T15:59:42", "name": "Miscellaneous Mali-C55 Pipeline Fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4391/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20305/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20305/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE437C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Jun 2024 16:00:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB0356549E;\n\tThu, 13 Jun 2024 18:00:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A21A65490\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Jun 2024 17:59:59 +0200 (CEST)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB8144CC;\n\tThu, 13 Jun 2024 17:59:44 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JWQbWYFC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718294385;\n\tbh=5tz1v6za8eMKWh+EM30lkNF8TBDc9H1VeBUkOftoL34=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JWQbWYFC2sWK9h71TEM16vRzAkcKAQgNTssvyl8qE6tSJ5+G2Q/XTxVwghzrlxdtn\n\twRHO+YeHSpXrqR1RBqJCsV2hxnCRTkNLPoNVegRyfn2/9x7UO4ECQneTVhKrqRbXmi\n\tqDiTu2C6mq30csu3HgcgL8hqhoFZgantzfwHHBK8=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH 4/7] libcamera: mali-c55: Init camera properties", "Date": "Thu, 13 Jun 2024 16:59:46 +0100", "Message-Id": "<20240613155949.1041061-5-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240613155949.1041061-1-dan.scally@ideasonboard.com>", "References": "<20240613155949.1041061-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Initialise camera properties so that DNG files written by cam contain\nmodel information for the LSC tuning scripts.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 2c34f3e9..2b1d766a 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1099,8 +1099,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)\n \t\tif (data->init())\n \t\t\treturn false;\n \n-\t\t/* \\todo: Init properties. */\n-\n+\t\tdata->properties_ = data->sensor_->properties();\n \t\tdata->updateControls();\n \n \t\tregisterMaliCamera(std::move(data), sensor->name());\n", "prefixes": [ "4/7" ] }