Patch Detail
Show a patch.
GET /api/patches/2020/?format=api
{ "id": 2020, "url": "https://patchwork.libcamera.org/api/patches/2020/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2020/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190924172503.30864-22-jacopo@jmondi.org>", "date": "2019-09-24T17:25:03", "name": "[libcamera-devel,21/21] POC: cam: Set random controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e2f4327095acb34177b72ab838d4d06a66817064", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2020/mbox/", "series": [ { "id": 506, "url": "https://patchwork.libcamera.org/api/series/506/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=506", "date": "2019-09-24T17:24:42", "name": "Implement control serialization", "version": 1, "mbox": "https://patchwork.libcamera.org/series/506/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2020/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2020/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FA026238B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Sep 2019 19:23:42 +0200 (CEST)", "from uno.homenet.telecomitalia.it\n\t(host89-248-dynamic.45-213-r.retail.telecomitalia.it [213.45.248.89])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C97AC60005\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Sep 2019 17:23:41 +0000 (UTC)" ], "X-Originating-IP": "213.45.248.89", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 24 Sep 2019 19:25:03 +0200", "Message-Id": "<20190924172503.30864-22-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20190924172503.30864-1-jacopo@jmondi.org>", "References": "<20190924172503.30864-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 21/21] POC: cam: Set random controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 24 Sep 2019 17:23:42 -0000" }, "content": "Set random values for 3 controls supporte by the VIMC camera.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/cam/capture.cpp | 12 ++++++++++++\n src/cam/capture.h | 2 ++\n 2 files changed, 14 insertions(+)", "diff": "diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\nindex 8a939c622703..ce655c683a78 100644\n--- a/src/cam/capture.cpp\n+++ b/src/cam/capture.cpp\n@@ -7,6 +7,7 @@\n \n #include <chrono>\n #include <climits>\n+#include <cstdlib>\n #include <iomanip>\n #include <iostream>\n #include <sstream>\n@@ -114,6 +115,7 @@ int Capture::capture(EventLoop *loop)\n \t}\n \n \tfor (Request *request : requests) {\n+\t\tsetControls(request);\n \t\tret = camera_->queueRequest(request);\n \t\tif (ret < 0) {\n \t\t\tstd::cerr << \"Can't queue request\" << std::endl;\n@@ -188,5 +190,15 @@ void Capture::requestComplete(Request *request, const std::map<Stream *, Buffer\n \t\trequest->addBuffer(std::move(newBuffer));\n \t}\n \n+\tsetControls(request);\n \tcamera_->queueRequest(request);\n }\n+\n+void Capture::setControls(libcamera::Request *request)\n+{\n+\tControlList &controls = request->controls();\n+\n+\tcontrols[Brightness] = rand() % 255;\n+\tcontrols[Saturation] = rand() % 500;\n+\tcontrols[Contrast] = rand() % 128;\n+}\ndiff --git a/src/cam/capture.h b/src/cam/capture.h\nindex ee0dc4211111..b98cd37eff87 100644\n--- a/src/cam/capture.h\n+++ b/src/cam/capture.h\n@@ -31,6 +31,8 @@ private:\n \tvoid requestComplete(libcamera::Request *request,\n \t\t\t const std::map<libcamera::Stream *, libcamera::Buffer *> &buffers);\n \n+\tvoid setControls(libcamera::Request *request);\n+\n \tlibcamera::Camera *camera_;\n \tlibcamera::CameraConfiguration *config_;\n \n", "prefixes": [ "libcamera-devel", "21/21" ] }