Patch Detail
Show a patch.
GET /api/patches/20188/?format=api
{ "id": 20188, "url": "https://patchwork.libcamera.org/api/patches/20188/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20188/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240603111259.54321-4-hdegoede@redhat.com>", "date": "2024-06-03T11:12:59", "name": "[v3,3/3] libcamera: software_isp: Allow using dma-buffers from /dev/udmabuf", "commit_ref": "d284ac2d593725248e074bf9cbee2c44e76c38bd", "pull_url": null, "state": "accepted", "archived": false, "hash": "62dd46ec13f3934198de9ce0d5a7da01556e353c", "submitter": { "id": 102, "url": "https://patchwork.libcamera.org/api/people/102/?format=api", "name": "Hans de Goede", "email": "hdegoede@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20188/mbox/", "series": [ { "id": 4352, "url": "https://patchwork.libcamera.org/api/series/4352/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4352", "date": "2024-06-03T11:12:56", "name": "libcamera: dma_buffer_allocator: Add support for using udmabuf to alloc dma-buffers", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4352/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20188/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20188/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74D2BBD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Jun 2024 11:13:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D6DD634D9;\n\tMon, 3 Jun 2024 13:13:12 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DCFA0634B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Jun 2024 13:13:09 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-125-A-1SSk6kMyCIAwpOK_ys4w-1; Mon, 03 Jun 2024 07:13:05 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id E72958058D6;\n\tMon, 3 Jun 2024 11:13:04 +0000 (UTC)", "from x1.localdomain.com (unknown [10.39.193.39])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0CC602870;\n\tMon, 3 Jun 2024 11:13:03 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"aVQ6v6qg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1717413188;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=cIh4hgynOTgyYs33MsOHTHEAhPF8crQlm7ZcrRZS3Zk=;\n\tb=aVQ6v6qgHODqxo6tm/WAXCm52uJYtp1MSndR4WFDxoGndkEQ39XKLEsz3YSame0Mwo+mlu\n\tvZRVIYzF4WCCOIy/i9dFLcCnbHvBO19CUfNOzVmU/iBmZs3SwaCBN2BOSWunQAxeULHKid\n\t5uqrc9VAiyY2EPQOrlAnwahcFYea8KE=", "X-MC-Unique": "A-1SSk6kMyCIAwpOK_ys4w-1", "From": "Hans de Goede <hdegoede@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Maxime Ripard <mripard@redhat.com>, Milan Zamazal <mzamazal@redhat.com>, \n\tHans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 3/3] libcamera: software_isp: Allow using dma-buffers from\n\t/dev/udmabuf", "Date": "Mon, 3 Jun 2024 13:12:59 +0200", "Message-ID": "<20240603111259.54321-4-hdegoede@redhat.com>", "In-Reply-To": "<20240603111259.54321-1-hdegoede@redhat.com>", "References": "<20240603111259.54321-1-hdegoede@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.5", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Allow the DmaBufAllocator used by the software ISP to use memfd() +\n/dev/udmabuf for the software ISP destination buffers.\n\nThis is useful on Linux distributions where normal users are not allowed\nto access /dev/dma_heap/* while they are allowed to access /dev/udmabuf.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nTested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> # Lenovo-x13s\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\n---\n src/libcamera/software_isp/software_isp.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 034727c5..20fb6f48 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -67,7 +67,8 @@ LOG_DEFINE_CATEGORY(SoftwareIsp)\n */\n SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor)\n \t: dmaHeap_(DmaBufAllocator::DmaBufAllocatorFlag::CmaHeap |\n-\t\t DmaBufAllocator::DmaBufAllocatorFlag::SystemHeap)\n+\t\t DmaBufAllocator::DmaBufAllocatorFlag::SystemHeap |\n+\t\t DmaBufAllocator::DmaBufAllocatorFlag::UDmaBuf)\n {\n \t/*\n \t * debayerParams_ must be initialized because the initial value is used for\n", "prefixes": [ "v3", "3/3" ] }