Patch Detail
Show a patch.
GET /api/patches/20122/?format=api
{ "id": 20122, "url": "https://patchwork.libcamera.org/api/patches/20122/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20122/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240529154341.10426-5-laurent.pinchart@ideasonboard.com>", "date": "2024-05-29T15:43:39", "name": "[v2,4/6] test: fence: Increase timeout for fence test", "commit_ref": "dedf9cf264656c7ce396fb66b69e3c8fcfd458c4", "pull_url": null, "state": "accepted", "archived": false, "hash": "6a77befcf5d19ce85a285e02355f5b872220de51", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20122/mbox/", "series": [ { "id": 4333, "url": "https://patchwork.libcamera.org/api/series/4333/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4333", "date": "2024-05-29T15:43:35", "name": "vimc scaling improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4333/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20122/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20122/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9548DBDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 29 May 2024 15:44:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14004634B7;\n\tWed, 29 May 2024 17:44:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D751634AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 May 2024 17:43:58 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D77B94AB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 May 2024 17:43:54 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fFN5QQ8P\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716997435;\n\tbh=gtZSbMfjMdGrwNsU0K5qBh33wOtp8BK3bJ/1O7dySqM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fFN5QQ8PExDicrw9IWnik1Y1sOdVRKeS+RUelHpLrpwz44z+WNelz9qAg+YkhkymL\n\tGsydQuJUZt3wL8Agwy8gLKBn92gn02MOkhWIYGXXFl1F0KqnX8vdepO0WBiVDBro4e\n\tufHwq69RpKApJoii7UGR7nY55yRAAg5lAgdYww2M=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 4/6] test: fence: Increase timeout for fence test", "Date": "Wed, 29 May 2024 18:43:39 +0300", "Message-ID": "<20240529154341.10426-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.1", "In-Reply-To": "<20240529154341.10426-1-laurent.pinchart@ideasonboard.com>", "References": "<20240529154341.10426-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "On slower machines, a 1s timeout to capture frames with vimc can be too\nshort and cause test failures. Make the timeout proportional to the\nnumber of frames expected to be captured, using a conservative low\nestimate of the frame rate at 2fps.\n\nBy itself, that change could increase the test time quite substantially\non fast platforms, so break from the capture loop as soon as we capture\nenough frames.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v1:\n\n- Update comment\n---\n test/fence.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/fence.cpp b/test/fence.cpp\nindex a8fba7284d82..8095b22895c7 100644\n--- a/test/fence.cpp\n+++ b/test/fence.cpp\n@@ -327,10 +327,14 @@ int FenceTest::run()\n \tTimer fenceTimer;\n \tfenceTimer.timeout.connect(this, &FenceTest::signalFence);\n \n-\t/* Loop for one second. */\n+\t/*\n+\t * Loop long enough for all requests to complete, allowing 500ms per\n+\t * request.\n+\t */\n \tTimer timer;\n-\ttimer.start(1000ms);\n-\twhile (timer.isRunning() && expectedCompletionResult_) {\n+\ttimer.start(500ms * (signalledRequestId_ + 1));\n+\twhile (timer.isRunning() && expectedCompletionResult_ &&\n+\t completedRequestId_ <= signalledRequestId_ + 1) {\n \t\tif (completedRequestId_ == signalledRequestId_ - 1 && setFence_)\n \t\t\t/*\n \t\t\t * The request just before signalledRequestId_ has just\n", "prefixes": [ "v2", "4/6" ] }