Patch Detail
Show a patch.
GET /api/patches/201/?format=api
{ "id": 201, "url": "https://patchwork.libcamera.org/api/patches/201/?format=api", "web_url": "https://patchwork.libcamera.org/patch/201/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190111110956.14812-2-jacopo@jmondi.org>", "date": "2019-01-11T11:09:54", "name": "[libcamera-devel,1/3] test: media_device: Make MediaDeviceTest a MediaDevicePrintTest", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d2944ae375ce5d310cc18028d91545309746d461", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/201/mbox/", "series": [ { "id": 67, "url": "https://patchwork.libcamera.org/api/series/67/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=67", "date": "2019-01-11T11:09:53", "name": "test: media_device: Add link handling test", "version": 1, "mbox": "https://patchwork.libcamera.org/series/67/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/201/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/201/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF98F60B32\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Jan 2019 12:09:54 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 6B4CF1C0002;\n\tFri, 11 Jan 2019 11:09:54 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 11 Jan 2019 12:09:54 +0100", "Message-Id": "<20190111110956.14812-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190111110956.14812-1-jacopo@jmondi.org>", "References": "<20190111110956.14812-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] test: media_device: Make\n\tMediaDeviceTest a MediaDevicePrintTest", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 11 Jan 2019 11:09:55 -0000" }, "content": "As a new class for test link handling will be added as a separate test,\nit makes no sense to have a generic \"MediaDeviceTest\" class. Rename it\nin \"MediaDevicePrintTest\", and make it run only printing test.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n ...e_test.cpp => media_device_print_test.cpp} | 31 +++++++++----------\n test/media_device/meson.build | 9 +++---\n 2 files changed, 19 insertions(+), 21 deletions(-)\n rename test/media_device/{media_device_test.cpp => media_device_print_test.cpp} (79%)", "diff": "diff --git a/test/media_device/media_device_test.cpp b/test/media_device/media_device_print_test.cpp\nsimilarity index 79%\nrename from test/media_device/media_device_test.cpp\nrename to test/media_device/media_device_print_test.cpp\nindex c482b2e..9746afa 100644\n--- a/test/media_device/media_device_test.cpp\n+++ b/test/media_device/media_device_print_test.cpp\n@@ -1,10 +1,8 @@\n /* SPDX-License-Identifier: GPL-2.0-or-later */\n /*\n- * Copyright (C) 2018, Google Inc.\n+ * Copyright (C) 2019, Google Inc.\n *\n- * media_device_test.cpp - Tests for the media device class.\n- *\n- * Test library for the media device class.\n+ * media_device_print_test.cpp - Print out media devices\n */\n #include <iostream>\n \n@@ -20,16 +18,16 @@ using namespace libcamera;\n using namespace std;\n \n /*\n- * MediaDeviceTest object: runs a sequence of tests on all media\n- * devices found in the system.\n+ * MediaDevicePrintTest takes all media devices found in the system and print\n+ * them out to verify correctness.\n *\n * If no accessible media device is found, the test is skipped.\n */\n-class MediaDeviceTest : public Test\n+class MediaDevicePrintTest : public Test\n {\n public:\n-\tMediaDeviceTest() { }\n-\t~MediaDeviceTest() { }\n+\tMediaDevicePrintTest() { }\n+\t~MediaDevicePrintTest() { }\n \n protected:\n \tint init() { return 0; }\n@@ -44,7 +42,7 @@ private:\n \tvoid printNode(const MediaPad *pad, ostream &os);\n };\n \n-void MediaDeviceTest::printNode(const MediaPad *pad, ostream &os)\n+void MediaDevicePrintTest::printNode(const MediaPad *pad, ostream &os)\n {\n \tconst MediaEntity *entity = pad->entity();\n \n@@ -52,7 +50,7 @@ void MediaDeviceTest::printNode(const MediaPad *pad, ostream &os)\n \t << pad->index() << \"]\";\n }\n \n-void MediaDeviceTest::printLinkFlags(const MediaLink *link, ostream &os)\n+void MediaDevicePrintTest::printLinkFlags(const MediaLink *link, ostream &os)\n {\n \tunsigned int flags = link->flags();\n \n@@ -68,7 +66,7 @@ void MediaDeviceTest::printLinkFlags(const MediaLink *link, ostream &os)\n * For each entity in the media graph, printout links directed to its sinks\n * and source pads.\n */\n-void MediaDeviceTest::printMediaGraph(const MediaDevice &media, ostream &os)\n+void MediaDevicePrintTest::printMediaGraph(const MediaDevice &media, ostream &os)\n {\n \tos << \"\\n\" << media.driver() << \" - \" << media.devnode() << \"\\n\\n\";\n \n@@ -110,7 +108,7 @@ void MediaDeviceTest::printMediaGraph(const MediaDevice &media, ostream &os)\n }\n \n /* Test a single media device. */\n-int MediaDeviceTest::testMediaDevice(const string devnode)\n+int MediaDevicePrintTest::testMediaDevice(const string devnode)\n {\n \tMediaDevice dev(devnode);\n \tint ret;\n@@ -134,9 +132,8 @@ int MediaDeviceTest::testMediaDevice(const string devnode)\n \tif (ret)\n \t\treturn ret;\n \n-\t/* Run tests in sequence. */\n+\t/* Print out the media graph. */\n \tprintMediaGraph(dev, cerr);\n-\t/* TODO: add more tests here. */\n \n \tdev.close();\n \n@@ -145,7 +142,7 @@ int MediaDeviceTest::testMediaDevice(const string devnode)\n \n /* Run tests on all media devices. */\n #define MAX_MEDIA_DEV 256\n-int MediaDeviceTest::run()\n+int MediaDevicePrintTest::run()\n {\n \tconst string devnode(\"/dev/media\");\n \tunsigned int i;\n@@ -171,4 +168,4 @@ int MediaDeviceTest::run()\n \treturn ret;\n }\n \n-TEST_REGISTER(MediaDeviceTest);\n+TEST_REGISTER(MediaDevicePrintTest);\ndiff --git a/test/media_device/meson.build b/test/media_device/meson.build\nindex a7ebed1..e279470 100644\n--- a/test/media_device/meson.build\n+++ b/test/media_device/meson.build\n@@ -1,5 +1,6 @@\n-media_device_test = executable('media_device_test', 'media_device_test.cpp',\n- link_with : test_libraries,\n- include_directories : test_includes_internal)\n+media_device_print_test = executable('media_device_print_test',\n+\t\t\t\t 'media_device_print_test.cpp',\n+\t\t\t\t link_with : test_libraries,\n+\t\t\t\t include_directories : test_includes_internal)\n \n-test('Media Device Test', media_device_test)\n+test('Media Device Print Test', media_device_print_test)\n", "prefixes": [ "libcamera-devel", "1/3" ] }