Patch Detail
Show a patch.
GET /api/patches/20075/?format=api
{ "id": 20075, "url": "https://patchwork.libcamera.org/api/patches/20075/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20075/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240519175650.17316-1-laurent.pinchart@ideasonboard.com>", "date": "2024-05-19T17:56:50", "name": "ipa: rpi: Make monoSensor() accessor const", "commit_ref": "807119d1e0d27ffe50b10ccfc6ee7bf64ea03e74", "pull_url": null, "state": "accepted", "archived": false, "hash": "f231bfeef7fef0a29291c7f1c251f018be28e71d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20075/mbox/", "series": [ { "id": 4316, "url": "https://patchwork.libcamera.org/api/series/4316/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4316", "date": "2024-05-19T17:56:50", "name": "ipa: rpi: Make monoSensor() accessor const", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4316/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20075/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20075/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE987BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 19 May 2024 17:57:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4BFA6347E;\n\tSun, 19 May 2024 19:56:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73A4463469\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 May 2024 19:56:58 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C8F7581\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 May 2024 19:56:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tXX7fZF/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716141407;\n\tbh=6KjVALe29udhp9DwH2vSPRueHuWIHoWv/2Wak/Pqiws=;\n\th=From:To:Subject:Date:From;\n\tb=tXX7fZF/UO6k3hqeXibyHQeze5eIp9nEz2r5KMOfvhBnFVpxIWYIR/BM/ulKU5sLK\n\tuLv/kvzIVmiGGIqr/I4ulO9P/ghvYFlnKQexoWXAjurg6C592DXWVg+dLWENrsotmj\n\ty4tUfCxHUj0IVBFIrrahTlaACjoxMFMTDeUcxhEQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] ipa: rpi: Make monoSensor() accessor const", "Date": "Sun, 19 May 2024 20:56:50 +0300", "Message-ID": "<20240519175650.17316-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ipa::RPi::IpaBase::monoSensor() function doesn't modify the class.\nMake it const.\n\nFixes: 2031e2f29014 (\"ipa: rpi: Add accessor function for monoSensor_\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rpi/common/ipa_base.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: aee16c06913422a0ac84ee3217f87a9795e3c2d9", "diff": "diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex a95cda1ffe51..1a811beb31f2 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -49,7 +49,7 @@ public:\n \tvoid processStats(const ProcessParams ¶ms) override;\n \n protected:\n-\tbool monoSensor()\n+\tbool monoSensor() const\n \t{\n \t\treturn monoSensor_;\n \t}\n", "prefixes": [] }