Patch Detail
Show a patch.
GET /api/patches/20068/?format=api
{ "id": 20068, "url": "https://patchwork.libcamera.org/api/patches/20068/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20068/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240519081539.29832-4-umang.jain@ideasonboard.com>", "date": "2024-05-19T08:15:38", "name": "[3/4] libcamera: rkisp1: Add base class DW100 dewarper", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b5b3de95566e5d8799f00d01af6d2d17d23926df", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20068/mbox/", "series": [ { "id": 4314, "url": "https://patchwork.libcamera.org/api/series/4314/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4314", "date": "2024-05-19T08:15:35", "name": "libcamera: rkisp1: Plumb i.MX8MP DW100 dewarper", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4314/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20068/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20068/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7EFDC322E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 19 May 2024 08:15:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D4E563487;\n\tSun, 19 May 2024 10:15:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3CD16347E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 19 May 2024 10:15:52 +0200 (CEST)", "from fedora.local (unknown\n\t[IPv6:2405:201:2015:f873:9278:2c85:fd02:c5f5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 33CC25A4;\n\tSun, 19 May 2024 10:15:40 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LB24mn24\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716106542;\n\tbh=PtQWX2WM8kD2tTj/2w3Z0x26CvwoXAMHITfpkjO/VkI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=LB24mn24bKs6F1AAC7caJ83XZVAk9IdPI+5W0GJx/Jz4OiBPYZxGB3tvY34FnUk+/\n\tRlRFOSjByqD/BlE0EKjSnjNbFltpfNjKub0RGON8lU5G/FX8jeUGD9myKp0+pGDiFJ\n\tcplRWgt/fydxac1NY5smtYhy9xTS4MC95wf/eDXo=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH 3/4] libcamera: rkisp1: Add base class DW100 dewarper", "Date": "Sun, 19 May 2024 13:45:38 +0530", "Message-ID": "<20240519081539.29832-4-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240519081539.29832-1-umang.jain@ideasonboard.com>", "References": "<20240519081539.29832-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "DW100 Dewarp engine is present on I.MX8MP SoC. This patch\nprovides a base RkISP1Dewarper class (inherited from V4L2M2MConverter)\nwhich then can be used to load a dewarp config file and scaling\ncapabilites.\n\n\\todo: Add plumbing to load a vertex map on top\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/meson.build | 1 +\n .../pipeline/rkisp1/rkisp1_dewarper.cpp | 38 +++++++++++++++++++\n .../pipeline/rkisp1/rkisp1_dewarper.h | 25 ++++++++++++\n 3 files changed, 64 insertions(+)\n create mode 100644 src/libcamera/pipeline/rkisp1/rkisp1_dewarper.cpp\n create mode 100644 src/libcamera/pipeline/rkisp1/rkisp1_dewarper.h", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/meson.build b/src/libcamera/pipeline/rkisp1/meson.build\nindex cad66535..e8a989b1 100644\n--- a/src/libcamera/pipeline/rkisp1/meson.build\n+++ b/src/libcamera/pipeline/rkisp1/meson.build\n@@ -2,5 +2,6 @@\n \n libcamera_sources += files([\n 'rkisp1.cpp',\n+ 'rkisp1_dewarper.cpp',\n 'rkisp1_path.cpp',\n ])\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1_dewarper.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_dewarper.cpp\nnew file mode 100644\nindex 00000000..0bd72497\n--- /dev/null\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_dewarper.cpp\n@@ -0,0 +1,38 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#include \"rkisp1_dewarper.h\"\n+\n+#include <libcamera/base/log.h>\n+\n+#include <libcamera/geometry.h>\n+\n+#include \"libcamera/internal/media_device.h\"\n+#include \"libcamera/internal/v4l2_videodevice.h\"\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(RkISP1)\n+\n+RkISP1Dewarper::RkISP1Dewarper(std::shared_ptr<MediaDevice> media)\n+\t: V4L2M2MConverter(media.get())\n+{\n+}\n+\n+int RkISP1Dewarper::setScalerCrop(unsigned int output, Rectangle rect)\n+{\n+\tint ret;\n+\n+\tret = setSelection(output, V4L2_SEL_TGT_CROP, &rect);\n+\tif (ret < 0)\n+\t\tLOG(RkISP1, Error) << \"Failed to set scaler crop on dewarper \"\n+\t\t\t\t << strerror(-ret);\n+\n+\treturn ret;\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1_dewarper.h b/src/libcamera/pipeline/rkisp1/rkisp1_dewarper.h\nnew file mode 100644\nindex 00000000..600e35bd\n--- /dev/null\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_dewarper.h\n@@ -0,0 +1,25 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ *i.MX8MP Dewarp Engine integration\n+ */\n+\n+#pragma once\n+\n+#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n+\n+namespace libcamera {\n+\n+class Rectangle;\n+struct MediaDevice;\n+\n+class RkISP1Dewarper : public V4L2M2MConverter\n+{\n+public:\n+\tRkISP1Dewarper(std::shared_ptr<MediaDevice> media);\n+\n+\tint setScalerCrop(unsigned int output, Rectangle rect);\n+};\n+\n+} /* namespace libcamera */\n", "prefixes": [ "3/4" ] }