Patch Detail
Show a patch.
GET /api/patches/20019/?format=api
{ "id": 20019, "url": "https://patchwork.libcamera.org/api/patches/20019/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20019/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240508115249.4182914-1-kieran.bingham@ideasonboard.com>", "date": "2024-05-08T11:52:49", "name": "[1/2] fixup! ipa: libipa: Add AgcMeanLuminance base class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "97454f6bd7417c23a4a8cb611d849df96ce0395d", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20019/mbox/", "series": [ { "id": 4295, "url": "https://patchwork.libcamera.org/api/series/4295/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4295", "date": "2024-05-08T11:52:49", "name": "[1/2] fixup! ipa: libipa: Add AgcMeanLuminance base class", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4295/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20019/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20019/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDECFBDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 May 2024 11:53:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 07BE962C9F;\n\tWed, 8 May 2024 13:53:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AED4961A73\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 May 2024 13:53:00 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97253B0B;\n\tWed, 8 May 2024 13:52:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hN6xYV9b\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715169177;\n\tbh=7Jx5+njQ3Xzit6jAEbBDBUjAfIo/McX+bzSu2l3KLP0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hN6xYV9bJbTCnT0hFGoTfCjkMsyTsswQYRx4uLz9ImgmXwQcgGGgcpLhL3nhqs/Ex\n\tTGlKLODlz+fqxIpuk+zPonM+EqMzIa9kQyf6hPSqT2QcgnuK6n/PPuotCIDvNO8BAt\n\t8bEiznfQkDQrDTHY9cDx/nm4nunBPNBBSNDPUPgk=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 1/2] fixup! ipa: libipa: Add AgcMeanLuminance base class", "Date": "Wed, 8 May 2024 12:52:49 +0100", "Message-Id": "<20240508115249.4182914-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240502133046.1976565-5-dan.scally@ideasonboard.com>", "References": "<20240502133046.1976565-5-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "I will apply this series with the following fixup.\n\nFixes:\n\nFAILED: src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o \nclang++ -Isrc/ipa/libipa/libipa.a.p -Isrc/ipa/libipa -I../src/ipa/libipa -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O0 -g -stdlib=libc++ -Wextra-semi -Wthread-safety -Wshadow -include /builds/camera/libcamera/build/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o -MF src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o.d -o src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o -c ../src/ipa/libipa/agc_mean_luminance.cpp\nIn file included from ../src/ipa/libipa/agc_mean_luminance.cpp:8:\n../src/ipa/libipa/agc_mean_luminance.h:94:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]\n}; /* namespace ipa */\n ^\n../src/ipa/libipa/agc_mean_luminance.h:96:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]\n}; /* namespace libcamera */\n ^\n../src/ipa/libipa/agc_mean_luminance.cpp:575:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]\n}; /* namespace ipa */\n ^\n../src/ipa/libipa/agc_mean_luminance.cpp:577:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]\n}; /* namespace libcamera */\n ^\n4 errors generated.\n\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 4 ++--\n src/ipa/libipa/agc_mean_luminance.h | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex 004d84d8c5d8..2bf84d05b6dd 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -572,6 +572,6 @@ AgcMeanLuminance::calculateNewEv(uint32_t constraintModeIndex,\n * their configure() function.\n */\n \n-}; /* namespace ipa */\n+} /* namespace ipa */\n \n-}; /* namespace libcamera */\n+} /* namespace libcamera */\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex ef8ba28fd6ab..0a81c6d285b8 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -91,6 +91,6 @@ private:\n \tControlInfoMap::Map controls_;\n };\n \n-}; /* namespace ipa */\n+} /* namespace ipa */\n \n-}; /* namespace libcamera */\n+} /* namespace libcamera */\n", "prefixes": [ "1/2" ] }