Patch Detail
Show a patch.
GET /api/patches/20007/?format=api
{ "id": 20007, "url": "https://patchwork.libcamera.org/api/patches/20007/?format=api", "web_url": "https://patchwork.libcamera.org/patch/20007/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240507181607.32538-1-laurent.pinchart@ideasonboard.com>", "date": "2024-05-07T18:16:07", "name": "Revert \"meson: Deprecate bitwise operations between different enumeration type\"", "commit_ref": "ea1e9eba748c5a4068ba2edffebf31fb2bafa923", "pull_url": null, "state": "accepted", "archived": false, "hash": "c81c59af0e921369b5611a5c2aa582e89562d4e2", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/20007/mbox/", "series": [ { "id": 4291, "url": "https://patchwork.libcamera.org/api/series/4291/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4291", "date": "2024-05-07T18:16:07", "name": "Revert \"meson: Deprecate bitwise operations between different enumeration type\"", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4291/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/20007/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/20007/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4B29BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 May 2024 18:16:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF1726342D;\n\tTue, 7 May 2024 20:16:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7855A633E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 May 2024 20:16:15 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3330904\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 May 2024 20:16:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pRorN29U\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715105773;\n\tbh=yuNVIfLP1s1I2s/OOUX8ZLQv1FV9i0r6viEdQcSvAbU=;\n\th=From:To:Subject:Date:From;\n\tb=pRorN29UrsK4nT92TNWkqTgXxoPNMmKipcS3aL7Xaoo3a2oH2kr/McpbA+/JX9Ibq\n\tt/TH8jU+ylzK6ohq2fVNFZWEa6pMwOA9w7tmu3X03Nacw3tapFhyNagdanaeYnYEST\n\tYwxg97cjy9atWy9/cJoIrdiGA3J6GxXsdsb2ymqs=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] Revert \"meson: Deprecate bitwise operations between\n\tdifferent enumeration type\"", "Date": "Tue, 7 May 2024 21:16:07 +0300", "Message-ID": "<20240507181607.32538-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Enabling -Wdeprecated-enum-enum-conversion by default turned out to be a\ntoo hasty decision. It causes compilation failures with Qt headers prior\nto Qt v5.15.8. As the previous LTS versions of Debian and Ubuntu ship\nolder Qt versions, those errors cause real inconvenience to users.\n\nThis reverts commit bf4695266bfca8cc21bcf10a3281e874ebce0d27.\n\nThe original goal of avoiding C++20 compilation regressions is still\nhandled through a test in CI.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 9 ---------\n 1 file changed, 9 deletions(-)\n\n\nbase-commit: bf4695266bfca8cc21bcf10a3281e874ebce0d27", "diff": "diff --git a/meson.build b/meson.build\nindex 89320adbde1f..39e4947f8c97 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -178,15 +178,6 @@ if cc.has_argument('-Wno-c99-designator')\n ]\n endif\n \n-# Enable the C++20 deprecated enum-enum conversion warning if the compiler\n-# supports it. This helps avoiding C++20 regressions, and should be removed\n-# when switching to C++20 as the warning will then be enabled by default.\n-if cxx.has_argument('-Wdeprecated-enum-enum-conversion')\n- cpp_arguments += [\n- '-Wdeprecated-enum-enum-conversion',\n- ]\n-endif\n-\n c_arguments += common_arguments\n cpp_arguments += common_arguments\n \n", "prefixes": [] }