Patch Detail
Show a patch.
GET /api/patches/19999/?format=api
{ "id": 19999, "url": "https://patchwork.libcamera.org/api/patches/19999/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19999/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240503144919.2371357-3-julien.vuillaumier@nxp.com>", "date": "2024-05-03T14:49:18", "name": "[v4,2/3] libcamera: pipeline: Add a get factory by name helper", "commit_ref": "353ccef1437df142059da12dd154e426ce5464ee", "pull_url": null, "state": "accepted", "archived": false, "hash": "e19ec5902a1711aac04342ae8bac990e7c7c145b", "submitter": { "id": 190, "url": "https://patchwork.libcamera.org/api/people/190/?format=api", "name": "Julien Vuillaumier", "email": "julien.vuillaumier@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19999/mbox/", "series": [ { "id": 4287, "url": "https://patchwork.libcamera.org/api/series/4287/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4287", "date": "2024-05-03T14:49:16", "name": "Add environment variable to order pipelines match", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4287/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19999/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19999/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9A7EC328F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 May 2024 14:50:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24B7F63421;\n\tFri, 3 May 2024 16:50:00 +0200 (CEST)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n\t(mail-vi1eur04on20600.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2611::600])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E72B863415\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 May 2024 16:49:57 +0200 (CEST)", "from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)\n\tby PAXPR04MB9570.eurprd04.prod.outlook.com (2603:10a6:102:24d::20)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.30;\n\tFri, 3 May 2024 14:49:56 +0000", "from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::eace:e980:28a4:ef8a]) by\n\tAM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::eace:e980:28a4:ef8a%2]) with mapi id 15.20.7544.029;\n\tFri, 3 May 2024 14:49:56 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"jYSQ9Yhy\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n\tb=RRkaZunwfjpXcXZZ9zpz2g18dPJDUD/Oib8xDdiwSNM3Y2s6rU4tbQVjwsfdQm7B90UER7TiojKgkTQzVINd5iX7fYHQqtj5/uyuqqJdiXq/cqc3PgauHWsYHOzkuSubRKEcrtljsAg5EwkuVgumzu7sFoJuYkYzi5oOC/CzeC3OoAVXLksfviAYd55mv4rwIGcIXHPObDjak/KiPB0z5ukQaWLY3uOqq5nJOvev/eucbDOQA+qXweLlWeJ3CD3tWB1sM4Q+4e+keucNVeVzzas1hmXceTJhdeW4vqJ2xRAo6mlaI1e/TyhhuzaJFGis6Xecn8vARnE2sPryA61rYg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector9901;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=N56hWJanKO/y8R0j6yqApG+ySITioz6QcoDFpy92nzk=;\n\tb=dO+kcnxi6o/5UbUinUAVvAQymQHQ+46VoUwJXDZNMgwnyMh/0LW4ZciTgHLt6p8WS6hczdExfy0P0Y7Z2nUwMI1X29ONltOCPAXmfTeIEjbQo8aNEBQ3Z7QP7HawOs8lpCPxB8J9T2vd/KogVYyoWegodUHN2ZQAVK39Vw+PpVSAc0Er0fePiR81WjcM3QIb9Kz6RroCvwcbLmbvvyXR7jNFLnYfGWNYRY3RqK34tLwpk3enB394IjgsI/FUnO/Bob45W5TIBXtiybF+IrTBy3shmtFQGpTGjTpzhN8feoF2KRECYx9aVclM9mGuPtl6OwR+cVKLBq1KnLxbwlzNYw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=N56hWJanKO/y8R0j6yqApG+ySITioz6QcoDFpy92nzk=;\n\tb=jYSQ9Yhy5o8ABoVZokuq3z8L9HYYW+BNDUW6MXAAsi457rPg6vOTmEBzwEiitcxfJICRq2mO3HEqssvho84Naah07XYV+78ElyUyPGnqlY1abQfdOBphernFBkknVLvIwjJcNwMH0oCn2eJMCATPZ/jGfsVW1ypi4TnL27jxsDc=", "From": "Julien Vuillaumier <julien.vuillaumier@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "jacopo.mondi@ideasonboard.com, kieran.bingham@ideasonboard.com,\n\tjulien.vuillaumier@nxp.com", "Subject": "[PATCH v4 2/3] libcamera: pipeline: Add a get factory by name helper", "Date": "Fri, 3 May 2024 16:49:18 +0200", "Message-Id": "<20240503144919.2371357-3-julien.vuillaumier@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240503144919.2371357-1-julien.vuillaumier@nxp.com>", "References": "<20240503144919.2371357-1-julien.vuillaumier@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM0PR03CA0003.eurprd03.prod.outlook.com\n\t(2603:10a6:208:14::16) To AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM9PR04MB8147:EE_|PAXPR04MB9570:EE_", "X-MS-Office365-Filtering-Correlation-Id": "360b2312-bfe4-404c-9714-08dc6b804c84", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230031|52116005|1800799015|376005|366007|38350700005; ", "X-Microsoft-Antispam-Message-Info": "VKStP8b0U3sjyHHuofKpy4CoETsehuP4vUryvFp9sbrcR1HFsIQkGYbXoWXE+ODNgeNtygqYu+OpEEmny/a7qqDyeUGl4E5DpS2uzwaaMUK2rEawd8Gz1TQxIcgo+6y6ffQELyzGPzCt4kAxA9ZWWhPThKMzJHdtILnVvjm1NcFcJ/sC2cCiHP7lWPtZRPe9ja+XgGkgP87KTG5OFs04Bq6Qvsf9Rey/fQCDrysg93udhh+WUPiA2hRCY9sVq7aJRAM2/3E2S4DCb1OOQjFxSjaoWjncA+Ovp7dGHICnAs9JmRRHiaakSPBMqdohm6BQpkSkmTH3wGnR2Qtdgk/oLokU2XOUAmge5ZdNAjvwo3wQ9qBGVITLphrqWuNHrBb7zT/oRS/XElRenN5aszL0HP7mKJ0S18tY015+YkGuGpfQD8hYMrEsQsNVX168q1sBxiaN9aFtv0M4cYYoaGPtOgUQyI4xpUA+sgQmpfIdrreQA5K6Nz5IY/G4ScwM2spsq7DrcIt2+14SdzKcSt/nz7MhTSQLag5OzMVqO+h+kMqB9DdapzSoOqOW5pVY8vqFV+TQCz1HAgXoz0+Cl26TuUh358wSFZqOYa9uufbQ3GVvl5MEl7+fUd3gXygGdC18YTq7SAjBpiE7PBtGpn2XlRQ0YZKOftSSf2bpLG27s0GjRTFwhgKl5tco2p/ZdLqyyezDROQf3NvHo6ymmK7GxW5obXrQWpSMSwyoL+o5CzEniYTy0BR/P4EG0fFyqOTWhe9kn/+jVTeMJ7PEO7VJO11oaNlbVmdJLqyo133i0xgXTngzYBmQv8zMe8R4GqvRNapWOtwpM+JeGGTDsdhSaQzvOJpn2zULruBW6zOHGawddv2DPHMicghtKHHWfddk7OupeTOI15JFgM5BV0CR77c7neMbjdoKliAihByGCT1uublR/0fSz+emiB6Nc6w5gK248Nd25u1TtDze5dHmn6A0ReJCKEnHzBiEZhimeKE+haHwxkKC+pWd5h7mCyP6ykcpy2rxZkZHnRKfWddbqQYMpsiP2O9aW9ruTJECZwpfQr6jy0G/KQmvVkUDRcx2lqk7rvSK6aHZlT0Jy7D079Y5akZVEhWmX1eyfjuGRs6ZcwxuZ1YhPdkuosVDMgKO8Y7nz2x6vYp0hE59OHDsJHcrBgwPq/9kWZX2Xa66meTN09bzdJ2DSLlTaTH2eWGfzhSj8DFy2++qBDIPB+lgDGvxLIfr/VjJq5+WtOE1dYqVBt3xiuk1rSNesqpbC+ZGM5RbH8LPdZK/JrW7RmpprEAdEz/gBIQ5KoaSjtzEvYg9U8rkZtCIWVZJwyjqT3sbte6Jh0s1bhmLDgJ9mJprjg==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AM9PR04MB8147.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230031)(52116005)(1800799015)(376005)(366007)(38350700005);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "XK2Kq+dUoBCniJYlhicLvg9sFegM8kS4Ij+sTgfW86nhCLTg8pXoAxE5Ah+DKpRvBK+vBx+3m+A83oHZZ66zvTB+qSN9E/Dfiz8IEr998yp1q0IDmiTx7TQ33nQEoe1fuaOwEBw3yVmKb3b7x+G4BQkcMPey+ve7SwJwoaOxf04OSrWkiuZIDlR8m7hJc8iq2M2/3g9cs6t+V9uroXxoUAmn8q/YAzqYz1KxqXVFVQfEI7Ry9zykVtClU+0OBMl3RBHlxAmKd+m7bZTubZVJQ6MEc+eKVX5jofkhyZ4K0T5epxsSdZ/x1QCJP/1qbl7ZNTqj95oprzJdXj3xiiB84jvLU87wJ34nnBtArCIEVLejsvEPPOTWAtN94QazjEZ1FG8M3G+q0VwVnKx0j34QPN4CZHnZwB5iDoovTvGD4uxGqJXbtCIl8/wZU0OeE31VWAq+o63kKPDI9zCr8oT99klWO27CiY0/HJzjM1/kduK4SVHvodgBCw64YXWevIc+kduDmkS4wcSJG5Koi+78Knt3SxPHrL2osM/RTT1ZEVXEwlWhlXKnnXfkl7UYXNkFaDVu8c+6woC6sVAUZNHJG/I0vmffhUpJSjYAOaFOihQg/Kflho+pS8WjQJrhOrfh/vTiRc+6E0t+8gfpLzt1qg+SUquqzuRCy1jFFKPM5ewjkV6Mos1qONCHMgf42MPw+3aGI4sg/qhnLSLRvWd/gN+PO0Q5XClFhtVQYsX1KYPaQRkvC8hZ35OqL9TTGPuOxaNbm5+jszxnsNKhfW4SsAzjbRVoqbs3FqLww7hprGnGqZctyq4zZYnQdmTQuF1NLN5hQPxilwRHP+eJpv05cuMyI2WW/eHmhnZaX7t4k/S9TrFP2rNzh3vGSUax0yN0drMyvPb4tbajCqihEiuYMI0nu2Hq8FygaG3XzCYjugXSDT+/9sOqIGWMVFo4pNOQ/4eUZoV+vdaHChAFe/PqfhBM/5tulrFkFOVgTfRirxdZDix+VDV48sQjDfiReukAJZ4rltoKcep1SlDeMYme2elMecU3ZVbCtfxloOasVg/CBK5m2CtIKqzTZ251qs4/fZIJ5SdGCRD0FyopOv8GZwW5ngtjLAJ7JHyo0mTP2CcVGpxVo8R0pD8qR5ZfVJLk6e+rBCDzf7dJYP1WsJfK/biYagN6n0RglPiXxTvnIoz3Qg/qMN0OyGmeADMmnmZapHTPujQ678t0CueF7M1rMQ9PNOsnKqT69SZcdjC1jej6Yi/R2nYOGJ+TVkKGAuk8z98VRVcFaNFUkhIsyWCEYvIvgHP5bymoKVm+BFH4/lz1siacNXoTizxBf1x3XIEh3sYItoerqRPxQIW9j4/ItCSLiGkE+xkrjACRQwaGl0KJ8SLPvjTw6IV7/BigHyOXUrvHj1wEhDHoiXATKPv8A6RN6jBAPB2IbOLQ3XC89mu7xUA2LFqVTWubAwp/curl4bEQNyrevX1Ez0czWuAqBH7r99IKvuHJnCdeu0J0PAvtfIbHTvwirs3VlyRo8GyxVrUbpVmIC6ze6IMm3+B9IFj5wbvsVib20ptprKjv3kobwR9uGY940/ZD6XiIrF7qSsb5U3tforxqzSrbTpOdYA==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "360b2312-bfe4-404c-9714-08dc6b804c84", "X-MS-Exchange-CrossTenant-AuthSource": "AM9PR04MB8147.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 May 2024 14:49:56.4543\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "vqB+G7EL5WE9mwn3aFzEgW2cOunGkBvFgXkxkOeKFMHvf4mXVvMo9a93QVQN0NSCdg/zWH1Y7KuNC3pbpTiHRtRD/gQcVfBT4lov6oxKlDU=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PAXPR04MB9570", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a static helper to the PipelineHandlerFactoryBase class to\nallow retrieving a pipeline by name.\n\nSigned-off-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/pipeline_handler.h | 1 +\n src/libcamera/pipeline_handler.cpp | 22 +++++++++++++++++++\n 2 files changed, 23 insertions(+)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex cc70f69c..67d5164f 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -114,6 +114,7 @@ public:\n \tconst std::string &name() const { return name_; }\n \n \tstatic std::vector<PipelineHandlerFactoryBase *> &factories();\n+\tstatic const PipelineHandlerFactoryBase *getFactoryByName(const std::string &name);\n \n private:\n \tstatic void registerType(PipelineHandlerFactoryBase *factory);\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 0c913e50..de5097e1 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -794,6 +794,28 @@ std::vector<PipelineHandlerFactoryBase *> &PipelineHandlerFactoryBase::factories\n \treturn factories;\n }\n \n+/**\n+ * \\brief Return the factory for the pipeline handler with name \\a name\n+ * \\param[in] name The pipeline handler name\n+ * \\return The factory of the pipeline with name \\a name, or nullptr if not found\n+ */\n+const PipelineHandlerFactoryBase *PipelineHandlerFactoryBase::getFactoryByName(const std::string &name)\n+{\n+\tconst std::vector<PipelineHandlerFactoryBase *> &factories =\n+\t\tPipelineHandlerFactoryBase::factories();\n+\n+\tauto iter = std::find_if(factories.begin(),\n+\t\t\t\t factories.end(),\n+\t\t\t\t [&name](const PipelineHandlerFactoryBase *f) {\n+\t\t\t\t\t return f->name() == name;\n+\t\t\t\t });\n+\n+\tif (iter != factories.end())\n+\t\treturn *iter;\n+\n+\treturn nullptr;\n+}\n+\n /**\n * \\class PipelineHandlerFactory\n * \\brief Registration of PipelineHandler classes and creation of instances\n", "prefixes": [ "v4", "2/3" ] }