Patch Detail
Show a patch.
GET /api/patches/19996/?format=api
{ "id": 19996, "url": "https://patchwork.libcamera.org/api/patches/19996/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19996/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240503124420.2043486-1-alexander.stein@ew.tq-group.com>", "date": "2024-05-03T12:44:20", "name": "[1/1] libcamera: libipa: camera_sensor: Add Sony IMX415 sensor properties", "commit_ref": "7235248d38434f4c3e8a163ab03637ac115bdda8", "pull_url": null, "state": "accepted", "archived": false, "hash": "cb1ea123722ab48776112c6883abb1b4bb07017c", "submitter": { "id": 194, "url": "https://patchwork.libcamera.org/api/people/194/?format=api", "name": "Alexander Stein", "email": "alexander.stein@ew.tq-group.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19996/mbox/", "series": [ { "id": 4286, "url": "https://patchwork.libcamera.org/api/series/4286/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4286", "date": "2024-05-03T12:44:20", "name": "[1/1] libcamera: libipa: camera_sensor: Add Sony IMX415 sensor properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4286/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19996/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19996/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2455DBDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 May 2024 13:07:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28B3B6340B;\n\tFri, 3 May 2024 15:07:46 +0200 (CEST)", "from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A23461A8A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 3 May 2024 14:44:29 +0200 (CEST)", "from vmailcow01.tq-net.de ([10.150.86.48])\n\tby mx1.tq-group.com with ESMTP; 03 May 2024 14:44:28 +0200", "from [127.0.0.1] (localhost [127.0.0.1]) by localhost\n\t(Mailerdaemon)\n\twith ESMTPSA id 31FA117331D; Fri, 3 May 2024 14:44:24 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=tq-group.com header.i=@tq-group.com\n\theader.b=\"AEIeCxne\"; \n\tdkim=fail reason=\"key not found in DNS\" (0-bit key;\n\tunprotected) header.d=ew.tq-group.com header.i=@ew.tq-group.com\n\theader.b=\"r744riyk\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1;\n\tt=1714740269; x=1746276269;\n\th=from:to:cc:subject:date:message-id:mime-version:\n\tcontent-transfer-encoding;\n\tbh=CybFSi57ZqACHqEWd5efuOtT9h5ojp7K6c/Td4ZBAUg=;\n\tb=AEIeCxneUsaFUal9KUIjFx2/dHP1DlmvMHd0FJhhIrHSVntnknf7zD1x\n\tdQ5isaKNltM7sInaF5R8lipzcf22XSpTmuKVdQksNqACcQFHqbx9KNl28\n\t/8Ftc/ZFOzKiY11GzBbetXbe79GTqxU80bdS27KSzJ05EhlM/WdZi+3mW\n\tSg85nZEMv/+glLKZVxtnhv59Oz8EDmVpAsPV7GbdFUWMQcPvOtvBC3vPu\n\tcVun26yClz5w0CX9jAQubHl9uOmZpMuoK5JkvvD21fIXJL1Tiok7e+Uz4\n\tOXgR+Eo3k7ofwW0OGrGgRP5qTC9zthO5smH4oagAFYzN/gaxsAzbavgrn g==;", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com;\n\ts=dkim; t=1714740264;\n\th=from:subject:date:message-id:to:cc:mime-version:\n\tcontent-transfer-encoding;\n\tbh=CybFSi57ZqACHqEWd5efuOtT9h5ojp7K6c/Td4ZBAUg=; \n\tb=r744riykfursyGTbbRWU8Wtvhg1ROiHZGB6p0bAHD9S/OIEsdWr4iopwQUNi1/wQYxK95H\n\tUVPWSLeGW11uEimSN8xGpisaGVSIY/UrAv3ev1gCRDl6baX3xFSXIR17LFnMtNBpUQU1VM\n\tJoOoDsvZ08dNstKZlzqA4ZFzW/IfHXezt+lmzSNys+7y3hXiIFhnouk945YXpoz/2jsjui\n\tXPglqjV8x7+/nF5Mw5RrjFAdrEnnn2PIoSojQClQIWjRWCNg/wYDNt/k0Wtfwa0CutIcnR\n\tvoPpy1Wwfpd1pJkQFRHlZtsrO3lAj65R6a/GTe5Rcmi9JgwgcJB4bCjNFlXS2g==" ], "X-IronPort-AV": "E=Sophos;i=\"6.07,251,1708383600\"; d=\"scan'208\";a=\"36735888\"", "From": "Alexander Stein <alexander.stein@ew.tq-group.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Alexander Stein <alexander.stein@ew.tq-group.com>", "Subject": "[PATCH 1/1] libcamera: libipa: camera_sensor: Add Sony IMX415 sensor\n\tproperties", "Date": "Fri, 3 May 2024 14:44:20 +0200", "Message-Id": "<20240503124420.2043486-1-alexander.stein@ew.tq-group.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Last-TLS-Session-Version": "TLSv1.3", "X-Mailman-Approved-At": "Fri, 03 May 2024 15:07:44 +0200", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the Sony IMX415 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nThe test patterns exposed by the IMX415 do not map well to the current\nset of test pattern controls supplied by libcamera. These are left\nintentionally unimplemented.\n\nSigned-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>\n---\nI shamelessly used the same commit message and structure from commit\n6b1b2bd7 (\"libcamera: libipa: camera_sensor: Add Sony IMX335 sensor\nproperties\").\n\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 84d52d10..f8a497e1 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -466,6 +466,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx335\", CameraSensorHelperImx335)\n \n+class CameraSensorHelperImx415 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperImx415()\n+\t{\n+\t\tgainType_ = AnalogueGainExponential;\n+\t\tgainConstants_.exp = { 1.0, expGainDb(0.3) };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 895bf967..5c2c93e1 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -119,6 +119,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t.unitCellSize = { 2000, 2000 },\n \t\t\t.testPatternModes = {},\n \t\t} },\n+\t\t{ \"imx415\", {\n+\t\t\t.unitCellSize = { 1450, 1450 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx477\", {\n \t\t\t.unitCellSize = { 1550, 1550 },\n \t\t\t.testPatternModes = {},\n", "prefixes": [ "1/1" ] }