Patch Detail
Show a patch.
GET /api/patches/19975/?format=api
{ "id": 19975, "url": "https://patchwork.libcamera.org/api/patches/19975/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19975/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240430192620.779489-1-pobrn@protonmail.com>", "date": "2024-04-30T19:26:21", "name": "[v1] apps: cam: Fix C++20 deprecation warning", "commit_ref": "77269a28692ce683416e4e47d304bc070a721a3b", "pull_url": null, "state": "accepted", "archived": false, "hash": "6c56e5f97f1f2c0db97b3daea14d69556afe23bc", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19975/mbox/", "series": [ { "id": 4282, "url": "https://patchwork.libcamera.org/api/series/4282/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4282", "date": "2024-04-30T19:26:21", "name": "[v1] apps: cam: Fix C++20 deprecation warning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4282/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19975/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19975/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F20D5BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Apr 2024 19:26:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A36C06341A;\n\tTue, 30 Apr 2024 21:26:38 +0200 (CEST)", "from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3DB8633F3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Apr 2024 21:26:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"JUqynCbj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1714505195; x=1714764395;\n\tbh=BX3Pd0OsfhRIntEa8h7EWz3EI4d1HiD7KhBCpqr2BZ8=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=JUqynCbjoa3hzw8rQuZTvbZv/UhX57hranBiXe/2DgtCPrM58rlWWLnO4xZK14Pt4\n\tKG7DM4w5SaerfXWqIU0ryivDKf4oInEomtgrtbrJI+RSWlboiYXrw7IXPm2V9lKFZx\n\tsZ/lcUPE1Ii9VeH77fxQPsKhz0WiDe7QjC00n+ZfHbJ5H2ScOydP6UUvnaUPvb+uGt\n\t3W+ZVfZEoVL17C6IJ+iseFXFukXgmy2HT+g2++I2h/twgZG4fHil7WpdUbcVqN+t1V\n\taapyyVF4cadbX7khQPki4EutmKotd65cR1taz0IBauEm0KOS1EIsCNRkBFMbMwMaRx\n\tgo6TwG8IchGvw==", "Date": "Tue, 30 Apr 2024 19:26:21 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH v1] apps: cam: Fix C++20 deprecation warning", "Message-ID": "<20240430192620.779489-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "3a3957cfe84f53638b737ae3739a89c8f41966ca", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "C++20 deprecated implicit capture of `this` via `[=]`.\nFix that by explicitly capturing the necessary variables.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/apps/cam/camera_session.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 334d2ed8..d1f65a99 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -382,7 +382,7 @@ void CameraSession::requestComplete(Request *request)\n \t * Defer processing of the completed request to the event loop, to avoid\n \t * blocking the camera manager thread.\n \t */\n-\tEventLoop::instance()->callLater([=]() { processRequest(request); });\n+\tEventLoop::instance()->callLater([this, request]() { processRequest(request); });\n }\n \n void CameraSession::processRequest(Request *request)\n", "prefixes": [ "v1" ] }