Patch Detail
Show a patch.
GET /api/patches/19924/?format=api
{ "id": 19924, "url": "https://patchwork.libcamera.org/api/patches/19924/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19924/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240423103034.364150-11-mzamazal@redhat.com>", "date": "2024-04-23T10:30:25", "name": "[v2,10/13] config: Allow enabling software ISP in runtime", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "818f505ec65cffcfe2dc9cbf4d6ef13bce8dd644", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19924/mbox/", "series": [ { "id": 4267, "url": "https://patchwork.libcamera.org/api/series/4267/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4267", "date": "2024-04-23T10:30:15", "name": "Add global configuration file", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4267/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19924/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19924/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF873BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Apr 2024 10:31:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C734763430;\n\tTue, 23 Apr 2024 12:31:38 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46A016340D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Apr 2024 12:31:31 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-190--Tc9jtCPM-CDQcwz81qj4Q-1;\n\tTue, 23 Apr 2024 06:31:28 -0400", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 492FE3820EA7;\n\tTue, 23 Apr 2024 10:31:28 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.225.63])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5F7C31C0666A;\n\tTue, 23 Apr 2024 10:31:27 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"HzGYu+an\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1713868290;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Pf2rbdOA0GhbtzTvmoyr7iQ8XY9yPxAgWpxSVOLUbZM=;\n\tb=HzGYu+an/rNDZ9T0epjWSPkfjXGGFtbzVnOH+Ad/5gbHmD44shu3ZFbsjNqYgiYwFzUiwf\n\t/yGxH7JB4Et/FrnqwHzO3tMyjjkzq3O2Zw3B/CNuyUNMBELr541tkX8EMfzzt7c0MsaGPm\n\tpD6irc3ab4mznZ88ZYNNcA8m1pkHEzw=", "X-MC-Unique": "-Tc9jtCPM-CDQcwz81qj4Q-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v2 10/13] config: Allow enabling software ISP in runtime", "Date": "Tue, 23 Apr 2024 12:30:25 +0200", "Message-ID": "<20240423103034.364150-11-mzamazal@redhat.com>", "In-Reply-To": "<20240423103034.364150-1-mzamazal@redhat.com>", "References": "<20240423103034.364150-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patch allows enabling or disabling software ISP in runtime in\naddition to compile time. This can be useful for software ISP testing\non various platforms as well as for overriding the defaults in case the\ndefaults don't work well (e.g. hardware ISP may or may not work on\ni.MX8MP depending on the kernel and libcamera patches present in the\ngiven system).\n\nThe configuration is specified as follows:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: DRIVER-NAME\n software_isp: BOOLEAN\n - ...\n\nFor example:\n\n configuration:\n pipelines:\n simple:\n supported_devices:\n - driver: mxc-isi\n software_isp: true\n\nThe overall configuration of enabling or disabling software ISP may get\ndropped in future but this patch is still useful in the meantime.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 61a59926..1c37ee8c 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -32,6 +32,7 @@\n #include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/converter.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/software_isp/software_isp.h\"\n@@ -1545,6 +1546,17 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t}\n \n \tswIspEnabled_ = info->swIspEnabled;\n+\tfor (GlobalConfiguration::Configuration entry :\n+\t GlobalConfiguration::configuration()\n+\t\t [\"pipelines\"][\"simple\"][\"supported_devices\"]\n+\t\t\t .asList()) {\n+\t\tauto name = entry[\"driver\"].get<std::string>();\n+\t\tif (name.has_value() and !name.value().compare(info->driver)) {\n+\t\t\tswIspEnabled_ = entry[\"software_isp\"].get<bool>().value_or(swIspEnabled_);\n+\t\t\tLOG(SimplePipeline, Debug) << \"Overriding software ISP to \" << swIspEnabled_;\n+\t\t\tbreak;\n+\t\t}\n+\t}\n \n \t/* Locate the sensors. */\n \tstd::vector<MediaEntity *> sensors = locateSensors();\n", "prefixes": [ "v2", "10/13" ] }