Patch Detail
Show a patch.
GET /api/patches/19908/?format=api
{ "id": 19908, "url": "https://patchwork.libcamera.org/api/patches/19908/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19908/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240419055336.1070164-1-paul.elder@ideasonboard.com>", "date": "2024-04-19T05:53:36", "name": "[v2] ipa: libipa: histogram: Add transform parameter to constructor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "67d09ecb4e587abb5335c3fea5dd6c79109cc525", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19908/mbox/", "series": [ { "id": 4263, "url": "https://patchwork.libcamera.org/api/series/4263/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4263", "date": "2024-04-19T05:53:36", "name": "[v2] ipa: libipa: histogram: Add transform parameter to constructor", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4263/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19908/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19908/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6AC80C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 19 Apr 2024 05:53:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53078633F3;\n\tFri, 19 Apr 2024 07:53:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 796F061B17\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 19 Apr 2024 07:53:52 +0200 (CEST)", "from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21FDA8D0;\n\tFri, 19 Apr 2024 07:53:02 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FXV6LeMO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713505984;\n\tbh=EJDZsG74AzYlR577ccVh7kBT/0AqMRZlc2M+Z3Gio2U=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FXV6LeMOG82G6Ex6ByKNj2EBMgUzO0FSGQkltreuwdvPVOq7aLuKiD1a+nvVwbaOB\n\tBZ6OD1qHooAndJdJxcmLBOawUVSxd/EyVBJxk4hPSD4GrA9sK9FF5MOtdgcnWEcdTj\n\tKvRgrSNpoDfy/9RQbBKS2mDtiRJUKWCet6/M9cFA=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v2] ipa: libipa: histogram: Add transform parameter to\n\tconstructor", "Date": "Fri, 19 Apr 2024 14:53:36 +0900", "Message-Id": "<20240419055336.1070164-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a parameter to the histogram constructor that takes a transformation\nfunction to apply to all the bins upon construction.\n\nThis is necessary notably for the rkisp1, as the values reported from\nthe hardware are 20 bits where the upper 16-bits are meaningful integer\nvalues and the lower 4 bits are fractional and meant to be discarded. As\nadding a right-shift parameter is probably too specialized, a generic\nfunction is added as a parameter instead.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nThis used to be \"ipa: libipa: histogram: Add rshift parameter to\nconstructor\"\n\nChanges in v2:\n- change rshift parameter to a function parameter\n---\n src/ipa/libipa/histogram.cpp | 6 ++++--\n src/ipa/libipa/histogram.h | 6 ++++--\n 2 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp\nindex c1aac59b..2a4095f4 100644\n--- a/src/ipa/libipa/histogram.cpp\n+++ b/src/ipa/libipa/histogram.cpp\n@@ -40,13 +40,15 @@ namespace ipa {\n /**\n * \\brief Create a cumulative histogram\n * \\param[in] data A pre-sorted histogram to be passed\n+ * \\param[in] transform The transformation function to apply to every bin\n */\n-Histogram::Histogram(Span<const uint32_t> data)\n+Histogram::Histogram(Span<const uint32_t> data,\n+\t\t std::function<uint32_t(const uint32_t)> transform)\n {\n \tcumulative_.reserve(data.size());\n \tcumulative_.push_back(0);\n \tfor (const uint32_t &value : data)\n-\t\tcumulative_.push_back(cumulative_.back() + value);\n+\t\tcumulative_.push_back(cumulative_.back() + transform(value));\n }\n \n /**\ndiff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\nindex 54bb2a19..89a6b550 100644\n--- a/src/ipa/libipa/histogram.h\n+++ b/src/ipa/libipa/histogram.h\n@@ -8,9 +8,9 @@\n #pragma once\n \n #include <assert.h>\n+#include <functional>\n #include <limits.h>\n #include <stdint.h>\n-\n #include <vector>\n \n #include <libcamera/base/span.h>\n@@ -23,7 +23,9 @@ class Histogram\n {\n public:\n \tHistogram() { cumulative_.push_back(0); }\n-\tHistogram(Span<const uint32_t> data);\n+\tHistogram(Span<const uint32_t> data,\n+\t\t std::function<uint32_t(const uint32_t)> transform =\n+\t\t \t[](uint32_t x) { return x; });\n \tsize_t bins() const { return cumulative_.size() - 1; }\n \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n \tuint64_t cumulativeFrequency(double bin) const;\n", "prefixes": [ "v2" ] }