Patch Detail
Show a patch.
GET /api/patches/19902/?format=api
{ "id": 19902, "url": "https://patchwork.libcamera.org/api/patches/19902/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19902/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240418074945.47349-2-umang.jain@ideasonboard.com>", "date": "2024-04-18T07:49:44", "name": "[1/2] pipeline: rkisp1: Use cached Request pointer", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "ba755c2305774c83aaa1a014399b7eed80a4dce4", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19902/mbox/", "series": [ { "id": 4261, "url": "https://patchwork.libcamera.org/api/series/4261/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4261", "date": "2024-04-18T07:49:43", "name": "libcamera: Two simple fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4261/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19902/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19902/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F250C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Apr 2024 07:49:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C43EF633FA;\n\tThu, 18 Apr 2024 09:49:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0291861B43\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Apr 2024 09:49:56 +0200 (CEST)", "from fedora.local (unknown [103.251.226.7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EE0E27C;\n\tThu, 18 Apr 2024 09:49:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u/WikHay\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713426548;\n\tbh=VXr3D+TUxrRHSWDqDk0UGq+2PnJnjfPyy2Sjwir6f4c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=u/WikHayjHlz05PWPfx0GuBrnZC2Ud/7Ds5wYYH3JBem8WCnoZ6cF6LwopCQXUIpj\n\tfhB2d1Sh23PVxBNuFuBJZfe4/hCceRxLLNlcLe9Ig6DshZhDofBGg37JzLFDN37oyM\n\tfoP33RngM0TapctBo0Lsvv1NtH6Lv4Dz0Zne4twQ=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH 1/2] pipeline: rkisp1: Use cached Request pointer", "Date": "Thu, 18 Apr 2024 13:19:44 +0530", "Message-ID": "<20240418074945.47349-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240418074945.47349-1-umang.jain@ideasonboard.com>", "References": "<20240418074945.47349-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Request pointer is cached in RkISP1FrameInfo. Use it directly\ninstead of retrieving it via buffer->request().\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex abb21968..5a6c9e1e 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1261,7 +1261,7 @@ void PipelineHandlerRkISP1::bufferReady(FrameBuffer *buffer)\n \t\treturn;\n \n \tconst FrameMetadata &metadata = buffer->metadata();\n-\tRequest *request = buffer->request();\n+\tRequest *request = info->request;\n \n \tif (metadata.status != FrameMetadata::FrameCancelled) {\n \t\t/*\n", "prefixes": [ "1/2" ] }