Patch Detail
Show a patch.
GET /api/patches/19862/?format=api
{ "id": 19862, "url": "https://patchwork.libcamera.org/api/patches/19862/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19862/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240409104044.2107208-1-paul.elder@ideasonboard.com>", "date": "2024-04-09T10:40:44", "name": "utils: ipc: Fix event functions with no parameters", "commit_ref": "9dc601cf7a689fe6eef23189edf0c8a9c38dcfe1", "pull_url": null, "state": "accepted", "archived": false, "hash": "24e26f6e843d62e1be7fa932e03af7f001f0ea98", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19862/mbox/", "series": [ { "id": 4253, "url": "https://patchwork.libcamera.org/api/series/4253/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4253", "date": "2024-04-09T10:40:44", "name": "utils: ipc: Fix event functions with no parameters", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4253/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19862/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19862/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6CA63BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 9 Apr 2024 10:41:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87B2463354;\n\tTue, 9 Apr 2024 12:40:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 333016333F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 9 Apr 2024 12:40:58 +0200 (CEST)", "from pyrite.hamster-moth.ts.net (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 813A68B9;\n\tTue, 9 Apr 2024 12:40:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TCnIOW4Q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712659216;\n\tbh=ZzzRJAhRbc20aj8OQisnfgKoigom4LURvrYj72iDNco=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=TCnIOW4QSJXZyKy2nd9LsJo0qMugmRKyajI3ziVfCLNMC6JIjZ8/agYEPlyZ9ngtt\n\tQtYn0WkPEvAuS/4lKbH8JhtINi/ihO/B3RdMMYEu3ozAv8FbH4VuNOg3yC6r2pT3OF\n\tK114u1+tTI3sLzTn5XvmRYd9p2QuxkmgHSrjUDiI=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] utils: ipc: Fix event functions with no parameters", "Date": "Tue, 9 Apr 2024 19:40:44 +0900", "Message-Id": "<20240409104044.2107208-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If an event function is defined with no parameters, there would be a\ncompilation error complaining about unused parameters in the generated\ncode for the data and dataSize parameters that would normally correspond\nto serialized data. Fix this by simply marking the parameters as\nmaybe_unused.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex c37c4941..238cf4a5 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -235,8 +235,8 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n }\n \n void {{proxy_name}}::{{method.mojom_name}}IPC(\n-\tstd::vector<uint8_t>::const_iterator data,\n-\tsize_t dataSize,\n+\t[[maybe_unused]] std::vector<uint8_t>::const_iterator data,\n+\t[[maybe_unused]] size_t dataSize,\n \t[[maybe_unused]] const std::vector<SharedFD> &fds)\n {\n {%- for param in method.parameters %}\n", "prefixes": [] }