Patch Detail
Show a patch.
GET /api/patches/19799/?format=api
{ "id": 19799, "url": "https://patchwork.libcamera.org/api/patches/19799/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19799/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240324183307.3833076-1-raj.khem@gmail.com>", "date": "2024-03-24T18:33:07", "name": "ipu3: Use posix basename", "commit_ref": "f4d416db9141e7a7802aac00a87500a524c11e37", "pull_url": null, "state": "accepted", "archived": false, "hash": "84e92e9eff99bf44a0835cd0ff76f6a3a5f33e41", "submitter": { "id": 62, "url": "https://patchwork.libcamera.org/api/people/62/?format=api", "name": "Khem Raj", "email": "raj.khem@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19799/mbox/", "series": [ { "id": 4238, "url": "https://patchwork.libcamera.org/api/series/4238/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4238", "date": "2024-03-24T18:33:07", "name": "ipu3: Use posix basename", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4238/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19799/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19799/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D387FBD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 24 Mar 2024 18:33:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E8F06308D;\n\tSun, 24 Mar 2024 19:33:17 +0100 (CET)", "from mail-pl1-x630.google.com (mail-pl1-x630.google.com\n\t[IPv6:2607:f8b0:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2304C61C3C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Mar 2024 19:33:13 +0100 (CET)", "by mail-pl1-x630.google.com with SMTP id\n\td9443c01a7336-1dee5ef2a7bso26146285ad.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 24 Mar 2024 11:33:12 -0700 (PDT)", "from apollo.hsd1.ca.comcast.net ([2601:646:9d80:4380::779c])\n\tby smtp.gmail.com with ESMTPSA id\n\tw1-20020a170902e88100b001db8f7720e2sm2754315plg.288.2024.03.24.11.33.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 24 Mar 2024 11:33:10 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"M5PtbkKM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1711305191; x=1711909991;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=LMNY02B6zIhcvIGKHG7na34DctvN1cJEm8YrA8ae/0Q=;\n\tb=M5PtbkKMnxxK6uoahGhBApyO9LYRQPpbAUnfUnrROVStV0eSJknnlM/CdYYCdROpVk\n\tIocal5n9esPCgfk6jamb72cSodqT3LVDsTcD/2OxDC/tIhDILH4khEMLx0wSML55ELc6\n\t8AWIWGZmVJz06Bv7Nur2wRvFjbgMkUzaYdLv83PBiEQVJH9x0C6d2lbC6MaUU5uUmsE3\n\t/REAqIwveVV7NaulHP6S66YmfilbNlEJqrovYScdyRXkDFOlzNzENFyV2zfBS2EchNS+\n\t69h4sSHOnK1qgkeNFnLcGCOCeKm3d/BPw8E4Dhu9pPc+GSkm7oMkW1csz6Mas7v0AqUR\n\t1F/A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1711305191; x=1711909991;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=LMNY02B6zIhcvIGKHG7na34DctvN1cJEm8YrA8ae/0Q=;\n\tb=uZvemSVQZkKxOJuf3DEYVG+2CtIyd3sjuiMJZir9SPlqn4zOySDeWx985Bi0tSF6un\n\trgKe9TrncBFUmQayynzvttfgJQwobKUG616fD6hCMth972C3YVQLL3P8W5DPesOcDoB1\n\tSf/65t5HYkTGxaZeJDxJ53dz7b2UxYkr0frOAp0X86sHGhG02WZ+DCF0ykDVeLjDAuh5\n\tsKYreG7YE+sK2vWCehnPlTqb0Ygz1ovEgJiYXXV4t2Wwn6DiVzsbqows717Kk2bPbLuD\n\t6CtlnWILoX4DiraHs3odRH28eY2JIenBoF/wT3sgcoz+RwAtRc70koM9dlOhWQnzNvFy\n\tVSfA==", "X-Gm-Message-State": "AOJu0YxiP+V1xlIfvEgMce9nx5NTGol0XFvEzh8Dc6V/Kd78+4eTSb06\n\tpunxBdSeM3GzVDNRPKSHROn09ziC61S7dlYMka0oYJO4iOpztAf1LG/SCR4G", "X-Google-Smtp-Source": "AGHT+IHDjXCJ9dO6hipy9FRZ1e3IqVkS+g023c53CszXMDp3seUOqy7jETtDZq8Nn1NewVclgGkqTA==", "X-Received": "by 2002:a17:903:2448:b0:1dd:a33f:5913 with SMTP id\n\tl8-20020a170903244800b001dda33f5913mr7126957pls.30.1711305190604; \n\tSun, 24 Mar 2024 11:33:10 -0700 (PDT)", "From": "Khem Raj <raj.khem@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com,\n\tKhem Raj <raj.khem@gmail.com>", "Subject": "[PATCH] ipu3: Use posix basename", "Date": "Sun, 24 Mar 2024 11:33:07 -0700", "Message-ID": "<20240324183307.3833076-1-raj.khem@gmail.com>", "X-Mailer": "git-send-email 2.44.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "musl does not implement GNU basename extention and with latest musl\nthe prototype from string.h is also removed [1] which now results in\ncompile errors e.g.\n\n../git/utils/ipu3/ipu3-pack.c:21:47: error: call to undeclared function 'basename'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]\n\nThese utilities are using this function in usage() which is used just\nbefore program exit. Always use the basename APIs from libgen.h which is\nposix implementation\n\n[1] https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7\n\nSigned-off-by: Khem Raj <raj.khem@gmail.com>\n---\n utils/ipu3/ipu3-pack.c | 4 ++--\n utils/ipu3/ipu3-unpack.c | 3 ++-\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/utils/ipu3/ipu3-pack.c b/utils/ipu3/ipu3-pack.c\nindex decbfc6c..23d2db8b 100644\n--- a/utils/ipu3/ipu3-pack.c\n+++ b/utils/ipu3/ipu3-pack.c\n@@ -8,6 +8,7 @@\n \n #include <errno.h>\n #include <fcntl.h>\n+#include <libgen.h>\n #include <stdint.h>\n #include <stdio.h>\n #include <string.h>\n@@ -15,9 +16,8 @@\n #include <sys/types.h>\n #include <unistd.h>\n \n-static void usage(const char *argv0)\n+static void usage(char *argv0)\n {\n-\n \tprintf(\"Usage: %s input-file output-file\\n\", basename(argv0));\n \tprintf(\"Convert unpacked RAW10 Bayer data to the IPU3 packed Bayer formats\\n\");\n \tprintf(\"If the output-file '-', output data will be written to standard output\\n\");\ndiff --git a/utils/ipu3/ipu3-unpack.c b/utils/ipu3/ipu3-unpack.c\nindex 9d2c1200..1505a970 100644\n--- a/utils/ipu3/ipu3-unpack.c\n+++ b/utils/ipu3/ipu3-unpack.c\n@@ -8,6 +8,7 @@\n \n #include <errno.h>\n #include <fcntl.h>\n+#include <libgen.h>\n #include <stdint.h>\n #include <stdio.h>\n #include <string.h>\n@@ -15,7 +16,7 @@\n #include <sys/types.h>\n #include <unistd.h>\n \n-static void usage(const char *argv0)\n+static void usage(char *argv0)\n {\n \tprintf(\"Usage: %s input-file output-file\\n\", basename(argv0));\n \tprintf(\"Unpack the IPU3 raw Bayer format to 16-bit Bayer\\n\");\n", "prefixes": [] }