Patch Detail
Show a patch.
GET /api/patches/19794/?format=api
{ "id": 19794, "url": "https://patchwork.libcamera.org/api/patches/19794/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19794/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240322131451.3092931-9-dan.scally@ideasonboard.com>", "date": "2024-03-22T13:14:49", "name": "[08/10] ipa: rkisp1: Add parseStatistics() to Agc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7696a16ae606e9a62bfdbd91c548d50749a66e1d", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19794/mbox/", "series": [ { "id": 4236, "url": "https://patchwork.libcamera.org/api/series/4236/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4236", "date": "2024-03-22T13:14:41", "name": "Centralise Agc into libipa", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4236/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19794/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19794/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF684C32C5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 22 Mar 2024 13:15:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF3FF63362;\n\tFri, 22 Mar 2024 14:15:21 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B16286307E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 22 Mar 2024 14:15:10 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5FE18CC;\n\tFri, 22 Mar 2024 14:14:41 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WcjB1xek\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711113282;\n\tbh=hHcYPOoPDFIRKQJ+tlevepPv4PcfaBaUHMkH9zmq1+0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WcjB1xekyu/8sv/+W7ZoKz9DQQmFXOBdO2KHzyhZ1ubFntn2Pgp4IBjc7WTXF/M6e\n\tBk2waAo1hVt2WXm+0l/V8nbDdPxGnWRVTjCAvqLH3wS7yyxiglK61/AkYdkPtoT5EP\n\t3pfetoF76sesBg2P6JzSav2gvnIux/vLsnar8l2A=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH 08/10] ipa: rkisp1: Add parseStatistics() to Agc", "Date": "Fri, 22 Mar 2024 13:14:49 +0000", "Message-Id": "<20240322131451.3092931-9-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240322131451.3092931-1-dan.scally@ideasonboard.com>", "References": "<20240322131451.3092931-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In preparation for switching the RkISP1 Agc to a derivation of\nMeanLuminanceAgc, add a function that parses the statistics and\nstores the values for easy retrieval later.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 10 ++++++++++\n src/ipa/rkisp1/algorithms/agc.h | 7 +++++++\n 2 files changed, 17 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 47a6f7b2..d380194d 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -373,6 +373,16 @@ void Agc::fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n \tmetadata.set(controls::FrameDuration, frameDuration.get<std::micro>());\n }\n \n+void Agc::parseStatistics(const rkisp1_stat_buffer *stats,\n+\t\t\t IPAContext &context)\n+{\n+\tconst rkisp1_cif_isp_stat *params = &stats->params;\n+\n+\texpMeans_ = { params->ae.exp_mean, context.hw->numAeCells };\n+\thist_ = Histogram(Span<const uint32_t>(params->hist.hist_bins,\n+\t\t\t\t\t context.hw->numHistogramBins));\n+}\n+\n /**\n * \\brief Process RkISP1 statistics, and run AGC operations\n * \\param[in] context The shared IPA context\ndiff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\nindex fb82a33f..b0de4898 100644\n--- a/src/ipa/rkisp1/algorithms/agc.h\n+++ b/src/ipa/rkisp1/algorithms/agc.h\n@@ -14,6 +14,8 @@\n \n #include <libcamera/geometry.h>\n \n+#include \"libipa/histogram.h\"\n+\n #include \"algorithm.h\"\n \n namespace libcamera {\n@@ -47,10 +49,15 @@ private:\n \tdouble measureBrightness(Span<const uint32_t> hist) const;\n \tvoid fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n \t\t\t ControlList &metadata);\n+\tvoid parseStatistics(const rkisp1_stat_buffer *stats,\n+\t\t\t IPAContext &context);\n \n \tuint64_t frameCount_;\n \n \tutils::Duration filteredExposure_;\n+\n+\tHistogram hist_;\n+\tSpan<const uint8_t> expMeans_;\n };\n \n } /* namespace ipa::rkisp1::algorithms */\n", "prefixes": [ "08/10" ] }