Patch Detail
Show a patch.
GET /api/patches/19778/?format=api
{ "id": 19778, "url": "https://patchwork.libcamera.org/api/patches/19778/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19778/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240319151121.561588-2-kieran.bingham@ideasonboard.com>", "date": "2024-03-19T15:11:20", "name": "[1/2] libcamera: libipa: camera_sensor: Add Sony IMX283 sensor properties", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3781622109f78208fcd97935b26a150973a347e0", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19778/mbox/", "series": [ { "id": 4233, "url": "https://patchwork.libcamera.org/api/series/4233/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4233", "date": "2024-03-19T15:11:19", "name": "ipa: Add support for the Sony IMX283 Camera Sensor.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4233/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19778/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19778/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFA9CC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Mar 2024 15:11:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 749CF62D36;\n\tTue, 19 Mar 2024 16:11:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED75162CAC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Mar 2024 16:11:25 +0100 (CET)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EA6CF02;\n\tTue, 19 Mar 2024 16:10:59 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cxZjUyya\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710861059;\n\tbh=JhlLBBoqkhoJz2njn3cWSKvvg8CXrEoMyJKa5/b/rtk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cxZjUyyaqrIArQYTsTr++wnDrTYPqhH8bebZG/mriqlSat0eAJ8+uqsX4Rspz+K/+\n\trBF0wahYrLjiO2iq5bmbHRTsTWOSbyk+j3YbEpPQB7KdFLFGkRG2muCY+ceEENNA9T\n\tw7YbH6DM2qXd14Wc5A0xYQ/AXFhofs3xY05IdoCw=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 1/2] libcamera: libipa: camera_sensor: Add Sony IMX283 sensor\n\tproperties", "Date": "Tue, 19 Mar 2024 15:11:20 +0000", "Message-Id": "<20240319151121.561588-2-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240319151121.561588-1-kieran.bingham@ideasonboard.com>", "References": "<20240319151121.561588-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the IMX283 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nThe test patterns exposed by the IMX283 do not map well to the current\nset of test pattern controls supplied by libcamera. These are left\ninentionally unimplemented.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex ce29f423e712..f70d898fa94d 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -417,6 +417,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n \n+class CameraSensorHelperImx283 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperImx283()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 0, 2048, -1, 2048 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx283\", CameraSensorHelperImx283)\n+\n class CameraSensorHelperImx290 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 6e28b09e6655..4eabbbdae585 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -99,6 +99,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n \t\t\t},\n \t\t} },\n+\t\t{ \"imx283\", {\n+\t\t\t.unitCellSize = { 2400, 2400 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx290\", {\n \t\t\t.unitCellSize = { 2900, 2900 },\n \t\t\t.testPatternModes = {},\n", "prefixes": [ "1/2" ] }