Patch Detail
Show a patch.
GET /api/patches/19711/?format=api
{ "id": 19711, "url": "https://patchwork.libcamera.org/api/patches/19711/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19711/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240313121223.138150-10-stefan.klug@ideasonboard.com>", "date": "2024-03-13T12:12:20", "name": "[v2,09/12] pipeline: rkisp1: Move call to setSensorControls.emit()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "34e3dd45f89b476a47d82ae2d1bd1f2457ebf8b5", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19711/mbox/", "series": [ { "id": 4221, "url": "https://patchwork.libcamera.org/api/series/4221/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4221", "date": "2024-03-13T12:12:11", "name": "Preparation for per-frame-controls and initial tests", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4221/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19711/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19711/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A876DC32A3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 13 Mar 2024 12:13:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B075A62C9D;\n\tWed, 13 Mar 2024 13:13:02 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D02A62C9D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Mar 2024 13:12:46 +0100 (CET)", "from jasper.fritz.box (unknown\n\t[IPv6:2a00:6020:448c:6c00:9b07:31b5:38e1:e957])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 982EAA8F;\n\tWed, 13 Mar 2024 13:12:23 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PYDfwXqb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710331943;\n\tbh=zUGKUWYuVQ7WOMMNKx2r64dDTVeyWgc35NFIoS2N1sc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PYDfwXqbxB+iS303v9/G/qyfGGLhZAYS72wqK78NkbNsm8gJM8hcH2u+amh9ulmYe\n\tG7P89UW2aD+D0OP0OTWF/McaYpltUqziXhBihicpsbQwCMGQDy9wd1iLv8VK/COik1\n\tdTOIQP58DMF+EeKQGtewsnbizxaOOmlhW38v6e5w=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 09/12] pipeline: rkisp1: Move call to\n\tsetSensorControls.emit()", "Date": "Wed, 13 Mar 2024 13:12:20 +0100", "Message-Id": "<20240313121223.138150-10-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.40.1", "In-Reply-To": "<20240313121223.138150-1-stefan.klug@ideasonboard.com>", "References": "<20240313121223.138150-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "into processStateBuffer(). This is a non-functional change and in\npreparation for the next commit.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 15 +++++----------\n 1 file changed, 5 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 9dc5f53c..7f8d3bc1 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -74,7 +74,7 @@ private:\n \tvoid updateControls(const IPACameraSensorInfo &sensorInfo,\n \t\t\t const ControlInfoMap &sensorControls,\n \t\t\t ControlInfoMap *ipaControls);\n-\tvoid setControls(unsigned int frame);\n+\tControlList getControls(unsigned int frame);\n \n \tstd::map<unsigned int, FrameBuffer> buffers_;\n \tstd::map<unsigned int, MappedFrameBuffer> mappedBuffers_;\n@@ -367,7 +367,8 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId\n \t\talgo->process(context_, frame, frameContext, stats, metadata);\n \t}\n \n-\tsetControls(frame);\n+\tControlList ctrls = getControls(frame);\n+\tsetSensorControls.emit(frame, ctrls);\n \n \tmetadataReady.emit(frame, metadata);\n }\n@@ -430,13 +431,8 @@ void IPARkISP1::updateControls(const IPACameraSensorInfo &sensorInfo,\n \t*ipaControls = ControlInfoMap(std::move(ctrlMap), controls::controls);\n }\n \n-void IPARkISP1::setControls(unsigned int frame)\n+ControlList IPARkISP1::getControls(unsigned int frame)\n {\n-\t/*\n-\t * \\todo The frame number is most likely wrong here, we need to take\n-\t * internal sensor delays and other timing parameters into account.\n-\t */\n-\n \tIPAFrameContext &frameContext = context_.frameContexts.get(frame);\n \tuint32_t exposure = frameContext.agc.exposure;\n \tuint32_t gain = camHelper_->gainCode(frameContext.agc.gain);\n@@ -444,8 +440,7 @@ void IPARkISP1::setControls(unsigned int frame)\n \tControlList ctrls(sensorControls_);\n \tctrls.set(V4L2_CID_EXPOSURE, static_cast<int32_t>(exposure));\n \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast<int32_t>(gain));\n-\n-\tsetSensorControls.emit(frame, ctrls);\n+\treturn ctrls;\n }\n \n } /* namespace ipa::rkisp1 */\n", "prefixes": [ "v2", "09/12" ] }