Patch Detail
Show a patch.
GET /api/patches/19682/?format=api
{ "id": 19682, "url": "https://patchwork.libcamera.org/api/patches/19682/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19682/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240311142604.326356-1-kieran.bingham@ideasonboard.com>", "date": "2024-03-11T14:26:04", "name": "[v2] utils: checkstyle.py: Fix known_trailers sort order", "commit_ref": "cdb07a02179ee557bc35234ea852eceff35a4980", "pull_url": null, "state": "accepted", "archived": false, "hash": "56e5aef6bd8c3327d898a4b0dd8a5d9e3aff81b7", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19682/mbox/", "series": [ { "id": 4215, "url": "https://patchwork.libcamera.org/api/series/4215/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4215", "date": "2024-03-11T14:26:04", "name": "[v2] utils: checkstyle.py: Fix known_trailers sort order", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4215/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19682/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19682/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 737F9BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 11 Mar 2024 14:26:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01F5462C8C;\n\tMon, 11 Mar 2024 15:26:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F243A62C8B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 Mar 2024 15:26:08 +0100 (CET)", "from Monstersaurus.local\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D1DEF0A;\n\tMon, 11 Mar 2024 15:25:47 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FJSW9PBl\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710167147;\n\tbh=/g5TqUMZD56xLS9ee+FDvgxbx5vbqV0HYVEFgzY2D34=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FJSW9PBlrLywQ1Ragtm0oPVjSmBhSPIoFLcc1GycFQ1gXlX4t3g246X7SZVj3xFBs\n\thj3Lc09tdN3OjcRkK7HCbxtlz5TjBdEcT6YiXwnsceECG6wqvlaCTMkVKUseE08b+E\n\tymZrREiivnFtl7xg0Ymp/nfiug63la6mE4q22HB8=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Subject": "[PATCH v2] utils: checkstyle.py: Fix known_trailers sort order", "Date": "Mon, 11 Mar 2024 14:26:04 +0000", "Message-Id": "<20240311142604.326356-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hans de Goede <hdegoede@redhat.com>\n\nAn unruly libcamera maintainer merged the wrong patch adding the\nCo-developed-by: tag to the known_trailers.\n\nFix the sort order alphabetically to match the version which should have\nbeen merged.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\nKeeping Hans' authorship on the commit to reflect that /he/ got the\nfinal code state right. But I keep getting things wrong ;-)\n\nv2:\n - move the line rather than duplicate it!\n\n\n utils/checkstyle.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 52cf770c9da3..db5a550d518f 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -471,6 +471,7 @@ class TrailersChecker(CommitChecker):\n known_trailers = {\n 'Acked-by': email_regex,\n 'Bug': link_regex,\n+ 'Co-developed-by': email_regex,\n 'Fixes': commit_regex,\n 'Link': link_regex,\n 'Reported-by': validate_reported_by,\n@@ -478,7 +479,6 @@ class TrailersChecker(CommitChecker):\n 'Signed-off-by': email_regex,\n 'Suggested-by': email_regex,\n 'Tested-by': email_regex,\n- 'Co-developed-by': email_regex,\n }\n \n trailer_regex = re.compile(r'([A-Z][a-zA-Z-]*)\\s*:\\s*(.*)')\n", "prefixes": [ "v2" ] }