Patch Detail
Show a patch.
GET /api/patches/19667/?format=api
{ "id": 19667, "url": "https://patchwork.libcamera.org/api/patches/19667/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19667/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240311141524.27192-5-hdegoede@redhat.com>", "date": "2024-03-11T14:15:08", "name": "[v5,04/18] libcamera: internal: Move SharedMemObject class to a common directory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "abaf62badf7ac72e0baeccd10728c9de66c07b69", "submitter": { "id": 102, "url": "https://patchwork.libcamera.org/api/people/102/?format=api", "name": "Hans de Goede", "email": "hdegoede@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19667/mbox/", "series": [ { "id": 4214, "url": "https://patchwork.libcamera.org/api/series/4214/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4214", "date": "2024-03-11T14:15:04", "name": "libcamera: introduce Software ISP and Software IPA", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4214/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19667/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19667/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F4E6BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 11 Mar 2024 14:15:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B124662C91;\n\tMon, 11 Mar 2024 15:15:41 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71ED261C7C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 11 Mar 2024 15:15:38 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-245-WiufzOTFPa--iB1b4DIfig-1; Mon, 11 Mar 2024 10:15:33 -0400", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F0B5188B2A0;\n\tMon, 11 Mar 2024 14:15:33 +0000 (UTC)", "from x1.localdomain.com (unknown [10.39.195.37])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 21FD11C060D0;\n\tMon, 11 Mar 2024 14:15:32 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"RwIkdMPZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1710166537;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=+QwwWzbhudPUmpsgODMI6MR5Ohsj4Fr43J7OIsfqEs0=;\n\tb=RwIkdMPZX0TLc2aIs1G56DnleNt5XOAuHGMTD7HLOT+aXUOZ383SfpvKBEQ3SXCVtSy019\n\tqpgisUFnhXMcGeNbCuaqMTyHuOS0M5Cp5r3renWEWFSyJ12jnp8C4mIfg2qH5C/QjiekNU\n\tHAs2ivx+X1w+0u7B95EBbHdhkW+8nzo=", "X-MC-Unique": "WiufzOTFPa--iB1b4DIfig-1", "From": "Hans de Goede <hdegoede@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v5 04/18] libcamera: internal: Move SharedMemObject class to\n\ta common directory", "Date": "Mon, 11 Mar 2024 15:15:08 +0100", "Message-ID": "<20240311141524.27192-5-hdegoede@redhat.com>", "In-Reply-To": "<20240311141524.27192-1-hdegoede@redhat.com>", "References": "<20240311141524.27192-1-hdegoede@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Maxime Ripard <mripard@redhat.com>, Pavel Machek <pavel@ucw.cz>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Andrey Konovalov <andrey.konovalov@linaro.org>\n\nMove SharedMemObject class out of RPi namespace and put it into\ninclude/libcamera/internal so that everyone could use it.\n\nTested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> # sc8280xp Lenovo x13s\nTested-by: Pavel Machek <pavel@ucw.cz>\nReviewed-by: Pavel Machek <pavel@ucw.cz>\nSigned-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\n---\n include/libcamera/internal/meson.build | 1 +\n .../libcamera/internal}/shared_mem_object.h | 6 +-----\n 2 files changed, 2 insertions(+), 5 deletions(-)\n rename {src/libcamera/pipeline/rpi/common => include/libcamera/internal}/shared_mem_object.h (97%)", "diff": "diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\nindex 33eb0fb3..5807dfd9 100644\n--- a/include/libcamera/internal/meson.build\n+++ b/include/libcamera/internal/meson.build\n@@ -39,6 +39,7 @@ libcamera_internal_headers = files([\n 'process.h',\n 'pub_key.h',\n 'request.h',\n+ 'shared_mem_object.h',\n 'source_paths.h',\n 'sysfs.h',\n 'v4l2_device.h',\ndiff --git a/src/libcamera/pipeline/rpi/common/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nsimilarity index 97%\nrename from src/libcamera/pipeline/rpi/common/shared_mem_object.h\nrename to include/libcamera/internal/shared_mem_object.h\nindex aa56c220..98636b44 100644\n--- a/src/libcamera/pipeline/rpi/common/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -6,8 +6,8 @@\n */\n #pragma once\n \n-#include <cstddef>\n #include <fcntl.h>\n+#include <stddef.h>\n #include <string>\n #include <sys/mman.h>\n #include <sys/stat.h>\n@@ -19,8 +19,6 @@\n \n namespace libcamera {\n \n-namespace RPi {\n-\n template<class T>\n class SharedMemObject\n {\n@@ -123,6 +121,4 @@ private:\n \tT *obj_;\n };\n \n-} /* namespace RPi */\n-\n } /* namespace libcamera */\n", "prefixes": [ "v5", "04/18" ] }