Patch Detail
Show a patch.
GET /api/patches/19649/?format=api
{ "id": 19649, "url": "https://patchwork.libcamera.org/api/patches/19649/?format=api", "web_url": "https://patchwork.libcamera.org/patch/19649/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240310012946.727641-2-pobrn@protonmail.com>", "date": "2024-03-10T01:29:54", "name": "[v1,1/3] libcamera: framebuffer_allocator: move from argument in constructor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "37a3443489cc84108b919be633f1b0feb4724900", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/19649/mbox/", "series": [ { "id": 4208, "url": "https://patchwork.libcamera.org/api/series/4208/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4208", "date": "2024-03-10T01:29:49", "name": "couple FrameBufferAllocator changes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4208/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/19649/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/19649/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77D3BBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 10 Mar 2024 01:30:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3691B62875;\n\tSun, 10 Mar 2024 02:30:19 +0100 (CET)", "from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6869D62871\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 10 Mar 2024 02:30:18 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"Yp/lC0U2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1710034218; x=1710293418;\n\tbh=JHrwu+YgxB61Wqd6C1h48Hd/WQri8yRKt0yhoobnWVs=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=Yp/lC0U2ZQ5CrWK5WeKVtgVpY9ICQ3jaVQ/Kwf035E7LgKYO+mL9b5NONNm1CY+vE\n\tV6eD1D843e7Osm8ZvDlZt3C422Ywg/MvUbMLThDCJ0eQVLB3xG0KiVTDytX73jq6zn\n\tqAZHjI10jC7D39B9Mdlnp7SKI1l79iH99caoznBywqWR8OfNFEHECEmB4CTEhxl/9/\n\tRgSBqcQu0n5cod6PLw7oqwIRRFP0d3lGUsmCUB1wTNKpda6wLb2XMt5YeOxfNiZF/1\n\trLDA8FxrMzE2fU7Re2ygTp96Wb4Z77dM8WfB5uWpMN6DCafCvtHbhheBdr9rx1mxSV\n\t3SP2psIg0jnMg==", "Date": "Sun, 10 Mar 2024 01:29:54 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH v1 1/3] libcamera: framebuffer_allocator: move from argument\n\tin constructor", "Message-ID": "<20240310012946.727641-2-pobrn@protonmail.com>", "In-Reply-To": "<20240310012946.727641-1-pobrn@protonmail.com>", "References": "<20240310012946.727641-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The single argument, of type `std::shared_ptr<Camera>`,\nis passed by value, so it can simply be moved from in order to\navoid calling the copy constructor.\n---\n src/libcamera/framebuffer_allocator.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp\nindex 94389735..8cf45ab2 100644\n--- a/src/libcamera/framebuffer_allocator.cpp\n+++ b/src/libcamera/framebuffer_allocator.cpp\n@@ -59,7 +59,7 @@ LOG_DEFINE_CATEGORY(Allocator)\n * \\param[in] camera The camera\n */\n FrameBufferAllocator::FrameBufferAllocator(std::shared_ptr<Camera> camera)\n-\t: camera_(camera)\n+\t: camera_(std::move(camera))\n {\n }\n \n", "prefixes": [ "v1", "1/3" ] }